Basic postPause and resume
ClosedPublic
Actions

Authored by rizzitello on Feb 25 2018, 8:03 PM.

Details

Reviewers

laysrodrigues
tcanabrava
patrickelectric

Commits

R231:76106a246b5b: Basic postPause and resume
R231:c17d7fb246de: Add Basic postPause support Add Basic Resume support

Summary

Add Basic postPause support
Add Basic Resume support

Diff Detail

Repository

R231 Atelier

Branch

postPause

Lint

No Linters Available

Unit

No Unit Test Coverage

rizzitello requested review of this revision.Feb 25 2018, 8:03 PM

rizzitello created this revision.

rizzitello added reviewers: laysrodrigues, tcanabrava, patrickelectric.Feb 25 2018, 8:03 PM

rizzitello added a project: Atelier: General Development.

rizzitello added a subscriber: Atelier: General Development.

This won't be compatible if more than one printer is connected, will be necessary to pass the profile to AtCoreInstanceWidget... Can you hold this until we merge my diffs?

This revision now requires changes to proceed.Feb 26 2018, 12:06 AM

The parts in mainwindow would be moved to atcoreinstance and newConnection in refactor.

Move the pause to atcoreinstance

rebase

patrickelectric accepted this revision.Mar 1 2018, 3:02 AM

laysrodrigues accepted this revision.Mar 1 2018, 10:23 PM

This revision is now accepted and ready to land.Mar 1 2018, 10:23 PM

rizzitello closed this revision.Mar 1 2018, 11:05 PM

rizzitello mentioned this in D11024: Support for injected commands V2.Mar 5 2018, 12:33 AM

Revision Contents
Changeset List

			Path	Packages
M			src/dialogs/connectsettingsdialog.cpp (1 line)
M			src/dialogs/profilesdialog.cpp (2 lines)
M			src/dialogs/profilesdialog.ui (18 lines)
M			src/widgets/atcoreinstancewidget.h (3 lines)
M			src/widgets/atcoreinstancewidget.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28063	bb4154a		Feb 25 2018, 8:03 PM	★	★
Diff 2	28225	dd4a0c7	- Move the pause to atcoreinstance	Feb 27 2018, 9:51 PM	★	★
Diff 3	28226	129daa9	- rebase	Feb 27 2018, 9:55 PM	★	★