Prepare for atcoreinstance
ClosedPublic
Actions

src/dialogs/profilesdialog.cpp
200	The problem that @rizzitello and I found is that to get those data we need to create and AtCore variable to get them, only for that, and we thought that is a shit solution(At least I did). We need to discover a better way to get those firmwares without the need to create an AtCore instance.

This is a problem that need to be solved in atcore, and not doing workarounds in the printerhost.

Not in the profiles dialog. I've opted to remove the debug calls here as
well

rizzitello marked 2 inline comments as done.Feb 27 2018, 1:25 PM

rizzitello added inline comments.

src/dialogs/profilesdialog.cpp
200	I agree with @laysrodrigues . We had to change this for the above reasons. This does not remove atcore ability to send this data I just creates a local function so we dont need to link atcore for the data. This is also a slimer version of what is in AtCore itself. (does the same but in less lines)

Revision Contents
Changeset List

			Path	Packages
M			src/dialogs/profilesdialog.h (23 lines)
M			src/dialogs/profilesdialog.cpp (54 lines)
M			src/mainwindow.h (2 lines)
M			src/mainwindow.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28082	bb4154a		Feb 26 2018, 3:31 AM	★	★
Diff 2	28144	bb4154a	- Move SERIAL:BAUDS and detectFW to profilesdialog	Feb 26 2018, 10:23 PM	★	★
Diff 3	28160	bb4154a	- Add ProfilesDialog::detectFWPlugins() to find atcore plugins without atcore.	Feb 27 2018, 1:59 AM	★	★
Diff 4	28223	dd4a0c7	- rebase	Feb 27 2018, 9:18 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
fbce9f379e13	6d7071c5cd3e	681681296ca0	Chris Rizzitello	- Add SERIAL:BAUDS to ProfilesDialog (Show More…)	Feb 26 2018, 3:24 AM
681681296ca0	f6117654d4e4	dd4a0c79832c	Chris Rizzitello	Add ProfilesDialog::detectFWPlugins() to find atcore plugins without atcore. (Show More…)	Feb 26 2018, 3:21 AM