Differential D10244

Change lambdas to use reference and not copy
AbandonedPublic
Actions

Authored by patrickelectric on Feb 2 2018, 12:45 AM.

Details

Reviewers
tcanabrava
rizzitello
laysrodrigues
Summary

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>

Diff Detail

Repository
R232 AtCore
Branch
correct_lambidas
Lint
No Linters Available
Unit
No Unit Test Coverage
patrickelectric requested review of this revision.Feb 2 2018, 12:45 AM
patrickelectric created this revision.
rizzitello accepted this revision.Feb 2 2018, 1:47 AM
This revision is now accepted and ready to land.Feb 2 2018, 1:47 AM
tcanabrava added a comment.Feb 2 2018, 9:06 AM

I still don't like it. can we capture only the things we need instead of everything?

broulik added a subscriber: broulik.Feb 2 2018, 3:50 PM
can we capture only the things we need instead of everything?

I think in all cases you can just capture [this].

patrickelectric updated this revision to Diff 26378.Feb 2 2018, 4:34 PM

Use this and not ref

rizzitello accepted this revision.Feb 2 2018, 9:27 PM

[this] seams to work well.

patrickelectric requested review of this revision.Feb 7 2018, 6:35 PM

we can merge this ?

Revision Contents
Changeset List

Diff 26378

View Options

testclient/mainwindow.cpp

Loading...
View Options

testclient/widgets/axiscontrol.cpp

Loading...