Differential D8969

Basic support for disabling motors
ClosedPublic
Actions

Authored by rizzitello on Nov 23 2017, 3:31 PM.

Details

Reviewers
laysrodrigues
patrickelectric
tcanabrava
Commits
R232:2ef802eae237: Basic support for disabling motors
R232:d486cf6784e4: Support M84
R232:7e2692f1b2c0: Add setIdleHold(uint). If sent with 0 will send M84 to disable motors send non…
Summary

Support M84
Add setIdleHold(uint). If sent with 0 will send M84 to disable motors send non 0 to delay disabling by that many seconds

Test Plan

Tested on Repetier needs testing on other firmwares, but should work the same
on them as Repetier.

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello created this revision.Nov 23 2017, 3:31 PM
rizzitello updated this revision to Diff 22835.Nov 23 2017, 3:41 PM
  • Added Line in gcodetests
  • Fixed typo in atcore.h
  • Removed auto added amp; in mainwindow.ui
rizzitello updated this revision to Diff 22837.Nov 23 2017, 3:44 PM
  • Adjust wording of doxygen comment for setIdleHold
patrickelectric added a comment.Nov 23 2017, 3:47 PM

should this be M18, no ?

rizzitello added a comment.EditedNov 23 2017, 3:52 PM

Yes and no M18 does disable the steppers on some firmwares. This will disable the power being sent to those motors after some delay . This is from the perspective of the user does the samething . The main differance being that M84 is supported by most all of the reprap firmwares.

patrickelectric requested changes to this revision.Nov 23 2017, 4:02 PM
patrickelectric added inline comments.
src/gcodecommands.cpp
515

don't need this else.

This revision now requires changes to proceed.Nov 23 2017, 4:02 PM
rizzitello marked an inline comment as done.Nov 23 2017, 4:09 PM
rizzitello added inline comments.
src/gcodecommands.cpp
515

Unfortunately sending M84 S0 causes the firmware to not disable the hold. I Did test first without it but had to add it after testing.

patrickelectric added inline comments.Nov 23 2017, 4:33 PM
src/gcodecommands.cpp
515

If you return in the first if, you'll not need a else..

rizzitello updated this revision to Diff 22842.Nov 23 2017, 4:48 PM
rizzitello marked an inline comment as done.
  • Patrick suggestions
rizzitello marked an inline comment as done.Nov 23 2017, 4:49 PM
rizzitello added inline comments.
src/gcodecommands.cpp
515

Sorry I misunderstood what you ment by that.

rizzitello marked an inline comment as done.Nov 23 2017, 4:51 PM
patrickelectric accepted this revision.Nov 23 2017, 5:04 PM
This revision is now accepted and ready to land.Nov 23 2017, 5:04 PM
Closed by commit R232:d486cf6784e4: Support M84 (authored by rizzitello). · Explain WhyNov 23 2017, 5:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22844

View Options

src/gcodecommands.cpp

Loading...
View Options

unittests/gcodetests.h

Loading...
View Options

unittests/gcodetests.cpp

Loading...