Feed Advanced Search

Tue, Feb 19

patrickelectric added reviewers for D19166: Add application path as valid path for debuggers: davidedmundson, tcanabrava, ngraham.
Tue, Feb 19, 7:08 PM · Plasma
patrickelectric updated the diff for D19166: Add application path as valid path for debuggers.

 - Add application path as valid path for debuggers

Tue, Feb 19, 7:03 PM · Plasma
patrickelectric requested review of D19166: Add application path as valid path for debuggers.
Tue, Feb 19, 7:01 PM · Plasma

Fri, Feb 15

patrickelectric committed R871:31b028cc8059: Print debug information about debuggers (authored by patrickelectric).
Print debug information about debuggers
Fri, Feb 15, 7:27 PM
patrickelectric committed R871:a32ec5e298a4: cdb: First working version (authored by patrickelectric).
cdb: First working version
Fri, Feb 15, 1:54 PM
patrickelectric closed D18859: cdb: First working version.
Fri, Feb 15, 1:54 PM · Plasma
patrickelectric updated the diff for D18859: cdb: First working version.

Add missing override

Fri, Feb 15, 1:09 PM · Plasma

Tue, Feb 12

patrickelectric added inline comments to D18930: Remove conditional debug output.
Tue, Feb 12, 3:54 PM
patrickelectric updated the summary of D18859: cdb: First working version.
Tue, Feb 12, 3:22 PM · Plasma
patrickelectric updated the summary of D18859: cdb: First working version.
Tue, Feb 12, 3:17 PM · Plasma
patrickelectric added a comment to D18859: cdb: First working version.

Make tomaz happy

Tue, Feb 12, 3:11 PM · Plasma
patrickelectric updated the diff for D18859: cdb: First working version.

remove virtual, override.

Tue, Feb 12, 3:11 PM · Plasma
patrickelectric added reviewers for D18859: cdb: First working version: davidedmundson, tcanabrava, ngraham.
Tue, Feb 12, 3:04 PM · Plasma
patrickelectric added a comment to D18859: cdb: First working version.

This is a screenshot of drkonqi on windows, it was built with craft and integrated with a WIP project.

Tue, Feb 12, 3:01 PM · Plasma
patrickelectric retitled D18859: cdb: First working version from [WIP] msvc: First commit to cdb: First working version.
Tue, Feb 12, 3:00 PM · Plasma
patrickelectric updated the diff for D18859: cdb: First working version.

Correct and initial implementation

Tue, Feb 12, 3:00 PM · Plasma

Mon, Feb 11

patrickelectric committed R871:315b444945ee: wip (authored by patrickelectric).
wip
Mon, Feb 11, 10:41 PM
patrickelectric accepted D18916: Support Auto Temperature Reporting.
Mon, Feb 11, 5:38 PM · Atelier
patrickelectric accepted D18917: Fix Profile save behavior.
Mon, Feb 11, 5:37 PM · Atelier
patrickelectric accepted D18003: Save firmware if known in the profile..
Mon, Feb 11, 12:11 AM · Atelier: General Development

Sun, Feb 10

patrickelectric committed R871:3102b477d03d: CMakeLists: Fix bfd.h include path on windows (authored by patrickelectric).
CMakeLists: Fix bfd.h include path on windows
Sun, Feb 10, 9:29 PM
patrickelectric closed D18801: CMakeLists: Fix bfd.h include path on windows.
Sun, Feb 10, 9:29 PM · Plasma
patrickelectric updated the diff for D18801: CMakeLists: Fix bfd.h include path on windows.

Fix Tomaz

Sun, Feb 10, 9:29 PM · Plasma
patrickelectric committed R871:e01d73c3c3be: Fix pragma once problem with process class (authored by patrickelectric).
Fix pragma once problem with process class
Sun, Feb 10, 9:25 PM
patrickelectric closed D18802: Fix pragma once problem with process class.
Sun, Feb 10, 9:25 PM · Plasma
patrickelectric committed R232:3fdb530047cc: atcore: Add availableFirmwarePluginsChanged (authored by patrickelectric).
atcore: Add availableFirmwarePluginsChanged
Sun, Feb 10, 9:12 PM
patrickelectric committed R232:ae60ec5e5677: ifirmware: Add CONSTATNT argument in Q_PROPERTY (authored by patrickelectric).
ifirmware: Add CONSTATNT argument in Q_PROPERTY
Sun, Feb 10, 9:11 PM
patrickelectric committed R232:1e0b52c0e1a3: atcore: Add availableFirmwarePluginsChanged (authored by patrickelectric).
atcore: Add availableFirmwarePluginsChanged
Sun, Feb 10, 9:11 PM
patrickelectric closed D18897: atcore: Add availableFirmwarePluginsChanged.
Sun, Feb 10, 9:11 PM
patrickelectric accepted D18897: atcore: Add availableFirmwarePluginsChanged.
Sun, Feb 10, 3:43 PM
patrickelectric accepted D18584: Use Smart pointer for temperature object.
Sun, Feb 10, 3:21 PM · Atelier: AtCore
patrickelectric accepted D18586: Fix Failed Sprinter Test by capturing temperature with or with out decimal.
Sun, Feb 10, 3:21 PM · Atelier: AtCore

Sat, Feb 9

patrickelectric accepted D18874: Simplify Temperature Object.
Sat, Feb 9, 11:34 PM · Atelier: AtCore
patrickelectric accepted D18879: Adjust for Temperature Object.
Sat, Feb 9, 11:34 PM · Atelier
patrickelectric added a comment to D18802: Fix pragma once problem with process class.

https://stackoverflow.com/questions/17107410/qt-field-has-incomplete-type

Sat, Feb 9, 6:27 PM · Plasma
patrickelectric added a comment to D18802: Fix pragma once problem with process class.

@mart commit message updated, @alexeymin I believe that you'll find the answer for this question in my new commit message :)

It hasn't updated what phab shows.

Sat, Feb 9, 4:26 PM · Plasma
patrickelectric added a comment to D18802: Fix pragma once problem with process class.

Also, this PR is really important to help Craft since the patch command used to apply .diffs/patchs can't move/rename files.
This patch needs to be added manually to do the build.

Sat, Feb 9, 2:39 PM · Plasma
patrickelectric added a comment to D18802: Fix pragma once problem with process class.

@mart commit message updated, @alexeymin I believe that you'll find the answer for this question in my new commit message :)

Sat, Feb 9, 2:36 PM · Plasma
patrickelectric updated the diff for D18802: Fix pragma once problem with process class.

Update commit message

Sat, Feb 9, 2:35 PM · Plasma
patrickelectric added a comment to D18801: CMakeLists: Fix bfd.h include path on windows.

@mart commit message updated.

Sat, Feb 9, 2:32 PM · Plasma
patrickelectric updated the diff for D18801: CMakeLists: Fix bfd.h include path on windows.

update commit message

Sat, Feb 9, 2:31 PM · Plasma
patrickelectric added inline comments to D18874: Simplify Temperature Object.
Sat, Feb 9, 2:26 PM · Atelier: AtCore

Fri, Feb 8

patrickelectric committed R871:7106b832e9d4: mingw_generator: Fix iterator type in operator== (authored by patrickelectric).
mingw_generator: Fix iterator type in operator==
Fri, Feb 8, 9:49 PM
patrickelectric committed R871:c850a7c8180c: mingw_generator: Fix argument type (authored by patrickelectric).
mingw_generator: Fix argument type
Fri, Feb 8, 9:45 PM
patrickelectric committed R871:35eba45f1ec4: mingw_generator: Fix iterator type (authored by patrickelectric).
mingw_generator: Fix iterator type
Fri, Feb 8, 9:45 PM
patrickelectric added a reviewer for D18802: Fix pragma once problem with process class: ngraham.
Fri, Feb 8, 9:33 PM · Plasma
patrickelectric added a reviewer for D18801: CMakeLists: Fix bfd.h include path on windows: ngraham.
Fri, Feb 8, 9:33 PM · Plasma
patrickelectric retitled D18859: cdb: First working version from msvc: First commit to [WIP] msvc: First commit.
Fri, Feb 8, 9:16 PM · Plasma
patrickelectric added a comment to D18859: cdb: First working version.

thank you @ngraham, but this is not ready to review yet.
But be free to review @D18801 and @D18802

Fri, Feb 8, 9:14 PM · Plasma
patrickelectric updated the diff for D18859: cdb: First working version.
  • msvc: Add cdb configuration
Fri, Feb 8, 7:00 PM · Plasma
patrickelectric requested review of D18859: cdb: First working version.
Fri, Feb 8, 6:35 PM · Plasma
patrickelectric committed R871:aac1c1067eb5: msvc_gnerator: Fix PCHAR cast to QString (authored by patrickelectric).
msvc_gnerator: Fix PCHAR cast to QString
Fri, Feb 8, 1:02 PM
patrickelectric committed R871:64b91d5c3f0c: QtCore is common between MINGW and MSVC (authored by patrickelectric).
QtCore is common between MINGW and MSVC
Fri, Feb 8, 1:02 PM

Thu, Feb 7

patrickelectric added a reviewer for D18832: runtime: Add error message about env variables: vonreth.
Thu, Feb 7, 11:04 PM
patrickelectric requested review of D18832: runtime: Add error message about env variables.
Thu, Feb 7, 11:02 PM

Wed, Feb 6

patrickelectric added reviewers for D18802: Fix pragma once problem with process class: davidedmundson, tcanabrava.
Wed, Feb 6, 11:40 PM · Plasma
patrickelectric requested review of D18802: Fix pragma once problem with process class.
Wed, Feb 6, 11:39 PM · Plasma
patrickelectric retitled D18801: CMakeLists: Fix bfd.h include path on windows from CMakeLists: Fix bgd.h include path on windows to CMakeLists: Fix bfd.h include path on windows.
Wed, Feb 6, 11:35 PM · Plasma
patrickelectric updated the diff for D18801: CMakeLists: Fix bfd.h include path on windows.

Fix commit message

Wed, Feb 6, 11:35 PM · Plasma
patrickelectric added reviewers for D18801: CMakeLists: Fix bfd.h include path on windows: davidedmundson, tcanabrava.
Wed, Feb 6, 11:33 PM · Plasma
patrickelectric requested review of D18801: CMakeLists: Fix bfd.h include path on windows.
Wed, Feb 6, 11:31 PM · Plasma
patrickelectric committed R877:cc41362f429d: drkonqi: Add blueprint (authored by patrickelectric).
drkonqi: Add blueprint
Wed, Feb 6, 11:18 PM
patrickelectric closed D17513: drkonqi: Add blueprint.
Wed, Feb 6, 11:18 PM

Sun, Feb 3

patrickelectric added inline comments to D18586: Fix Failed Sprinter Test by capturing temperature with or with out decimal.
Sun, Feb 3, 1:53 PM · Atelier: AtCore

Mon, Jan 28

patrickelectric added inline comments to D18472: Create Bed Deform Object.
Mon, Jan 28, 2:11 PM · Atelier: AtCore

Sun, Jan 27

patrickelectric accepted D18350: Add support for auto temperature reporting.
Sun, Jan 27, 11:46 PM · Atelier: AtCore
patrickelectric added inline comments to D18472: Create Bed Deform Object.
Sun, Jan 27, 11:43 PM · Atelier: AtCore

Sat, Jan 26

patrickelectric accepted D18459: Add CONSTENT to constant Q_Properties to avoid warning when used via qml.

Great

Sat, Jan 26, 5:00 PM · Atelier: AtCore
patrickelectric accepted D18468: Track the lastCommand set to the printer.
Sat, Jan 26, 5:00 PM · Atelier: AtCore
patrickelectric accepted D18469: Add return for GCode::toCommand for G29.
Sat, Jan 26, 5:00 PM · Atelier: AtCore
patrickelectric accepted D18525: Only force G and M codes toUpper.
Sat, Jan 26, 4:59 PM · Atelier: AtCore
patrickelectric requested changes to D18472: Create Bed Deform Object.
Sat, Jan 26, 2:21 PM · Atelier: AtCore
patrickelectric requested changes to D18350: Add support for auto temperature reporting.
Sat, Jan 26, 1:52 PM · Atelier: AtCore

Jan 19 2019

patrickelectric requested changes to D18350: Add support for auto temperature reporting.
Jan 19 2019, 12:39 PM · Atelier: AtCore
patrickelectric accepted D18334: Add Support for M155 command.
Jan 19 2019, 12:34 PM · Atelier: AtCore
patrickelectric accepted D18349: Ensure that when we request firmware info nothing else is in the queue.
Jan 19 2019, 12:34 PM · Atelier: AtCore

Jan 16 2019

patrickelectric requested changes to D18265: Retry for resend requests.
Jan 16 2019, 1:16 PM · Atelier: AtCore

Jan 15 2019

patrickelectric accepted D18268: Adjust our Timer Fix.
Jan 15 2019, 10:11 PM · Atelier: AtCore
patrickelectric requested changes to D18268: Adjust our Timer Fix.
Jan 15 2019, 10:08 PM · Atelier: AtCore
patrickelectric accepted D18268: Adjust our Timer Fix.
Jan 15 2019, 10:08 PM · Atelier: AtCore
patrickelectric requested changes to D18268: Adjust our Timer Fix.
Jan 15 2019, 9:12 PM · Atelier: AtCore

Dec 28 2018

patrickelectric added a comment to D17588: MainWindow: Add Frameless option.

@sandsmark Corrections done.

Dec 28 2018, 3:54 PM · Konsole
patrickelectric updated the diff for D17588: MainWindow: Add Frameless option.

Add ui correction and remove tooltip

Dec 28 2018, 3:50 PM · Konsole
patrickelectric added a comment to D17759: Correct includes.

@hindenburg corrections done.

Dec 28 2018, 2:45 PM · Konsole
patrickelectric updated the diff for D17759: Correct includes.

Add missing QList

Dec 28 2018, 2:44 PM · Konsole

Dec 27 2018

patrickelectric accepted D17819: Reset post list on refresh.
Dec 27 2018, 2:54 PM · Atelier

Dec 24 2018

patrickelectric committed R232:69512133b160: mainwindow: Remove unused QSerialPort (authored by patrickelectric).
mainwindow: Remove unused QSerialPort
Dec 24 2018, 1:38 PM
patrickelectric committed R232:ffd2d72867c3: Correct QtTest include (authored by patrickelectric).
Correct QtTest include
Dec 24 2018, 1:38 PM
patrickelectric committed R232:9c464acff040: mainwindow: Remove unused QSerialPort (authored by patrickelectric).
mainwindow: Remove unused QSerialPort
Dec 24 2018, 1:38 PM
patrickelectric closed D17761: mainwindow: Remove unused QSerialPort.
Dec 24 2018, 1:38 PM
patrickelectric added a comment to D17759: Correct includes.

Are you using a tool to determine this?

Dec 24 2018, 1:29 PM · Konsole

Dec 23 2018

patrickelectric added reviewers for D17761: mainwindow: Remove unused QSerialPort: rizzitello, tcanabrava.
Dec 23 2018, 1:52 PM
patrickelectric requested review of D17761: mainwindow: Remove unused QSerialPort.
Dec 23 2018, 1:52 PM
patrickelectric added reviewers for D17759: Correct includes: tcanabrava, hindenburg.
Dec 23 2018, 1:46 PM · Konsole
patrickelectric requested review of D17759: Correct includes.
Dec 23 2018, 1:45 PM · Konsole

Dec 22 2018

patrickelectric added a comment to D17588: MainWindow: Add Frameless option.

@hindenburg can you take a look ?

Dec 22 2018, 2:20 PM · Konsole

Dec 18 2018

patrickelectric added a reviewer for D17513: drkonqi: Add blueprint: vonreth.
Dec 18 2018, 11:53 AM

Dec 17 2018

patrickelectric accepted D17106: Atelier Clazy-tidy.
Dec 17 2018, 1:30 PM · Atelier

Dec 16 2018

patrickelectric added a comment to D17588: MainWindow: Add Frameless option.

@hindenburg @tcanabrava this PR is ready to review.
There is a problem with visibility if the windows is in a "opening state" when it's starting.


This only happens if I call show() or setVisibility(true) when the application is not visible yet.
That's why we have oldVisibility variable in this PR.

Dec 16 2018, 9:56 PM · Konsole
patrickelectric updated the diff for D17588: MainWindow: Add Frameless option.

Try to make Tomaz happy

Dec 16 2018, 9:42 PM · Konsole