Differential D8680

Generate DMG with travis as well
ClosedPublic
Actions

Authored by rizzitello on Nov 6 2017, 2:13 PM.

Details

Reviewers
laysrodrigues
patrickelectric
tcanabrava
Commits
R232:308d50d588d4: Generate DMG with travis as well
R232:f7f07e939c1b: Generate DMG with travis as well
Summary

Use travis to generate a dmg file

Test Plan

Running on travis via my github fork
https://travis-ci.org/sithlord48/atcore/builds/301520119

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello created this revision.Nov 6 2017, 2:13 PM
patrickelectric requested changes to this revision.Nov 6 2017, 2:35 PM
patrickelectric added inline comments.
.travis.yml
18–43

Use only one if to do the job.

34

Only one if here to.

This revision now requires changes to proceed.Nov 6 2017, 2:35 PM
rizzitello updated this revision to Diff 21970.Nov 6 2017, 3:34 PM
  • Less if
rizzitello marked 2 inline comments as done.Nov 6 2017, 3:34 PM
rizzitello updated this revision to Diff 21974.Nov 6 2017, 3:41 PM
  • fix typo
rizzitello updated this revision to Diff 21979.Nov 6 2017, 4:00 PM
  • fix = != ==
rizzitello updated this revision to Diff 21982.Nov 6 2017, 4:56 PM
  • remove == for = make sure space after all then
rizzitello updated this revision to Diff 21984.Nov 6 2017, 5:40 PM
  • remove full path from macdeployqt
patrickelectric requested changes to this revision.Nov 12 2017, 6:45 PM
patrickelectric added inline comments.
.travis.yml
23

Use apt, not apt-get.
apt update -qq

This revision now requires changes to proceed.Nov 12 2017, 6:45 PM
rizzitello added inline comments.Nov 13 2017, 12:37 PM
.travis.yml
20

remove extra -y at end

23

Is there any reason to prefer one over the other on trusty? Personally I use apt most of the time just because its less typing.

rizzitello updated this revision to Diff 22279.Nov 13 2017, 5:29 PM
  • Use apt instead of apt-get
  • Remove unNeeded -y
rizzitello marked 2 inline comments as done.Nov 13 2017, 5:29 PM
rizzitello edited the test plan for this revision. (Show Details)Nov 13 2017, 5:33 PM
tcanabrava accepted this revision.Nov 13 2017, 5:46 PM

seems good enougth to merge.
we can fix anythign later.

patrickelectric requested changes to this revision.Nov 13 2017, 6:13 PM

Maybe we can add a message output to a bot or something like.

.travis.yml
33

you don't need this ; in the end.

43

Check the indentation.

This revision now requires changes to proceed.Nov 13 2017, 6:13 PM
rizzitello added inline comments.Nov 13 2017, 6:20 PM
.travis.yml
33

With a working AppImage is being created
https://github.com/sithlord48/atcore/releases/tag/continuous

43

Its good see the mac build for this travis file
https://github.com/sithlord48/atcore/releases/tag/continuous

rizzitello added inline comments.Nov 14 2017, 12:34 PM
.travis.yml
33

Tested removal ,fails if ; is removed
https://travis-ci.org/sithlord48/atcore/jobs/301916396

rizzitello updated this revision to Diff 22414.Nov 15 2017, 8:46 PM
rizzitello marked an inline comment as done.
  • Adjust indents for if blocks
rizzitello marked an inline comment as done.Nov 15 2017, 8:47 PM
patrickelectric accepted this revision.Nov 26 2017, 7:48 PM
This revision is now accepted and ready to land.Nov 26 2017, 7:48 PM
Closed by commit R232:f7f07e939c1b: Generate DMG with travis as well (authored by rizzitello). · Explain WhyNov 27 2017, 1:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
M.travis.yml (109 lines)

Diff 22981

View Options

.travis.yml

Loading...