These seam to do nothing but make atcore crash if the print thread changes the Temp.
Tested Controls Work fine.

Same as the other one

This shouldn't be the same as the one below?

doing the post pause before making the state paused helps keep our states more consistant and provides safer base for injections.

These commands are ment to call atcore functions not just strictly single gcodes. For instance there is no way to pause a job via a gcode (unless its on an sd card)

These calls are no needed . so i didn't bother to look in to why it crashed. I did check to be sure that the temps are being set correctly .

Qstring.simplify

Why remove ?

We should support gcode in cases that the function is gcode available

All comments in gcode start with ; so those need to be handled and that case will be much more common. many slicers like have post command comments

G28 ; Send home command

No because we do not want to change the sent command as its used in elsewhere as a full line

injected commands will be injected while the print job is paused.

This is the function to decode all the functions.. they are documented in the code for this function.

Documented in the header for this function.

Force new lines :D

Every line that contains ; needs to be resized to remove comments many slicerswill do things like G28 ; home all so it make the contains if get hit alot more so i put it first then the other inside as it makes it more readable and the most common case is first..

The other way would be.

if (d->cline.startsWith(QStringLiteral(";-"))) {
    injectCommand(d-cline);
}

if (d->cline.contains(QChar::fromLatin1(';'))) {
    d->cline.resize(d->cline.indexOf(QChar::fromLatin1(';')));
}

Because it has been designed in such a way.

If we are reading a gcode file (i.e printing) if we hit a line that starts with ;- we read it and send it to injectCommand this will push the command out to the printer. I have added in our pause state a check for ;- and if seen it will call nextLine() and send the injectedCommand to the printer. The print job is paused but the injectedCommands are still pushed. this lets you move the head out of the way and then do heat so you can change the filiment without resuming first or sending heat before pause. This also give the user more freedom to put the injected commands before or after an injected pause. Due to how this is made there is no much of a chance of the user triggering this by accident. Pressing pause on the gui will pause the job the only thing that changes is if they press pause on a line starting with ;- that will be send to the buffer while paused...

This line will not occur, because of:

if (d->cline.contains(QChar::fromLatin1(';'))) {
    if (d->cline.startsWith(QStringLiteral(";-"))) {
        injectCommand(d->cline);
    }
    d->cline.resize(d->cline.indexOf(QChar::fromLatin1(';')));
}
d->cline = d->cline.simplified();

The resize will happen after the injectCommand, the result will be a empty line. Please, correct me if I'm wrong.

this only ensures that if we are paused (not busy then changed to pause by injected command thats all the ther check is for) we still can process ;- lines.