Feed Advanced Search

Feb 11 2020

davidedmundson accepted D27031: Return early if we ignore resize increments and aspect ratio constraints.
Feb 11 2020, 11:13 AM · KWin
davidedmundson accepted D26908: [effects/desktopgrid] Use windowFrameGeometryChanged.
Feb 11 2020, 11:11 AM · KWin
davidedmundson accepted D26907: [effects/presentwindows] Use windowFrameGeometryChanged.
Feb 11 2020, 11:10 AM · KWin
davidedmundson accepted D26906: [effects/thumbnailaside] Use windowFrameGeometryChanged.
Feb 11 2020, 11:10 AM · KWin
davidedmundson accepted D26865: [effects/morphingpopups] Start animation on windowFrameGeometryChanged.
Feb 11 2020, 10:49 AM · KWin
davidedmundson accepted D27167: Put the resize effect in charge of scheduling repaints.

Yeah, I can't see why this exists.

Feb 11 2020, 10:37 AM · KWin
davidedmundson closed T6582: Investigate if qApp->globalStrut is useful as Resolved.

Investigation done: It's not

Feb 11 2020, 10:27 AM · Plasma: Convergence
davidedmundson accepted D27261: [Folder view] Fix binding loop on width.

It's technically different to before. The old code had half a small margin each side.

Feb 11 2020, 8:01 AM · Plasma

Feb 10 2020

davidedmundson committed R119:0d17a4b4e07c: [kcms/cursortheme] Don't skip everything because of lack of XFixes (authored by davidedmundson).
[kcms/cursortheme] Don't skip everything because of lack of XFixes
Feb 10 2020, 6:46 PM
davidedmundson closed D27055: [kcms/cursortheme] Don't skip everything because of lack of XFixes.
Feb 10 2020, 6:46 PM · Plasma
davidedmundson committed R283:4d241b3f4f54: Drop Policykit backend (authored by davidedmundson).
Drop Policykit backend
Feb 10 2020, 6:44 PM
davidedmundson closed D27141: Drop Policykit backend.
Feb 10 2020, 6:44 PM · Frameworks
davidedmundson created P541 (An Untitled Masterwork) in the S1 KDE Community space.
Feb 10 2020, 3:14 PM
davidedmundson committed R283:3a7a57c33453: [polkit-1] Simplify Polkit1Backend action exists lookup (authored by davidedmundson).
[polkit-1] Simplify Polkit1Backend action exists lookup
Feb 10 2020, 2:06 PM
davidedmundson committed R283:d80fdb8966a0: [polkit-1] Return an error status in actionStatus if there is an error (authored by davidedmundson).
[polkit-1] Return an error status in actionStatus if there is an error
Feb 10 2020, 2:06 PM
davidedmundson closed D27284: [polkit-1] Simplify Polkit1Backend action exists lookup.
Feb 10 2020, 2:06 PM · Frameworks
davidedmundson closed D27283: [polkit-1] Return an error status in actionStatus if there is an error.
Feb 10 2020, 2:06 PM · Frameworks
davidedmundson added a dependent revision for D27283: [polkit-1] Return an error status in actionStatus if there is an error: D27284: [polkit-1] Simplify Polkit1Backend action exists lookup.
Feb 10 2020, 12:29 PM · Frameworks
davidedmundson added a dependency for D27284: [polkit-1] Simplify Polkit1Backend action exists lookup: D27283: [polkit-1] Return an error status in actionStatus if there is an error.
Feb 10 2020, 12:29 PM · Frameworks
davidedmundson requested review of D27284: [polkit-1] Simplify Polkit1Backend action exists lookup.
Feb 10 2020, 12:21 PM · Frameworks
davidedmundson requested review of D27283: [polkit-1] Return an error status in actionStatus if there is an error.
Feb 10 2020, 12:19 PM · Frameworks
davidedmundson committed R124:a1d44475d4be: Handle spawning kinfocenter with a full path (authored by davidedmundson).
Handle spawning kinfocenter with a full path
Feb 10 2020, 11:35 AM
davidedmundson closed D27137: Handle spawning kinfocenter with a full path.
Feb 10 2020, 11:35 AM · Plasma
davidedmundson accepted D27279: Port away from QWidget.
Feb 10 2020, 11:09 AM · Frameworks
davidedmundson added a comment to D27137: Handle spawning kinfocenter with a full path.

I'm going to ship this as it fixes an easy to hit bug that is definitely wrong.
I'm not trying to ingore any other proposals, we can always expand and change.

Feb 10 2020, 11:04 AM · Plasma
davidedmundson accepted D27280: ScrollView: Use scrollbar height as bottom padding, not width.
Feb 10 2020, 10:49 AM · Plasma
davidedmundson added inline comments to D27279: Port away from QWidget.
Feb 10 2020, 10:41 AM · Frameworks
davidedmundson requested changes to D27276: Powerdevil: allow using qt5widget classes with powerdevil.

Lets fix KIdleTime instead.

Feb 10 2020, 10:10 AM · Plasma
davidedmundson added a comment to T12627: Create a generator for all remaining .desktop files and user scripts.

A FOSDEM meeting said we would try and create a common generator which will ship with systemd

Feb 10 2020, 9:49 AM · Plasma
davidedmundson closed T12623: Resolve kcminit as Resolved.

Done

Feb 10 2020, 9:45 AM · Plasma
davidedmundson closed T12623: Resolve kcminit, a subtask of T11914: Merge plasma-systemd-integration, as Resolved.
Feb 10 2020, 9:45 AM · Plasma
davidedmundson created T12678: Scope applications into transient services .
Feb 10 2020, 9:44 AM · Plasma
davidedmundson committed R120:77f418500e56: Syncronise environment to user systemd session (authored by davidedmundson).
Syncronise environment to user systemd session
Feb 10 2020, 9:19 AM
davidedmundson closed D27054: Syncronise environment to user systemd session.
Feb 10 2020, 9:19 AM · Plasma

Feb 9 2020

davidedmundson requested review of D27266: [libtaskmanager] Fix shared VirtualDesktopInfo::Private tied to the 1st creator.
Feb 9 2020, 3:21 PM · Plasma
davidedmundson added a comment to D27260: [applets/systemtray] Set pin button's size correctly.

workspace changes required as a result of a frameworks change raises questions

Feb 9 2020, 2:13 PM · Plasma
davidedmundson accepted D27264: Fix tabbar width computation.
Feb 9 2020, 12:37 PM · Kirigami
davidedmundson added a comment to D27262: Reduce blank space inside tooltip's header.

Code wise, no objections. Needs vdg to approve visual changes.

Feb 9 2020, 10:53 AM · Plasma

Feb 8 2020

davidedmundson added a comment to D27219: Center placeholder texts in system tray popups.

From a code pov. +1

Feb 8 2020, 9:02 PM · Plasma
davidedmundson requested changes to D26036: Remove orientation sensor.

Marking as needs changes RE: vlad's comment

Feb 8 2020, 5:10 PM · KWin
davidedmundson added a dependent revision for D25907: [platforms/drm] Introduce Gl post-process output rotations: D26371: [platforms/drm] Rewrite rotation rendering to use MapTexture.
Feb 8 2020, 5:09 PM · KWin
davidedmundson added a dependency for D26371: [platforms/drm] Rewrite rotation rendering to use MapTexture: D25907: [platforms/drm] Introduce Gl post-process output rotations.
Feb 8 2020, 5:09 PM · KWin
davidedmundson accepted D25907: [platforms/drm] Introduce Gl post-process output rotations.
Feb 8 2020, 5:08 PM · KWin
davidedmundson accepted D27061: replace samba module with data that works.

I'm happy with the model.

Feb 8 2020, 5:06 PM · Plasma
davidedmundson added inline comments to D27219: Center placeholder texts in system tray popups.
Feb 8 2020, 2:54 PM · Plasma
davidedmundson accepted D27237: [Background Finder] Create a valid invocation token.
Feb 8 2020, 2:49 PM · Plasma
davidedmundson accepted D27241: sddm-theme: Use non-deprecated KDEInstallDirs variable.
Feb 8 2020, 2:48 PM · Plasma
davidedmundson accepted D27185: Use the right translation catalog to show translations.

Urgh, we should have spotted that at review. Ship it!

Feb 8 2020, 8:21 AM · Frameworks
davidedmundson added a comment to D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them.

This would also be loaded and operational when running in a gnome session. It's important we don't cause issues there.

Feb 8 2020, 3:44 AM · Plasma

Feb 7 2020

davidedmundson added inline comments to D27061: replace samba module with data that works.
Feb 7 2020, 2:11 PM · Plasma

Feb 6 2020

davidedmundson added a comment to D27194: Remove human avatars.

From a technical POV, pics get copied when selected, so you can do whatever without any user breakage.

Feb 6 2020, 3:04 PM · Plasma
davidedmundson accepted D27174: actually draw drag icons in the mouse cursor during drags.
Feb 6 2020, 12:41 PM · KWin
davidedmundson committed R127:f8760c97b65e: [surface] Fix buffer offset when attaching buffers to surfaces (authored by davidedmundson).
[surface] Fix buffer offset when attaching buffers to surfaces
Feb 6 2020, 11:28 AM
davidedmundson closed D27190: [surface] Fix buffer offset when attaching buffers to surfaces.
Feb 6 2020, 11:28 AM · Frameworks
davidedmundson requested review of D27190: [surface] Fix buffer offset when attaching buffers to surfaces.
Feb 6 2020, 11:21 AM · Frameworks
davidedmundson updated the title for P540 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Feb 6 2020, 11:04 AM
davidedmundson committed R275:fceba045417e: Revert early return on setFilterRole (authored by davidedmundson).
Revert early return on setFilterRole
Feb 6 2020, 10:37 AM
davidedmundson committed R275:4fd7a211bb8d: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin (authored by ahiemstra).
Move Plasma's SortFilterProxyModel into KItemModel's QML plugin
Feb 6 2020, 9:34 AM
davidedmundson closed D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin.
Feb 6 2020, 9:34 AM · Frameworks
davidedmundson accepted D27172: Make the virtual keyboard disappear when locking the screen.
Feb 6 2020, 8:35 AM · KWin
davidedmundson added a comment to D27142: Have authhelper define config file paths on its own.

Yes

Feb 6 2020, 1:42 AM · Plasma

Feb 5 2020

davidedmundson added inline comments to D27174: actually draw drag icons in the mouse cursor during drags.
Feb 5 2020, 8:15 PM · KWin
davidedmundson added inline comments to D27172: Make the virtual keyboard disappear when locking the screen.
Feb 5 2020, 8:10 PM · KWin
davidedmundson accepted D27168: [libkwineffects] Detect AMD Navi GPUs.

Cool, as long as there's some original source I'm happy

Feb 5 2020, 7:51 PM · KWin
davidedmundson added a comment to D27174: actually draw drag icons in the mouse cursor during drags.

which doesn't seem to have a wayland protocol correspondence

Feb 5 2020, 7:47 PM · KWin
davidedmundson added inline comments to D27168: [libkwineffects] Detect AMD Navi GPUs.
Feb 5 2020, 3:57 PM · KWin
davidedmundson added inline comments to D27160: [applets/mediacontroller] Visually refresh media controller plasmoid.
Feb 5 2020, 4:52 AM · Plasma

Feb 4 2020

davidedmundson added inline comments to D26813: Have user-manager write to SDDM's new config file.
Feb 4 2020, 6:44 PM · Plasma
davidedmundson accepted D27142: Have authhelper define config file paths on its own.
Feb 4 2020, 6:42 PM · Plasma
davidedmundson updated the title for P539 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Feb 4 2020, 5:58 PM
davidedmundson added a comment to D27142: Have authhelper define config file paths on its own.

oh, then kill it

Feb 4 2020, 5:54 PM · Plasma
davidedmundson added a comment to D27142: Have authhelper define config file paths on its own.

I dunno, what is it?

Feb 4 2020, 5:41 PM · Plasma
davidedmundson added a comment to D27137: Handle spawning kinfocenter with a full path.

Hello symlink my old friend...

Feb 4 2020, 5:24 PM · Plasma
davidedmundson accepted D27154: KCM/solid-actions convert foreach.
Feb 4 2020, 1:54 PM · Plasma
davidedmundson accepted D26785: cleanup devinfo header includes.
Feb 4 2020, 1:14 PM · Plasma
davidedmundson added inline comments to D26859: Implement the tablet wayland protocol in kwin.
Feb 4 2020, 11:02 AM · KWin
davidedmundson added a comment to D26858: Provide an implementation for the tablet interface.

Feedback from some testing:

  • we're adding the same tool a bunch of times when a new client is created
  • sometimes we fail to enter the surface leaving the cursor "stuck" (with gtk3-demo)
Feb 4 2020, 10:47 AM · Frameworks
davidedmundson accepted D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.
Feb 4 2020, 10:39 AM · Frameworks
davidedmundson accepted D27071: Remove KCM Init Phase 2.
Feb 4 2020, 9:34 AM · Plasma

Feb 3 2020

davidedmundson committed R283:afbfd5d436b1: Calculate KAuthAction::isValid on demand (authored by davidedmundson).
Calculate KAuthAction::isValid on demand
Feb 3 2020, 10:51 PM
davidedmundson closed D27140: Calculate KAuthAction::isValid on demand.
Feb 3 2020, 10:51 PM · Frameworks
davidedmundson committed R283:5fc7551632ca: Be more helpfully verbose when we can't start an action (authored by davidedmundson).
Be more helpfully verbose when we can't start an action
Feb 3 2020, 10:51 PM
davidedmundson closed D26961: Be more helpfully verbose when we can't start an action.
Feb 3 2020, 10:51 PM · Frameworks
davidedmundson added inline comments to D27142: Have authhelper define config file paths on its own.
Feb 3 2020, 9:05 PM · Plasma
davidedmundson requested review of D27141: Drop Policykit backend.
Feb 3 2020, 7:55 PM · Frameworks
davidedmundson added a comment to D27037: [Notifications] Fixup setSourceModel.

QAbstractSortFilterProxyModel has docs that say you need it, but QSortFilterProxyModel which you inherit from does reset the model in setSourceModel.

Feb 3 2020, 7:49 PM · Plasma
davidedmundson requested review of D27140: Calculate KAuthAction::isValid on demand.
Feb 3 2020, 7:29 PM · Frameworks
davidedmundson created T12643: KAuth: Remove nested event loop in Polkit1Backend::actionExists().
Feb 3 2020, 7:23 PM · KF6
davidedmundson added a comment to D27137: Handle spawning kinfocenter with a full path.

If you run /usr/bin/my-kinfocenter you wouldn't spawn this executable in the first place

Feb 3 2020, 6:16 PM · Plasma
davidedmundson requested review of D27137: Handle spawning kinfocenter with a full path.
Feb 3 2020, 5:44 PM · Plasma
davidedmundson accepted D27126: [SNI] Fix race condition in item registration.
Feb 3 2020, 3:53 PM · Plasma
davidedmundson added a comment to D27082: [Tests]Make radiobutton3.qml use PC3.

I can't do that, someone else need to commit it.

Feb 3 2020, 3:08 PM · Frameworks, Plasma
davidedmundson added a comment to D27126: [SNI] Fix race condition in item registration.

Well identified, it is racey.

Feb 3 2020, 1:46 PM · Plasma
davidedmundson accepted D27125: Rename popupPosition to popupRect.
Feb 3 2020, 12:52 PM · KWin
davidedmundson accepted D27124: Use Q_ASSERT in XdgShellClient::transientPlacement().
Feb 3 2020, 12:34 PM · KWin
davidedmundson added a comment to D26914: [x11] Fix visual artifacts during interactive resize.

The detailed description makes sense and VDG people say it's better..

Feb 3 2020, 11:35 AM · KWin
davidedmundson resigned from D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground.

Change is now purely visual, so VDG can have say on the details.

Feb 3 2020, 11:25 AM · VDG, Plasma, Frameworks
davidedmundson accepted D27114: ScreenEdge: Do not use localtime for measuring duration.
Feb 3 2020, 11:18 AM · KWin
davidedmundson requested changes to D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground.
Feb 3 2020, 11:07 AM · VDG, Plasma, Frameworks
davidedmundson accepted D27060: Introduce coding-conventions.md.

You know my thoughts on per project rules.
But maybe it is different for kwin. Use of setRight() is the easier call than left+width() if you are actually using it for painting and need to think about the 1px the other way round.

Feb 3 2020, 10:04 AM · KWin