Correct test radiobutton3.qml to use Plasma Components 3 instead of 2.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R242:dccf6c4dd629: [Tests]Make radiobutton3.qml use PC3
Run qmlscene radiobutton3.qml
Before:
Misaligned button and big height. (bug in PC2 radiobutton)
After:
Correct height and alignment between button and button's text.
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Because PC3 label is shorter that PC3 checkbox, there is a misalignment than need fixing. Either need to change label to have a height similar to PC2 (1.6*fontHeight). Or need to change this test's text vertical alignment.
Comment Actions
I'm not really the best person to review this, but it seems to work. The test still has poor horizontal alignment and the button doesn't have the correct size.
Comment Actions
Well, it has the correct size in that it's 16x16, but it's like it was stretched and cropped.
Comment Actions
Don't make me redraw PC3 tests too. The basis of the issue is the same, different Label than Button height. For PC3 label is shorter than buttons.
PC2 tests
This shows the problem.
Don't know what is the correct approach:
1 Label needs to be shorter.
2 Give correct height in checkbox, and center the buttons.
3 Override label height in radiobutton, to make everything slim. Will need to center when used.
Either need to increase label height to button height, or need to center label in the test (and everywhere else it is used.)
Others would say "The position of the left side is off by half a pixel".
The cause of it and solution, as I interpret them is D27083.
I made these 2 patches based on your feedback, and thought it would be a good idea to see them. There, fixed it :)
Comment Actions
Regardless of issues, the change for the test is correct.
We should break the test to highlight issues. Ship it!
Comment Actions
I can't do that, someone else need to commit it.
Then lets fix that.
You can apply for a developer account (there should be a button on identity.kde.org) and tag me and Nate as approvers.
Comment Actions
Additional documentation is at https://community.kde.org/Infrastructure/Get_a_Developer_Account
Definitely apply! You've earned it.
Comment Actions
I 'll ask you to keep committing my patches a little longer.
At least for my current patches, and their related bugfixes.