Differential D27055

[kcms/cursortheme] Don't skip everything because of lack of XFixes
ClosedPublic
Actions

Authored by davidedmundson on Jan 31 2020, 10:16 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R119:0d17a4b4e07c: [kcms/cursortheme] Don't skip everything because of lack of XFixes
Summary

XFixes is only used on X.
But we definitely still need to update the available entries in the size
combo box.
We still want to emit changes, and we still want to update the env

Test Plan

Ran on wayland

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 31 2020, 10:16 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 31 2020, 10:16 AM
broulik accepted this revision.Jan 31 2020, 10:42 AM
broulik added a subscriber: broulik.
broulik added inline comments.
kcms/cursortheme/kcmcursortheme.cpp
303–323

Move this above QStringList names;

This revision is now accepted and ready to land.Jan 31 2020, 10:42 AM
Closed by commit R119:0d17a4b4e07c: [kcms/cursortheme] Don't skip everything because of lack of XFixes (authored by davidedmundson). · Explain WhyFeb 10 2020, 6:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/cursortheme/kcmcursortheme.cpp (44 lines)

Diff 75401

View Options

kcms/cursortheme/kcmcursortheme.cpp

Loading...