So the PC3 ToolButton change just went in anyway via D27396. So we now need to fix this somehow or else it'll be mega broken looking. If we fix it by landing this patch on master, here's how it will look for people who get the frameworks change but have to wait 4 months until the next major Plasma version:
If we land this on the stable branch, here's how it will look for people who get the Plasma change but never get the Frameworks change:
FWIW, Plasma 5.17 uses PC2, so I have no real objections to this patch in the context of this patch. I'm only questioning if that frameworks change is safe, given if it is causing changes elsewhere
I mean... yeah. :/ It's kind of a lousy situation since the Frameworks change fixed a bug, but regressed this code since we were doing it wrong here in a way that isn't compatible with the correct implementation.