This fixes the binding loop and replaces a complicated bit of code with something much
simpler.
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R119:6b1cc98f0959: [Folder view] Fix binding loop on width
No more binding loop warning when running plasmashell on the CLI
No meaningful difference in appearance for every combination of icon size and label
width in icon view
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Also adds smallSpacing at the top. It would not look right with Plasma Components Label, which already has empty space top and bottom (paintedHeight*1.6). PC3 on the other hand has none... Correction, is set below "height: undefined". Tested and looks fine, height didn't change.
It's technically different to before. The old code had half a small margin each side.
Generally speaking bug fixes shouldn't change things, as then you're mixing different types of task.
Use identical margins; don't change the visuals at all (should be done in another patch if necessary)
I logged with my main account and I get lots of
file:///code/kde/usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderItemDelegate.qml:306:17: QML Label: Binding loop detected for property "width"