Feed Advanced Search

Jan 31 2019

davidedmundson accepted D18635: Drop ShellClient::shellSurface method.
Jan 31 2019, 11:29 PM · KWin
davidedmundson abandoned D18633: [kcmkwin/kwindecoration] Draw decoration buttons over the decoration palette.

I'm an idiot.

Jan 31 2019, 8:13 PM · KWin
davidedmundson planned changes to D18633: [kcmkwin/kwindecoration] Draw decoration buttons over the decoration palette.

Yes - Though whilst making screenshots I think I discovered something. I think I may have been premature in deciding what the exact problem was. I need to investigate, sorry for the noise.

Jan 31 2019, 7:39 PM · KWin
davidedmundson added a watcher for Bugsquad: davidedmundson.
Jan 31 2019, 7:33 PM
davidedmundson updated the diff for D18633: [kcmkwin/kwindecoration] Draw decoration buttons over the decoration palette.

another sneaky fixup

Jan 31 2019, 6:05 PM · KWin
davidedmundson updated the diff for D18633: [kcmkwin/kwindecoration] Draw decoration buttons over the decoration palette.

update

Jan 31 2019, 6:02 PM · KWin
davidedmundson requested review of D18633: [kcmkwin/kwindecoration] Draw decoration buttons over the decoration palette.
Jan 31 2019, 5:58 PM · KWin
davidedmundson added a comment to D18621: Add again a button to manually scan for wireless networks.

It's in 1.12.

Jan 31 2019, 3:59 PM · Plasma
davidedmundson accepted D18628: [server] Generate correct touch ids.
Jan 31 2019, 3:33 PM · Frameworks
davidedmundson added a comment to D18621: Add again a button to manually scan for wireless networks.

I can find LastScan in the fd.o apidox, but not in NMQt... ?!?

Jan 31 2019, 2:54 PM · Plasma
davidedmundson accepted D18626: [plasmoidviewer] Pick up KQuickAddons::QtQuickSettings.
Jan 31 2019, 1:37 PM · Plasma
davidedmundson accepted D18625: [plasmawindowed] Pick up KQuickAddons::QtQuickSettings.
Jan 31 2019, 1:36 PM · Plasma

Jan 30 2019

davidedmundson updated the diff for D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

Implicit size

Jan 30 2019, 5:55 PM · KWin
davidedmundson added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

TabBar still needs some work, but on the QQC-desktop-theme side.

Jan 30 2019, 5:54 PM · KWin
davidedmundson updated the diff for D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

Sync margins

Jan 30 2019, 5:43 PM · KWin
davidedmundson added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

I just commandeered to push the layout change, feel free to take it back.

Jan 30 2019, 5:37 PM · KWin
davidedmundson updated the diff for D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

Update main page layout.

Jan 30 2019, 5:37 PM · KWin
davidedmundson commandeered D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
Jan 30 2019, 5:35 PM · KWin
davidedmundson accepted D18616: [kcmkwin/rules] Fix line separators in the dialog.
Jan 30 2019, 1:53 PM · KWin
davidedmundson accepted D18497: Disable KCMs while downloading file.
Jan 30 2019, 1:08 PM · Plasma
davidedmundson requested review of D18615: Fix mime type filter on background selection button.
Jan 30 2019, 11:46 AM · Plasma
davidedmundson requested review of D18614: Fix loading of background image preview.
Jan 30 2019, 11:19 AM · Plasma
davidedmundson accepted D18598: Defer initial positions apply until listing is complete.
Jan 30 2019, 2:02 AM · Plasma
davidedmundson committed R858:152bb7363a80: Fix combobox initial sizing (authored by davidedmundson).
Fix combobox initial sizing
Jan 30 2019, 1:56 AM
davidedmundson closed D18597: Fix combobox initial sizing.
Jan 30 2019, 1:56 AM · Plasma
davidedmundson added a comment to T8075: Fix security issues with KAuth support in KIO.
  1. Improve message in polkit prompt (issue no. 2). BTW how do I fix this?
Jan 30 2019, 1:20 AM · Frameworks
davidedmundson closed D18594: [wayland] Drop Qt extended surface.
Jan 30 2019, 1:00 AM · KWin
davidedmundson committed R108:7d10ab0fe7a1: [wayland] Drop Qt extended surface (authored by davidedmundson).
[wayland] Drop Qt extended surface
Jan 30 2019, 1:00 AM
davidedmundson committed R108:4240c4af054f: [wayland] Call ShellClient install interface methods consistently (authored by davidedmundson).
[wayland] Call ShellClient install interface methods consistently
Jan 30 2019, 1:00 AM
davidedmundson closed D18592: [wayland] Call ShellClient install interface methods consistently.
Jan 30 2019, 1:00 AM · KWin

Jan 29 2019

davidedmundson added inline comments to D18607: Add a popup search bar to the plasma-nm applet.
Jan 29 2019, 10:09 PM · Plasma
davidedmundson added a comment to D18607: Add a popup search bar to the plasma-nm applet.

Seems niche, but this solution is also unobtrusive, so I like that. I have a lot of VPNs searching through them would be quite useful.

Jan 29 2019, 10:04 PM · Plasma
davidedmundson added a comment to D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs.

If you open the file, the mask is the black rectangle on the right.

Jan 29 2019, 6:27 PM · Frameworks
davidedmundson added a comment to D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs.

"Background Contrast" darkens the background of all the UI elements by adding rectangles (instead of just darkening their backgrounds).

Jan 29 2019, 6:23 PM · Frameworks
davidedmundson added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

Can you give me a summary of whatever's left that I need to help investigate?

Jan 29 2019, 5:57 PM · KWin
davidedmundson added a comment to D18598: Defer initial positions apply until listing is complete.

If the QML code calls setPositions({}) and when we apply m_positions.size() < 5
m_deferApplyPositions gets left on true forever. Is that ok?

Jan 29 2019, 5:41 PM · Plasma
davidedmundson closed D18596: Set combobox popups to be modal.
Jan 29 2019, 4:42 PM · Plasma
davidedmundson committed R858:0ac99af6e691: Set combobox popups to be modal (authored by davidedmundson).
Set combobox popups to be modal
Jan 29 2019, 4:42 PM
davidedmundson added a comment to D18307: Call frameRendered for undamaged Wayland surfaces.

I believe someone would need to commit on my behalf.

Jan 29 2019, 4:34 PM · KWin
davidedmundson requested review of D18597: Fix combobox initial sizing.
Jan 29 2019, 4:29 PM · Plasma
davidedmundson requested review of D18596: Set combobox popups to be modal.
Jan 29 2019, 2:53 PM · Plasma
davidedmundson requested review of D18594: [wayland] Drop Qt extended surface.
Jan 29 2019, 1:11 PM · KWin
davidedmundson requested review of D18592: [wayland] Call ShellClient install interface methods consistently.
Jan 29 2019, 12:56 PM · KWin
davidedmundson committed R108:18dd0327c2e7: [autotests] Untangle ShellClient::testMaximizedToFullscreen (authored by davidedmundson).
[autotests] Untangle ShellClient::testMaximizedToFullscreen
Jan 29 2019, 12:35 PM
davidedmundson closed D18589: [autotests] Untangle ShellClient::testMaximizedToFullscreen.
Jan 29 2019, 12:35 PM · KWin
davidedmundson updated the diff for D18589: [autotests] Untangle ShellClient::testMaximizedToFullscreen.

sneakily update something

Jan 29 2019, 12:03 PM · KWin
davidedmundson requested review of D18589: [autotests] Untangle ShellClient::testMaximizedToFullscreen.
Jan 29 2019, 12:02 PM · KWin

Jan 28 2019

davidedmundson added a comment to D18583: Init ShellClient only when commited to the buffer.

I guess the reason why createShellSurface doesn't have CreationSetup parameter is because of wl_shell,

Jan 28 2019, 9:34 PM · KWin
davidedmundson updated the diff for D18583: Init ShellClient only when commited to the buffer.

tidy unused

Jan 28 2019, 9:07 PM · KWin
davidedmundson updated the diff for D18583: Init ShellClient only when commited to the buffer.

Merge patch from zzag fixing the expected configure count in testQuickTilingPointerMove

Jan 28 2019, 8:54 PM · KWin
davidedmundson updated the diff for D18583: Init ShellClient only when commited to the buffer.

new connect syntax

Jan 28 2019, 7:56 PM · KWin
davidedmundson updated the diff for D18583: Init ShellClient only when commited to the buffer.

Add hooks for unit tests to easily block for configure events from the compositor
before attaching buffers

Jan 28 2019, 7:22 PM · KWin
davidedmundson added a comment to D18078: [plasma-workspace-wallpapers] Improve wallpaper selection.

Can we keep this discussion of licenses on "Licensing policy change proposal" on the KDE community thread so info is not split.

Jan 28 2019, 3:08 PM · Plasma
davidedmundson requested review of D18583: Init ShellClient only when commited to the buffer.
Jan 28 2019, 2:59 PM · KWin
davidedmundson requested review of D18582: Add explicit SurfaceInterface::commited signal.
Jan 28 2019, 2:44 PM · Frameworks
davidedmundson updated the title for P293 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Jan 28 2019, 2:15 PM
davidedmundson committed R127:818e0d1fcb65: Make XdgTest spec compliant (authored by davidedmundson).
Make XdgTest spec compliant
Jan 28 2019, 12:11 PM
davidedmundson closed D18577: Make XdgTest spec compliant.
Jan 28 2019, 12:11 PM · Frameworks
davidedmundson updated the diff for D18577: Make XdgTest spec compliant.

update

Jan 28 2019, 11:22 AM · Frameworks
davidedmundson requested review of D18577: Make XdgTest spec compliant.
Jan 28 2019, 10:56 AM · Frameworks
davidedmundson committed R124:6c40ed4c42ab: warnings-- (authored by davidedmundson).
warnings--
Jan 28 2019, 9:46 AM
davidedmundson closed D18489: warnings--.
Jan 28 2019, 9:46 AM · Plasma
davidedmundson committed R120:98d9f681a37e: [wallpapers/image] Don't use PlasmaCore in desktop themed UI (authored by davidedmundson).
[wallpapers/image] Don't use PlasmaCore in desktop themed UI
Jan 28 2019, 9:16 AM
davidedmundson closed D18347: [wallpapers/image] Don't use PlasmaCore in desktop themed UI.
Jan 28 2019, 9:16 AM · Plasma
davidedmundson added a comment to D18571: Add "apply on double-click" feature to most other recent ported KCMs.

We should definitely be consistent. So either this or removing it from colours.

Jan 28 2019, 9:09 AM · Plasma
davidedmundson added a comment to D18572: [Image wallpaper] Use units from Kirigami rather than PlasmaCore.

Isn't this https://phabricator.kde.org/D18347?

Jan 28 2019, 9:00 AM · Plasma
davidedmundson added a comment to D17983: StatusItemNotifier: fix overlays by name with icons by name.

Thanks -- which branch should I push this to?

Jan 28 2019, 8:58 AM · Plasma

Jan 27 2019

davidedmundson committed R858:e061611e0fc7: Tab bar test (authored by davidedmundson).
Tab bar test
Jan 27 2019, 6:59 PM
davidedmundson accepted D18559: Use correct sidebar back button press color.
Jan 27 2019, 10:12 AM · Plasma
davidedmundson accepted D18560: Fix reorder warning in AbstractScript.
Jan 27 2019, 10:10 AM · KWin

Jan 26 2019

davidedmundson added a comment to T10397: Qt 5.12 for plasma master.

That was fast. Thanks guys

Jan 26 2019, 11:12 PM · build.kde.org
davidedmundson added a comment to T10402: Find a way to remove the Desktop Toolbox in its current form (i.e. a hamburger menu button in the corner of the screen).

Offers an emergency UI for editing widgets and logging out/shutting down in the case that the user has deleted all their panels and any of the application launchers/menus, and doesn't know how to right-click or doesn't have an input device that allows them to

Jan 26 2019, 6:35 PM · Plasma, VDG
davidedmundson committed R110:974dabc25f0b: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Jan 26 2019, 5:58 PM
davidedmundson committed R110:08d494c401cb: Guard failing to load backend (authored by davidedmundson).
Guard failing to load backend
Jan 26 2019, 5:58 PM
davidedmundson closed D18508: Somewhat guard failing to load backend.
Jan 26 2019, 5:58 PM · Plasma
davidedmundson added a comment to D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs.

Dialog is used in way more places that "mostly notifications"
It's used in applet popups, OSDs, WidgetExplorer, kwin tab switcher.

Jan 26 2019, 10:58 AM · Frameworks

Jan 25 2019

davidedmundson added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

I can not find a good way to avoid this issue, do you have time to help me a bit?

Jan 25 2019, 11:27 PM · KWin
davidedmundson added a comment to D18368: [effects] Port to new connect syntax.

If you have:

Jan 25 2019, 11:06 PM · KWin
davidedmundson accepted D18368: [effects] Port to new connect syntax.

Biggest issue I've seen with this connect porting is when people use slots as fake-virtuals.
Something to be wary of in the core, but in here it's all leaf classes.

Jan 25 2019, 10:42 PM · KWin
davidedmundson accepted D16914: [Runners KCM] Focus the search field by default.

Master only because of the frameworks bump, please

Jan 25 2019, 10:26 PM · Plasma
davidedmundson added a comment to D18419: Move KCMs in "Workspace Theme" to more appropriate locations.

Improve text on existing QWidgets KCMs to conform to the HIG

After this.

Re-arrange weird layouts for existing QWidgets KCMs to conform to the HIG

After this.

Port all QWidgets KCMs to QML

I don't especially care, though it's often the most effective way to do the previous step. It's an effort to compromise. If I had wanted to block this forever, I would be insisting on this.

Jan 25 2019, 10:17 PM · Plasma
davidedmundson added a comment to D18515: Bump to Qt5.12 - Drop kwin's custom ServerSideDecorationManager interface.

FWIW, I'm blocked on CI upgrading. I've filed a sysadmin ticket.

Jan 25 2019, 1:20 PM · Plasma
davidedmundson accepted D18521: [server] Send initial org_kde_plasma_virtual_desktop_management.rows.
Jan 25 2019, 12:19 PM · Frameworks
davidedmundson added inline comments to D17122: Add option to use wl_display_add_socket_auto.
Jan 25 2019, 12:19 PM · Frameworks
davidedmundson accepted D18518: Send done event after the number of rows has been changed.
Jan 25 2019, 11:48 AM · KWin
davidedmundson committed R108:7762da762236: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Jan 25 2019, 10:35 AM
davidedmundson committed R108:f3c1786a8974: [wayland] Send VirtualDesktop::done after editing a property (authored by davidedmundson).
[wayland] Send VirtualDesktop::done after editing a property
Jan 25 2019, 10:34 AM
davidedmundson closed D18513: [wayland] Send VirtualDesktop::done after editing a property.
Jan 25 2019, 10:34 AM · KWin
davidedmundson committed R120:be31a5c7cb62: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Jan 25 2019, 10:33 AM
davidedmundson committed R120:aded7178706a: Reload virtual desktop name on change (authored by davidedmundson).
Reload virtual desktop name on change
Jan 25 2019, 10:32 AM
davidedmundson closed D18512: Reload virtual desktop name on change.
Jan 25 2019, 10:32 AM · Plasma
davidedmundson added a comment to D18512: Reload virtual desktop name on change.

Also ideally we should have libtaskmanager only insert after the first done().

Jan 25 2019, 10:06 AM · Plasma
davidedmundson added a comment to D18512: Reload virtual desktop name on change.

Or is it just a workaround for 5.15?

Jan 25 2019, 10:03 AM · Plasma
davidedmundson added inline comments to D18513: [wayland] Send VirtualDesktop::done after editing a property.
Jan 25 2019, 10:01 AM · KWin
davidedmundson requested review of D18515: Bump to Qt5.12 - Drop kwin's custom ServerSideDecorationManager interface.
Jan 25 2019, 9:51 AM · Plasma
davidedmundson updated the diff for D18514: Drop pre Qt5.12 workarounds.

Update

Jan 25 2019, 9:49 AM · Plasma
davidedmundson requested review of D18514: Drop pre Qt5.12 workarounds.
Jan 25 2019, 9:47 AM · Plasma
davidedmundson requested review of D18513: [wayland] Send VirtualDesktop::done after editing a property.
Jan 25 2019, 9:43 AM · KWin
davidedmundson requested review of D18512: Reload virtual desktop name on change.
Jan 25 2019, 9:42 AM · Plasma
davidedmundson added a comment to T9996: Improve Thumbnail Aside effect.

@kives
To be clear, you can't "disagree" with my position as I don't have one. I've merely asked what it's for so we can come up with any solutions that actually deliver on what's actually wanted.

Jan 25 2019, 8:14 AM · KDE Promo, VDG, KWin