[wayland] Send VirtualDesktop::done after editing a property
ClosedPublic
Actions

Authored by davidedmundson on Jan 25 2019, 9:43 AM.

Details

Reviewers

zzag

Group Reviewers

KWin

Commits

Summary

The protocol is double buffered, after changing the name done should be
sent so that clients update.

Test Plan

Changed a VD name on wayland
Pager tooltip updated

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: KWin. · View Herald TranscriptJan 25 2019, 9:43 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

davidedmundson requested review of this revision.Jan 25 2019, 9:43 AM

... and after any other property changes done after that.

Seems sensible.

virtualdesktops.cpp
112–118	Do we have to send the done event here as well?

virtualdesktops.cpp
112–118	Depends on whether you consider "activated" to be a property, which is quite a loosely defined concept. You could argue a case for either.

This revision is now accepted and ready to land.Jan 25 2019, 10:03 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			virtualdesktops.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	50220	c7ac839		Jan 25 2019, 9:43 AM	★	★
Diff 2	50229	433a121	R108:f3c1786a897493f280e62a39b8e04d2c83d15567	Jan 25 2019, 10:33 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
cec9ab8fcd3b	3cb7924367b7	c7ac839db674	David Edmundson	[wayland] Send VirtualDesktop::done after editing a property (Show More…)	Jan 25 2019, 9:43 AM