Reload virtual desktop name on change
ClosedPublic

Authored by davidedmundson on Jan 25 2019, 9:42 AM.

Details

Summary

PlasmaVirtualDesktop at a protocol level is double buffered.

There's a done() command emitted after property changes. After this the
name might have changed.

Test Plan

Changed a desktop name (with relevant kwin patch)
Name changed in the pager tooltip

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 25 2019, 9:42 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 25 2019, 9:42 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 25 2019, 9:42 AM
zzag added a subscriber: zzag.Jan 25 2019, 9:54 AM

Wouldn't it be better to have nameChanged signal. done seems to be a low-level thing. Or is it just a workaround for 5.15?

Or is it just a workaround for 5.15?

Partly yes.

If we do have a nameChanged signal in the client we should double-buffer the value properly.

Also ideally we should have libtaskmanager only insert after the first done().

Though I'm not sure how to nicely make that async whilst keeping "position" correct.

hein accepted this revision.Jan 25 2019, 10:30 AM
This revision is now accepted and ready to land.Jan 25 2019, 10:30 AM
This revision was automatically updated to reflect the committed changes.