Differential D18592

[wayland] Call ShellClient install interface methods consistently
ClosedPublic
Actions

Authored by davidedmundson on Jan 29 2019, 12:56 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:4240c4af054f: [wayland] Call ShellClient install interface methods consistently
Summary

When we create a new Shellclient there may be a pending relevant
interface.

For every other case this is handled in WaylandServer, the class
responsible for attaching new interfaces at runtime.
The only exception is ServerSideDecorationInterface which is handled in
the ShellClient constructor.

This makes everything consistent.

No behavioural changes.

Test Plan

Ran unit tests

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: KWin. · View Herald TranscriptJan 29 2019, 12:56 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jan 29 2019, 12:56 PM
zzag accepted this revision.Jan 29 2019, 1:27 PM
This revision is now accepted and ready to land.Jan 29 2019, 1:27 PM
Closed by commit R108:4240c4af054f: [wayland] Call ShellClient install interface methods consistently (authored by davidedmundson). · Explain WhyJan 30 2019, 1:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell_client.cpp (4 lines)
Mwayland_server.cpp (3 lines)

Diff 50538

View Options

shell_client.cpp

Loading...
View Options

wayland_server.cpp

Loading...