[autotests] Untangle ShellClient::testMaximizedToFullscreen

Authored by davidedmundson on Jan 29 2019, 12:02 PM.



XdgShell and WlShell behave very differently when it comes to switching
from normal to maximised to fullscreen and back. Under XDGShell they are
2 properties, under WlShell it's a tristate enum.

This test was testing something very specific under WlShell and then
became a horrid mess of if statements doing different things and testing
different things. Especially after XdgShell got proper configure

This patch splits it into two methods.

Test Plan

Ran test

Diff Detail

R108 KWin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: KWin. · View Herald TranscriptJan 29 2019, 12:02 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jan 29 2019, 12:02 PM

sneakily update something

zzag accepted this revision.Jan 29 2019, 12:07 PM
zzag added a subscriber: zzag.


I was thinking about doing the same.

This revision is now accepted and ready to land.Jan 29 2019, 12:07 PM
This revision was automatically updated to reflect the committed changes.