Differential D18596

Set combobox popups to be modal
ClosedPublic
Actions

Authored by davidedmundson on Jan 29 2019, 2:53 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R858:0ac99af6e691: Set combobox popups to be modal
Summary

This closer matches what we see on QWidgets where losing focus closes
the combobox.

BUG: 403403

Test Plan

Opened a combobox
Clicked outside
It closed

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 29 2019, 2:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 29 2019, 2:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 29 2019, 2:53 PM
ngraham accepted this revision.Jan 29 2019, 3:27 PM
This revision is now accepted and ready to land.Jan 29 2019, 3:27 PM
Closed by commit R858:0ac99af6e691: Set combobox popups to be modal (authored by davidedmundson). · Explain WhyJan 29 2019, 4:42 PM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.Feb 1 2019, 8:08 AM

It's still a bit weird that the closing of combobox popups fails to function in embedded view like System Settings. Still +1 as this makes the behavior consistent with what we have on X elsewhere.

ngraham added a comment.Feb 1 2019, 4:30 PM

After living with this for a few days, I notice that now the behavior is reversed: clicking anywhere else will close but pop-up, but clicking on the button will not!

Revision Contents
Changeset List

PathPackages
Morg.kde.desktop/ComboBox.qml (1 line)

Diff 50489

View Options

org.kde.desktop/ComboBox.qml

Loading...