Differential D18615

Fix mime type filter on background selection button
ClosedPublic
Actions

Authored by davidedmundson on Jan 30 2019, 11:46 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R123:159e2dcbf935: Fix mime type filter on background selection button
Summary

Ported to explicit QFileDialog instance instead of static method partly
because I don't understand how to use the magic nameFilter syntax to set
mimes, partly to ease the eventual porting to QtQuick which can't have a
blockign dialog.

BUG: 402930

Test Plan

Clicked on the button
Only image files were listed
Selecting one still worked

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 30 2019, 11:46 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 30 2019, 11:46 AM
ngraham accepted this revision.Jan 31 2019, 11:13 PM
This revision is now accepted and ready to land.Jan 31 2019, 11:13 PM
Closed by commit R123:159e2dcbf935: Fix mime type filter on background selection button (authored by davidedmundson). · Explain WhyFeb 5 2019, 10:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 50926

View Options

src/configwidgets/selectimagebutton.cpp

Loading...