• force focus upon entering expandend state

This fixes the potential crash issue (yikes) and the need to hit the shortcut multiple times, but now the search field no longer automatically receives focus when that action is triggered and it becomes visible.

Is anybody working on this?

Given that we're already depending on something newer than the 5.9 Qt LTS version, I don't see the harm in this, especially if it allows us to clean some things up.

Great work!

probably arcanist trying to apply the already merged dependent revision, I've rebased

• rebase

• rebase

• rebase

• rebase

Needs a rebase I think.

• use clicked consistently
• fix click with audio files

Good idea.

Oops, my bad. Just one thing to change:

friendly ping

• fix tests

• rebase

In D22576#498503, @ngraham wrote:

+1 for visual consistency. However I'm not a fan of emulating the look with a custom control here; it'll break the moment InlineMessage is changed to look like something else.

We can go with this for now, but I'd prefer for InlineMessage to gain the ability to display a busy indicator natively, and then we can port it to use that directly. Let's add a TODO comment in the code that mentions this.

+1 for visual consistency. However I'm not a fan of emulating the look with a custom control here; it'll break the moment InlineMessage is changed to look like something else.

LGTM!

In D21911#495600, @ngraham wrote:

That's probably worth a Kirigami bug report.

• add actions

I believe we'll need @abetts .svg file- I can't seem to find it.

That's probably worth a Kirigami bug report.

• wrap main label in case no secondary text is displayed

sorry!

• completely remove signal

I tried to implement the actions for load and save playlist. However, InlineMessage seems only to be compatible with Kirigami Actions and not with the qqc2 ones, which is unfortunate

• fixup type

Yes, the Kirigami SearchField should be a drop-in replacement. I actually tried to do it as a part of my patch to redo the main view's toolbar but got conflicting shortcut errors and dropped it for the moment.

I haven't looked that much into leveraging Kirigami yet and did not know about the FormLayout, so thanks. When the consolidation of the existing qml code and the full port to qqc2 is done, I will have a look at it.
There is also the search bar etc. which could be replaced by Kirigami components, I think.
Btw, there still is D21911 :)

Makes sense. :) LGTM!

Definitely, but I wanted to get it fully working before I break it again :)

Sensible improvement. A nice next step would be to make the whole metadata view into a standalone Kirigami FormLayout instead of each user making its own ListView or ColumnLayout, and each item being a RowLayout full of custom sizing and alignment code.

Should use the same grid and list browser delegates used by the other views IMO.

• fixup

before