Adjust visuals of metadata view
ClosedPublic

Authored by astippich on Jul 13 2019, 9:46 AM.

Details

Summary

Reduce label height of each entry, fix display of image when
no album art is available

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Jul 13 2019, 9:46 AM
astippich created this revision.

before


after

ngraham accepted this revision.Jul 13 2019, 5:07 PM

Sensible improvement. A nice next step would be to make the whole metadata view into a standalone Kirigami FormLayout instead of each user making its own ListView or ColumnLayout, and each item being a RowLayout full of custom sizing and alignment code.

This revision is now accepted and ready to land.Jul 13 2019, 5:07 PM

I haven't looked that much into leveraging Kirigami yet and did not know about the FormLayout, so thanks. When the consolidation of the existing qml code and the full port to qqc2 is done, I will have a look at it.
There is also the search bar etc. which could be replaced by Kirigami components, I think.
Btw, there still is D21911 :)

This revision was automatically updated to reflect the committed changes.

Yes, the Kirigami SearchField should be a drop-in replacement. I actually tried to do it as a part of my patch to redo the main view's toolbar but got conflicting shortcut errors and dropped it for the moment.

I'll take a look at D21911 in the next few days!