@apol doing so results in
CMake Error at src/app/CMakeLists.txt:87 (install): install TARGETS given no BUNDLE DESTINATION for MACOSX_BUNDLE executable target "minuet".
Feed Advanced Search
Apr 24 2020
Apr 24 2020
patrickelectric updated the diff for D29077: Fix MacOS build for missing bundle.
patrickelectric added a comment to D29077: Fix MacOS build for missing bundle.
Apr 23 2020
Apr 23 2020
wip
patrickelectric requested review of D29128: Search for exercises in XDG_DATA_DIRS for macos.
patrickelectric requested review of D29114: Fix search for GeneralUser soundfonts for MacOS.
patrickelectric added a comment to D29077: Fix MacOS build for missing bundle.
@apol is that what you mean ?
patrickelectric updated the diff for D29077: Fix MacOS build for missing bundle.
Apr 22 2020
Apr 22 2020
patrickelectric requested review of D29078: Add missing overrides.
patrickelectric requested review of D29077: Fix MacOS build for missing bundle.
Apr 7 2020
Apr 7 2020
patrickelectric committed R361:da8c799e5daf: Add a .arcconfig file to use arcanist (authored by araujoluis).
Add a .arcconfig file to use arcanist
patrickelectric committed R361:32fbeb89bdbf: Add a .arcconfig file to use arcanist (authored by araujoluis).
Add a .arcconfig file to use arcanist
patrickelectric added a comment to D28607: Add a .arcconfig file to use arcanist.
@dakon It's @araujoluis first MR and we are still here in phabricator, so I don't see why not merge if we are not in gitlab yet.
Apr 6 2020
Apr 6 2020
patrickelectric committed R954:e94fb776a2a7: planet: Add patrickelectric back (authored by patrickelectric).
planet: Add patrickelectric back
Mar 9 2020
Mar 9 2020
README: Add badges
Mar 8 2020
Mar 8 2020
patrickelectric added a comment to D27712: Fix kirogi compilation on binary-factory.
Hi @jjazeix this did fix the android build, but now it's failing with libQtZeroConf, and after your fix with:
qrc:/FlightControls.qml:29 module "org.kde.kirogi.video" is not installed
Mar 4 2020
Mar 4 2020
patrickelectric committed R1034:2ffd8dec0319: parrotconnection: Use default (authored by patrickelectric).
parrotconnection: Use default
patrickelectric committed R1034:d5a16d5e98b5: parrotprotocol: Use default (authored by patrickelectric).
parrotprotocol: Use default
patrickelectric committed R1034:7649533e0c3a: vehiclesupportpluginmodel: Remove else before return (authored by patrickelectric).
vehiclesupportpluginmodel: Remove else before return
patrickelectric committed R1034:df34989c061d: vehiclesupportplugin: Set constructor as explicit (authored by patrickelectric).
vehiclesupportplugin: Set constructor as explicit
patrickelectric committed R1034:548b4804b8e9: main: Use static member of QApplication (authored by patrickelectric).
main: Use static member of QApplication
patrickelectric committed R1034:7ec1cba1405d: positionsource: Define setPositionSourceError as static (authored by patrickelectric).
positionsource: Define setPositionSourceError as static
patrickelectric committed R1034:dc919403733d: vehiclesupportplugin: Use default (authored by patrickelectric).
vehiclesupportplugin: Use default
patrickelectric committed R1034:b957bdcaa974: abstractvehicle: Set constructor as explicit (authored by patrickelectric).
abstractvehicle: Set constructor as explicit
patrickelectric committed R1034:ef6322d72dfa: gstreamerintegration: Move processPipelineMessage to static function (authored by patrickelectric).
gstreamerintegration: Move processPipelineMessage to static function
Mar 3 2020
Mar 3 2020
patrickelectric committed R1034:9f073faa82c3: FlightControls: Fix YawBar anchors (authored by patrickelectric).
FlightControls: Fix YawBar anchors
patrickelectric committed R1034:ecbc741ad4cc: CMakeLists: Move to C++17 (authored by patrickelectric).
CMakeLists: Move to C++17
patrickelectric committed R1034:9935caa6a3a0: mavlinkvehicle: Use new generic sendMessage (authored by patrickelectric).
mavlinkvehicle: Use new generic sendMessage
patrickelectric committed R1034:392fe6633982: mavlinkconnection: Use generic type in sendMessage (authored by patrickelectric).
mavlinkconnection: Use generic type in sendMessage
patrickelectric committed R1034:b293a1174fe4: FlightControls: Check if vehicle exist before updating joystick values (authored by patrickelectric).
FlightControls: Check if vehicle exist before updating joystick values
patrickelectric committed R1034:43a77e8e32bf: FlightControls: Use new setNewStickPosition over duplicated code (authored by patrickelectric).
FlightControls: Use new setNewStickPosition over duplicated code
patrickelectric committed R1034:1074651646b4: gstreamerintegration: Does not force aspect ratio (authored by patrickelectric).
gstreamerintegration: Does not force aspect ratio
patrickelectric committed R1034:b75836af6456: Settings: Add Video section with stretchVideo settings (authored by patrickelectric).
Settings: Add Video section with stretchVideo settings
patrickelectric committed R1034:37c3944b936c: kirogi: Add stretchVideo settings (authored by patrickelectric).
kirogi: Add stretchVideo settings
patrickelectric committed R1034:c0cccac10ed3: FlightControls: Use stretchVideo settings (authored by patrickelectric).
FlightControls: Use stretchVideo settings
Feb 24 2020
Feb 24 2020
patrickelectric committed R1034:31a3b5338133: NavigatorMap: Fix tooltip (authored by patrickelectric).
NavigatorMap: Fix tooltip
patrickelectric committed R1034:b202be9effd7: FlightControls: Fix tooltip (authored by patrickelectric).
FlightControls: Fix tooltip
Feb 21 2020
Feb 21 2020
patrickelectric committed R1034:a391fce9e259: README: Move from webp to png (authored by patrickelectric).
README: Move from webp to png
patrickelectric committed R1035:1b6eb98ffb59: assets: imgs: Add kirogi.png (authored by patrickelectric).
assets: imgs: Add kirogi.png
patrickelectric committed R1035:47b4160cf4b4: assets: imgs: Add goose.png (authored by patrickelectric).
assets: imgs: Add goose.png
patrickelectric committed R1034:39ce18fc2cba: vehiclesupportpluginmodel: Fix private q shadow (authored by patrickelectric).
vehiclesupportpluginmodel: Fix private q shadow
patrickelectric committed R1034:2e659d5b6798: abstractvehicle: Fix private q shadow (authored by patrickelectric).
abstractvehicle: Fix private q shadow
patrickelectric committed R1034:eb0b8335cdba: parrot: Add more warning flags (authored by patrickelectric).
parrot: Add more warning flags
patrickelectric committed R1034:a48a0274e267: ryzetello: Add more warning flags (authored by patrickelectric).
ryzetello: Add more warning flags
patrickelectric committed R1034:a48eac4f09b6: mavlink: Add more warning flags (authored by patrickelectric).
mavlink: Add more warning flags
patrickelectric committed R1034:3a4e784a189b: vehicleparameters: Add more warning flags (authored by patrickelectric).
vehicleparameters: Add more warning flags
patrickelectric committed R1034:fe89e88c472b: positionsource: Add more warning flags (authored by patrickelectric).
positionsource: Add more warning flags
patrickelectric committed R1034:440eba9b34c7: lib: Add more warning flags (authored by patrickelectric).
lib: Add more warning flags
patrickelectric committed R1034:13faf0c7c11f: gstreamer: Add more warning flags (authored by patrickelectric).
gstreamer: Add more warning flags
patrickelectric committed R1034:1e2ace17e434: src: Add more warning flags (authored by patrickelectric).
src: Add more warning flags
patrickelectric committed R1034:1603e6a0215d: positionsource: Add missing header (authored by patrickelectric).
positionsource: Add missing header
patrickelectric committed R1034:8b001148902f: mavlink: Ignore -Wpedantic in mavlink include (authored by patrickelectric).
mavlink: Ignore -Wpedantic in mavlink include
patrickelectric committed R1034:41b2011f9e56: main: Remove warnings from gst (authored by patrickelectric).
main: Remove warnings from gst
patrickelectric committed R1034:1e47246bf4ec: plugins: ryzetello: Add new warning flags (authored by patrickelectric).
plugins: ryzetello: Add new warning flags
patrickelectric committed R1034:bf52a6986671: gstreamer: Use forward declaraction for GstElement and GstMessage (authored by patrickelectric).
gstreamer: Use forward declaraction for GstElement and GstMessage
patrickelectric committed R1034:444447274a75: plugins: mavlink: Add new warning flags (authored by patrickelectric).
plugins: mavlink: Add new warning flags
patrickelectric committed R1034:374abfa597cd: plugins: parrot: Add new warning flags (authored by patrickelectric).
plugins: parrot: Add new warning flags
patrickelectric committed R1034:baf3f4d23e1c: vehicleparameters: Add new warning flags (authored by patrickelectric).
vehicleparameters: Add new warning flags
patrickelectric committed R1034:c4adb88836bc: positionsource: Add new warning flags (authored by patrickelectric).
positionsource: Add new warning flags
patrickelectric committed R1034:d73d85ab19c8: lib: Add new warning flags (authored by patrickelectric).
lib: Add new warning flags
patrickelectric committed R1034:3be6b34e3a66: src: Add new warning flags (authored by patrickelectric).
src: Add new warning flags
patrickelectric committed R1034:2a64bfbd8e9e: gstreamer: Add CMakeLists (authored by patrickelectric).
gstreamer: Add CMakeLists
patrickelectric committed R1034:317bbbe3188c: src: Use gstreamer library (authored by patrickelectric).
src: Use gstreamer library
patrickelectric committed R1034:5b293a7414dd: mavlink: Add MSVC and old GCC version tests (authored by patrickelectric).
mavlink: Add MSVC and old GCC version tests
Feb 19 2020
Feb 19 2020
Jan 27 2020
Jan 27 2020
patrickelectric committed R1034:13c0c67d1c9f: FindMavlink: Make mavlink 2.0 the default version (authored by patrickelectric).
FindMavlink: Make mavlink 2.0 the default version
Jan 26 2020
Jan 26 2020
patrickelectric committed R240:e8abb9601c7d: ECMAddAppIcon: Add sc in regex to extract extension from valid names (authored by patrickelectric).
ECMAddAppIcon: Add sc in regex to extract extension from valid names
Jan 20 2020
Jan 20 2020
patrickelectric added a comment to D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names.
@apol I did update the commit body to explain why.
For the text I used https://regex101.com with the icon in the commit body and printing the variables of CMAKE_MATCH_1 and CMAKE_MATCH_2
Let me know if you agree with this to land the patch, this is necessary to continue D26752
patrickelectric updated the diff for D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names.
Add commit body
patrickelectric added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
Hi @cgiboudeaux, thanks for the explanation, I'll take a look and get back here.
Jan 19 2020
Jan 19 2020
patrickelectric added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
Hi @cgiboudeaux and @bcooksley, there is a reason of why this patch is valid. Have you read the commit message ?
patrickelectric committed R1034:e215c1ba296b: gstreamer: Run clang-format in .c (authored by patrickelectric).
gstreamer: Run clang-format in .c
patrickelectric committed R1034:b93cd9561123: gstreamerintegration: Add test for videoOutput pointer (authored by patrickelectric).
gstreamerintegration: Add test for videoOutput pointer
patrickelectric committed R1034:d0a4f5136785: gstreamerintegration: Add assert for pipeline (authored by patrickelectric).
gstreamerintegration: Add assert for pipeline
Jan 18 2020
Jan 18 2020
patrickelectric committed R1034:58669f5edaeb: vehiclesupportpluginmodel: Use any_of (authored by patrickelectric).
vehiclesupportpluginmodel: Use any_of
patrickelectric committed R1034:67af51e165c1: vehicleparameters: Add Q_UNUSED in loadDescriptionFile (authored by patrickelectric).
vehicleparameters: Add Q_UNUSED in loadDescriptionFile
patrickelectric committed R1034:6356857d8b46: mavlink: Move GSC check to mavlinkconnection (authored by patrickelectric).
mavlink: Move GSC check to mavlinkconnection
patrickelectric committed R1034:fc905a1b26bb: abstractvehicle: Add missing Q_INVOKABLE in setControllerGpsPosition (authored by patrickelectric).
abstractvehicle: Add missing Q_INVOKABLE in setControllerGpsPosition
patrickelectric retitled D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build from ECMAddAppIcon: Do not warn about mac icons if isnt a mac build to ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
patrickelectric added a reviewer for D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names: apol.
patrickelectric added a comment to D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names.
From ECMInstallIcons:
Jan 3 2020
Jan 3 2020
patrickelectric committed R1034:f0646437fb8a: Vehicle: Update item to use the new role style (authored by patrickelectric).
Vehicle: Update item to use the new role style
patrickelectric committed R1034:7810bc0980fc: mavlink: Fetch parameters and use parametermodel (authored by patrickelectric).
mavlink: Fetch parameters and use parametermodel
patrickelectric committed R1034:4d944939c86c: vehiclesupportpluginmodel: Remove capitalized role names (authored by patrickelectric).
vehiclesupportpluginmodel: Remove capitalized role names
patrickelectric committed R1034:7a2c48d0a59c: vehicleparameters: First version (authored by patrickelectric).
vehicleparameters: First version
Dec 26 2019
Dec 26 2019
patrickelectric committed R1034:951969814065: positionsource: Add missing periods (authored by patrickelectric).
positionsource: Add missing periods
patrickelectric committed R1034:0a1af2d2754d: FlightControls: Use new position source from kirogi plugin (authored by patrickelectric).
FlightControls: Use new position source from kirogi plugin
patrickelectric committed R1034:555e2f459ac0: positionsource: First version (authored by patrickelectric).
positionsource: First version
patrickelectric committed R1034:0680e5dd8794: main: Use PositionSource (authored by patrickelectric).
main: Use PositionSource
Dec 24 2019
Dec 24 2019
patrickelectric committed R1034:1b3654c8a8b9: Merge branch 'fix_style' into 'master' (authored by patrickelectric).
Merge branch 'fix_style' into 'master'
patrickelectric committed R1034:d669a4d0130c: mavlinkvehicle: Fix code style (authored by patrickelectric).
mavlinkvehicle: Fix code style
patrickelectric committed R1034:df49d2825ddd: Merge branch 'position_invalidate' into 'master' (authored by patrickelectric).
Merge branch 'position_invalidate' into 'master'
patrickelectric committed R1034:a47a080e5e8b: mavlinkvehicle: Invalidate position information if values are invalid (authored by patrickelectric).
mavlinkvehicle: Invalidate position information if values are invalid
patrickelectric committed R1034:87921560e5d4: YawBar: Allow vehicle feedback if the vehicle is not ready to fly (authored by patrickelectric).
YawBar: Allow vehicle feedback if the vehicle is not ready to fly
patrickelectric committed R1034:81823f0932c6: Merge branch 'remove_ready' into 'master' (authored by patrickelectric).
Merge branch 'remove_ready' into 'master'