dakon (Rolf Eike Beer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 30 2016, 8:55 PM (129 w, 4 d)
Availability
Available

Recent Activity

Mar 19 2019

dakon added inline comments to D19766: Improve performance of cliplugins.
Mar 19 2019, 10:58 PM · Ark

Mar 18 2019

dakon added inline comments to D19766: Improve performance of cliplugins.
Mar 18 2019, 8:09 PM · Ark

Feb 21 2019

dakon committed R32:5bf2c3aae6ec: optimize CMakeBuildDirChooser::buildDirSettings() (authored by dakon).
optimize CMakeBuildDirChooser::buildDirSettings()
Feb 21 2019, 9:12 PM
dakon closed D18857: optimize CMakeBuildDirChooser::buildDirSettings().
Feb 21 2019, 9:06 PM · KDevelop

Feb 19 2019

dakon updated the diff for D18857: optimize CMakeBuildDirChooser::buildDirSettings().

use lambda as suggested by Milian

Feb 19 2019, 4:33 PM · KDevelop

Feb 10 2019

dakon added a comment to D18857: optimize CMakeBuildDirChooser::buildDirSettings().

No, I was just looking at it. I could remove the QByteArray change and reduce it to online the x.remove() and "else if" parts.

Feb 10 2019, 4:30 PM · KDevelop
dakon committed R32:4a219756059e: CMakeBuildDirChooser: avoid calling deprecated KUrlRequester::setPath() (authored by dakon).
CMakeBuildDirChooser: avoid calling deprecated KUrlRequester::setPath()
Feb 10 2019, 12:55 PM
dakon closed D18856: CMakeBuildDirChooser: avoid calling deprecated KUrlRequester::setPath().
Feb 10 2019, 12:55 PM · KDevelop
dakon created P311 arc error in the S1 KDE Community space.
Feb 10 2019, 12:34 PM
dakon added a comment to D18857: optimize CMakeBuildDirChooser::buildDirSettings().

The QByteArray was already created the same way, now the intermediate object is just cached. But even if that did not change anything it reduces the number of utf8 conversion as only those lines that actually match anything will be converted.

Feb 10 2019, 12:28 PM · KDevelop

Feb 8 2019

dakon requested review of D18857: optimize CMakeBuildDirChooser::buildDirSettings().
Feb 8 2019, 4:58 PM · KDevelop
dakon requested review of D18856: CMakeBuildDirChooser: avoid calling deprecated KUrlRequester::setPath().
Feb 8 2019, 4:55 PM · KDevelop

Feb 3 2019

dakon committed R353:afff5eda42a4: default destructor (authored by dakon).
default destructor
Feb 3 2019, 12:31 PM
dakon committed R353:928444bd80f5: initialize members in initializer list (authored by dakon).
initialize members in initializer list
Feb 3 2019, 12:31 PM
dakon committed R353:18b2a1bed0e1: use QOverload<>::of() instead of static:cast<> (authored by dakon).
use QOverload<>::of() instead of static:cast<>
Feb 3 2019, 12:25 PM
dakon committed R971:14a46388d47a: fix EBN links (authored by dakon).
fix EBN links
Feb 3 2019, 2:20 AM

Feb 2 2019

dakon committed R358:b92a7d2609cd: use QOverload<>::of instead of static_cast<> (authored by dakon).
use QOverload<>::of instead of static_cast<>
Feb 2 2019, 8:44 PM

Jan 13 2019

dakon committed R358:01c16fc20590: use lambda instead of explicit helper function (authored by dakon).
use lambda instead of explicit helper function
Jan 13 2019, 4:33 PM
dakon committed R358:553221670992: add missing parent (authored by dakon).
add missing parent
Jan 13 2019, 4:23 PM

Jan 4 2019

dakon committed R358:b4cb613b73b9: update keymanager screenshot in handbook (authored by dakon).
update keymanager screenshot in handbook
Jan 4 2019, 8:13 PM

Dec 25 2018

dakon accepted D17795: Fix minor Doxygen issues.

Awesome!

Dec 25 2018, 10:19 AM

Dec 20 2018

dakon added inline comments to D17687: Update screenshots of the handbook..
Dec 20 2018, 1:57 PM
dakon added inline comments to D17687: Update screenshots of the handbook..
Dec 20 2018, 1:11 PM

Dec 19 2018

dakon added inline comments to D17687: Update screenshots of the handbook..
Dec 19 2018, 5:20 PM

Nov 26 2018

dakon committed R32:607826ff45b9: tests: more expected patterns for formatComment() (authored by dakon).
tests: more expected patterns for formatComment()
Nov 26 2018, 5:16 PM

Nov 18 2018

dakon added inline comments to D16942: CMakeCacheModel: avoid string memory duplication.
Nov 18 2018, 8:09 PM · KDevelop

Nov 17 2018

dakon committed R32:bb3e26b21e67: CMakeCacheModel: remove impossible case (authored by dakon).
CMakeCacheModel: remove impossible case
Nov 17 2018, 7:05 PM
dakon committed R32:c4a0e378e980: CMakeCacheModel: avoid string memory duplication (authored by dakon).
CMakeCacheModel: avoid string memory duplication
Nov 17 2018, 7:05 PM
dakon closed D16942: CMakeCacheModel: avoid string memory duplication.
Nov 17 2018, 7:05 PM · KDevelop
dakon requested review of D16942: CMakeCacheModel: avoid string memory duplication.
Nov 17 2018, 9:08 AM · KDevelop

Nov 15 2018

dakon committed R32:2e82c3e52f5b: tests: fix naming of test lines (authored by dakon).
tests: fix naming of test lines
Nov 15 2018, 10:29 PM
dakon committed R32:b64a03ee4964: simplify formatComment_impl() (authored by dakon).
simplify formatComment_impl()
Nov 15 2018, 10:29 PM

Nov 4 2018

dakon committed R358:7a550daf0192: avoid needless partitions of QStrings (authored by dakon).
avoid needless partitions of QStrings
Nov 4 2018, 10:33 AM
dakon committed R358:09d4fd7d34e8: update template for pgp.cs.uu.nl key url (authored by dakon).
update template for pgp.cs.uu.nl key url
Nov 4 2018, 10:33 AM
dakon committed R358:da0a639de189: fix length 16 placeholders in key urls not having length 16 (authored by dakon).
fix length 16 placeholders in key urls not having length 16
Nov 4 2018, 10:33 AM
dakon committed R358:8be254270513: improve code to sort signatures (authored by dakon).
improve code to sort signatures
Nov 4 2018, 10:33 AM
dakon committed R358:fdfe3c87ec69: avoid conversions to lowercase, just use case insensitive compare functions (authored by dakon).
avoid conversions to lowercase, just use case insensitive compare functions
Nov 4 2018, 10:33 AM

Nov 3 2018

dakon requested changes to D15369: Add support for Zstd-compressed Tar-archives.
Nov 3 2018, 5:25 PM · Ark

Oct 31 2018

dakon committed R107:8ff1fa703793: use ssize_t for return value of write() (authored by dakon).
use ssize_t for return value of write()
Oct 31 2018, 11:38 AM
dakon committed R107:fcbcf0f1bdfa: do not use buffered file IO (authored by dakon).
do not use buffered file IO
Oct 31 2018, 11:38 AM
dakon closed D13100: do not use buffered file IO.
Oct 31 2018, 11:37 AM · Plasma

Oct 27 2018

dakon added inline comments to D13100: do not use buffered file IO.
Oct 27 2018, 5:13 PM · Plasma

Oct 13 2018

dakon updated the diff for D13100: do not use buffered file IO.

O_CREAT was missing, as well as the file mode. O_CLOEXEC is available for a long time, there should be no need for the compat define.

Oct 13 2018, 12:20 PM · Plasma

Sep 23 2018

dakon committed R358:0c182eabb785: Merge branch 'Applications/18.08' (authored by dakon).
Merge branch 'Applications/18.08'
Sep 23 2018, 9:34 AM
dakon committed R358:455f295ebcf2: add .editorconfig (authored by dakon).
add .editorconfig
Sep 23 2018, 9:33 AM

Sep 4 2018

dakon accepted D14886: Use QTEST_GUILESS_MAIN.

Sorry, this somehow got lost. Fine with me if it works.

Sep 4 2018, 7:14 PM

Aug 31 2018

dakon committed R971:78cd6a26ba9f: 18.08 is already released (authored by dakon).
18.08 is already released
Aug 31 2018, 7:05 PM

Aug 20 2018

dakon added inline comments to D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available.
Aug 20 2018, 4:48 PM · Frameworks

Aug 7 2018

dakon committed R971:81da3c948b8b: KTimer: set version numbers (authored by dakon).
KTimer: set version numbers
Aug 7 2018, 6:25 PM

Jul 28 2018

dakon committed R358:72c981bcce2b: Fix translated labels text cropping in kgpgfirstassistant. (authored by Pavel Akopov <pak@altlinux.org>).
Fix translated labels text cropping in kgpgfirstassistant.
Jul 28 2018, 2:52 PM
dakon closed D14292: Fix translated labels text cropping..
Jul 28 2018, 2:52 PM

Jul 25 2018

dakon accepted D14292: Fix translated labels text cropping..

Please send a git diff directly to me, then I will apply this.

Jul 25 2018, 4:58 PM

Jul 24 2018

dakon requested changes to D14292: Fix translated labels text cropping..

The change is now without the "small refactoring" from the title. The indentation is tabs. Otherwise fine with me, destination will be 18.08 branch.

Jul 24 2018, 3:12 PM
dakon requested changes to D14292: Fix translated labels text cropping..

Thanks for the patch! Can you please do a patch without all these lambda changes? They don't make anything more readable, and they make reviewing much harder through lot of unrelated changes.

Jul 24 2018, 5:05 AM

Jul 22 2018

dakon closed T8932: KGpg tests in FreeBSD as Resolved.

Yes, seems to work. They are generally a bit flaky, but those looks like timeouts to me as they usually just work on next run.

Jul 22 2018, 8:14 AM · build.kde.org

Jul 11 2018

dakon committed R32:a90fffe27585: make syntax highlighting examples more valid C/C++ (authored by dakon).
make syntax highlighting examples more valid C/C++
Jul 11 2018, 4:36 PM
dakon closed D14032: make syntax highlighting examples more valid C/C++.
Jul 11 2018, 4:36 PM · KDevelop

Jul 10 2018

dakon added a comment to D14028: Ignore squashfs partitions.

I wonder why tmpfs is listed here. Cleaning up /tmp may actually be useful. devtmpfs is indeed something that should be filtered. iso9660 would be another good candidate. And perhaps bind mounts.

Jul 10 2018, 8:15 PM
dakon added a reviewer for D14032: make syntax highlighting examples more valid C/C++: KDevelop.
Jul 10 2018, 6:45 PM · KDevelop
dakon requested review of D14032: make syntax highlighting examples more valid C/C++.
Jul 10 2018, 6:44 PM · KDevelop

Jun 29 2018

dakon committed R358:770563932e34: return std::vector instead of QList from KeyTreeView::selectedNodes() (authored by dakon).
return std::vector instead of QList from KeyTreeView::selectedNodes()
Jun 29 2018, 4:36 PM
dakon committed R358:c4867698ee71: get rid of foreach (authored by dakon).
get rid of foreach
Jun 29 2018, 4:36 PM
dakon committed R358:bed36a6f49a4: factor out duplicate code to find best encryption key (authored by dakon).
factor out duplicate code to find best encryption key
Jun 29 2018, 4:36 PM
dakon committed R358:9f1318613acf: clean up _describe_key_strength() (authored by dakon).
clean up _describe_key_strength()
Jun 29 2018, 4:36 PM
dakon committed R358:e4b2f119530c: tests: clean up checking encrypted text format (authored by dakon).
tests: clean up checking encrypted text format
Jun 29 2018, 4:36 PM

Jun 24 2018

dakon accepted D12937: Drop privileges when reading the salt file.
Jun 24 2018, 12:55 PM · Plasma

Jun 16 2018

dakon added a comment to T8932: KGpg tests in FreeBSD .

I have reworked the tests so every test creates it's own temporary directory as GnuPG homedir, which seems to have fixed the problems on FreeBSD. Similar problems now happen on the SUSE builder, but for fewer tests.

Jun 16 2018, 12:12 PM · build.kde.org
dakon committed R358:ede9e0f3cf4b: tests: increase timeouts, GnuPG can need a bit (authored by dakon).
tests: increase timeouts, GnuPG can need a bit
Jun 16 2018, 11:27 AM
dakon committed R358:fee4645eab3d: tests: build common code only once (authored by dakon).
tests: build common code only once
Jun 16 2018, 11:12 AM
dakon committed R358:057861c752f5: tests: allow to run in parallel (authored by dakon).
tests: allow to run in parallel
Jun 16 2018, 11:12 AM

Jun 15 2018

dakon committed R358:8652a39ff662: use more KGpgTransaction::addArguments() (authored by dakon).
use more KGpgTransaction::addArguments()
Jun 15 2018, 6:45 PM
dakon committed R358:a34249f2e921: remove the unused return value of KGpgTransaction::addArguments() (authored by dakon).
remove the unused return value of KGpgTransaction::addArguments()
Jun 15 2018, 6:45 PM
dakon committed R358:e59e0d7ef7ef: use delegating constructor (authored by dakon).
use delegating constructor
Jun 15 2018, 6:45 PM
dakon committed R358:e00995ba4420: tests: verify some cornercases (authored by dakon).
tests: verify some cornercases
Jun 15 2018, 6:45 PM
dakon committed R358:07dcbd8fd7f3: tests: include own header first (authored by dakon).
tests: include own header first
Jun 15 2018, 1:36 PM

Jun 14 2018

dakon committed R358:2deafffffddf: tests: verify that invalid email adresses are rejected when adding uid (authored by dakon).
tests: verify that invalid email adresses are rejected when adding uid
Jun 14 2018, 9:11 PM
dakon committed R358:841238585a74: Merge branch 'Applications/18.04' (authored by dakon).
Merge branch 'Applications/18.04'
Jun 14 2018, 8:10 PM
dakon committed R358:d6339571f558: tests: add more casts to fix build with older Qt versions (authored by dakon).
tests: add more casts to fix build with older Qt versions
Jun 14 2018, 8:10 PM
dakon committed R358:d8d8871722b4: tests: fix "add photo" tests (authored by dakon).
tests: fix "add photo" tests
Jun 14 2018, 8:10 PM
dakon committed R358:ba2658398b65: fix handling of photoid.jpeg.size question when adding photo ids (authored by dakon).
fix handling of photoid.jpeg.size question when adding photo ids
Jun 14 2018, 8:09 PM

Jun 9 2018

dakon added a comment to T8932: KGpg tests in FreeBSD .

Could you try running the tests interactively? This could give either new messages or it may suddenly work because a tty is available.

Jun 9 2018, 9:58 PM · build.kde.org

Jun 7 2018

dakon added a comment to T8932: KGpg tests in FreeBSD .

Which gpg version is installed on the FreeBSD machine? GnuPG >=2.1 will automatically start the gpg-agent, while older versions need a running gpg-agent. So the problem could be that the agent is actually _not_ running.

Jun 7 2018, 8:12 PM · build.kde.org

May 29 2018

dakon added a comment to D12937: Drop privileges when reading the salt file.

Nice. Now only the fread() return code needs to be handled and it is perfect.

May 29 2018, 4:01 PM · Plasma

May 27 2018

dakon added inline comments to D12937: Drop privileges when reading the salt file.
May 27 2018, 7:58 PM · Plasma
dakon added inline comments to D12937: Drop privileges when reading the salt file.
May 27 2018, 7:04 PM · Plasma
dakon added inline comments to D12937: Drop privileges when reading the salt file.
May 27 2018, 11:02 AM · Plasma

May 26 2018

dakon committed R358:192bd91a96f2: tests: cleanup (authored by dakon).
tests: cleanup
May 26 2018, 3:56 PM
dakon committed R358:c5993b5bc0bb: tests: do not use Qt module in include statement (authored by dakon).
tests: do not use Qt module in include statement
May 26 2018, 3:56 PM
dakon committed R358:fd5e230f31f7: mark constructor as explicit (authored by dakon).
mark constructor as explicit
May 26 2018, 3:56 PM
dakon committed R358:4062dbb82b42: tests: add more casts to fix build with older Qt versions (authored by dakon).
tests: add more casts to fix build with older Qt versions
May 26 2018, 11:07 AM
dakon committed R358:bc48d813ed22: officially require Qt 5.9 (authored by dakon).
officially require Qt 5.9
May 26 2018, 11:07 AM
dakon committed R358:79aa6174f4bb: tests: add casts to fix build with older Qt versions (authored by dakon).
tests: add casts to fix build with older Qt versions
May 26 2018, 7:22 AM

May 25 2018

dakon committed R358:803d4ed4c697: Make KGpgTransaction::addArgument public. (authored by kavindap).
Make KGpgTransaction::addArgument public.
May 25 2018, 8:06 PM
dakon committed R358:8eda1d47ccc4: tests: stylistic cleanups (authored by dakon).
tests: stylistic cleanups
May 25 2018, 8:03 PM
dakon committed R107:6238b4e188ad: Revert "do not search for C++ compiler" (authored by dakon).
Revert "do not search for C++ compiler"
May 25 2018, 7:10 PM
dakon added a reverting change for R107:bb1bce811545: do not search for C++ compiler: R107:6238b4e188ad: Revert "do not search for C++ compiler".
May 25 2018, 7:10 PM
dakon committed R107:cd50e55a3fe1: use pid_t for fork() result (authored by dakon).
use pid_t for fork() result
May 25 2018, 6:18 PM
dakon committed R107:b1b709807906: store string literal in const variable (authored by dakon).
store string literal in const variable
May 25 2018, 6:18 PM
dakon committed R107:bb1bce811545: do not search for C++ compiler (authored by dakon).
do not search for C++ compiler
May 25 2018, 6:18 PM
dakon requested changes to D12937: Drop privileges when reading the salt file.
May 25 2018, 6:03 PM · Plasma