ECMAddAppIcon: Add sc in regex to extract extension from valid names
ClosedPublic
Actions

Authored by patrickelectric on Jan 18 2020, 1:44 PM.

Details

Reviewers

tcanabrava
apol

Commits

R240:e8abb9601c7d: ECMAddAppIcon: Add sc in regex to extract extension from valid names

Summary

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>

Diff Detail

Repository

R240 Extra CMake Modules

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

patrickelectric created this revision.Jan 18 2020, 1:44 PM

Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJan 18 2020, 1:44 PM

Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript

patrickelectric requested review of this revision.Jan 18 2020, 1:44 PM

Harbormaster completed remote builds in B21316: Diff 73830.Jan 18 2020, 1:44 PM

From ECMInstallIcons:

<size> is a numeric pixel size (typically 16, 22, 32, 48, 64, 128 or 256) or sc for scalable (SVG) files, <group> is one of the standard FreeDesktop.org icon groups (actions, animations, apps, categories, devices, emblems, emotes, intl, mimetypes, places, status) and <ext> is one of .png, .mng or .svgz.

tcanabrava accepted this revision.Jan 18 2020, 1:49 PM

This revision is now accepted and ready to land.Jan 18 2020, 1:49 PM

patrickelectric added a reviewer: apol.Jan 18 2020, 1:50 PM

Looks good to me, bonus points if you provide a better commit message explaining what it does and how you tested it.

krop mentioned this in D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.Jan 20 2020, 9:03 AM

Add commit body

Harbormaster completed remote builds in B21384: Diff 73927.Jan 20 2020, 12:03 PM

@apol I did update the commit body to explain why.
For the text I used https://regex101.com with the icon in the commit body and printing the variables of CMAKE_MATCH_1 and CMAKE_MATCH_2
Let me know if you agree with this to land the patch, this is necessary to continue D26752

Closed by commit R240:e8abb9601c7d: ECMAddAppIcon: Add sc in regex to extract extension from valid names (authored by patrickelectric). · Explain WhyJan 26 2020, 12:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			modules/ECMAddAppIcon.cmake (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	73830	9b62540		Jan 18 2020, 1:44 PM	★	★
Diff 2	73927	9b62540	Add commit body	Jan 20 2020, 12:03 PM	★	★
Diff 3	74388	75ec621	R240:e8abb9601c7d08b2f6ba1ff34344acb282ec829e	Jan 26 2020, 12:53 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
c4d5d928e327	d8442448fdeb	9b62540496ec	Patrick José Pereira	ECMAddAppIcon: Add sc in regex to extract extension from valid names (Show More…)	Jan 18 2020, 1:44 PM

Diff 74388

View Options

modules/ECMAddAppIcon.cmake