• kwidgetsaddons: kcolorcombo: set a constant variables.

• kwidgetsaddons: kcolorcombo: fix paint font colors and simplify painting

• kwidgetsaddons: kcolorcombo: fix comments

• kwidgetsaddons: kcolorcombo: fix comments

• kwidgetsaddons: kcolorcombo: rename variable

• kwidgetsaddons: kcolorcombo: fix comments

• kwidgetsaddons: kcolorcombo: fix comments

• kwidgetsaddons: kcolorcombo: fix comments

• kwidgetsaddons: update comments

• kwidgetsaddons: kcolorcombo: rename innerrect to innerRect

• kwidgetsaddons: kcolorcombo: set QRect colorRect as constant

• kwidgetsaddons: kcolorcombo: rename a set constant for innerColor

Changes made.

• kwidgetsaddons: kcolorcombo: code refactoring

In D29502#665600, @tcanabrava wrote:

In D29502#665582, @cfeck wrote:

Does the delegate ensure the text is rendered in a color visible over the colored background?

not yet, I talked to gustavo and he's working in an updated version of the patch.

This is the current - not in the diff yet - version:

• kwidgetsaddons: kcolorcombo: fix colors() out of range
• kwidgetsaddons: kcolorcombo: tests: add example for use named colors.
• kwidgetsaddons: kcolorcombo: update named colow view.

• restore code deleted by mistake

• Restore code deleted by mistake

In R163:32bf62a5f138ff4b6d6d15470220bd66c618a490#3894422, @pino wrote:

@tcanabrava @carneirogustavo this change does not look correct to me: now both the setters are effectively no-op if the new values are different than the old ones.
Are you sure it was not meant to be if (m_foo == foo) return; instead?