piggz (Adam Pigg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 28 2015, 6:39 PM (185 w, 5 d)
Availability
Available

Recent Activity

Yesterday

piggz added a comment to D17336: Restore support for date/time constants in KEXI SQL.

I used arc patch D17336 on kdb
I get errors like
org.kde.kdb.core: error: syntax error, unexpected $undefined, expecting $end
org.kde.kdb.core: at character 8 near tooken "#"
org.kde.kdb.core: KDbEscapedString:"select #2018-05-23#"
org.kde.kdb.core: " ^"

Tue, Dec 18, 9:50 PM · KDb

Oct 23 2018

piggz committed R224:ee52c8cd03a1: use libkeepalive to wakeup daemon (authored by piggz).
use libkeepalive to wakeup daemon
Oct 23 2018, 7:31 AM
piggz closed D15414: use libkeepalive to wakeup daemon.
Oct 23 2018, 7:31 AM · KDE Connect

Oct 22 2018

piggz updated the diff for D15414: use libkeepalive to wakeup daemon.
  • Dont use clipboard plugin on sailfish as it uses wayland
Oct 22 2018, 5:12 PM · KDE Connect

Oct 10 2018

piggz added inline comments to D15399: Always build Kirigami app.
Oct 10 2018, 3:24 PM · KDE Connect

Sep 13 2018

piggz updated the summary of D15438: Support params in report queries.
Sep 13 2018, 4:50 PM · KEXI
piggz committed R71:c746a52256a5: Merge remote-tracking branch 'origin/3.1' (authored by piggz).
Merge remote-tracking branch 'origin/3.1'
Sep 13 2018, 4:19 PM
piggz closed D15438: Support params in report queries.
Sep 13 2018, 4:19 PM · KEXI
piggz committed R71:02dd7b6c47fc: Move asking for paramters to open() instead of getSchema() (authored by piggz).
Move asking for paramters to open() instead of getSchema()
Sep 13 2018, 4:06 PM
piggz committed R71:719ee0c4ef06: Support params in report queries (authored by piggz).
Support params in report queries
Sep 13 2018, 4:06 PM

Sep 12 2018

piggz created T9668: Rename 'Edit' label.
Sep 12 2018, 8:25 PM · KEXI
piggz updated the diff for D15438: Support params in report queries.

Move paramter fetching to open() from getSchema()

Sep 12 2018, 8:14 PM · KEXI
piggz added a comment to D15438: Support params in report queries.

Out of interest, how can I use arc to update my local branch with your changes?

Sep 12 2018, 6:19 AM · KEXI

Sep 11 2018

piggz updated the summary of D15438: Support params in report queries.
Sep 11 2018, 9:27 PM · KEXI
piggz updated the summary of D15438: Support params in report queries.
Sep 11 2018, 9:23 PM · KEXI
piggz requested review of D15438: Support params in report queries.
Sep 11 2018, 9:22 PM · KEXI

Sep 10 2018

piggz added reviewers for D15414: use libkeepalive to wakeup daemon: KDE Connect, nicolasfella, albertvaka.
Sep 10 2018, 7:31 PM · KDE Connect
piggz requested review of D15414: use libkeepalive to wakeup daemon.
Sep 10 2018, 7:26 PM · KDE Connect

Aug 30 2018

piggz accepted D14486: Update to current mdbtools.
Aug 30 2018, 5:27 PM · KEXI

Aug 29 2018

piggz added a comment to D15102: Update deprecated QAbstractItemModel::reset() to use {begin,end}ResetModel() instead.

@dcaliste by my count there are atleast 3 apps using kf5 libs now, calligra, my watch client app and my kdeconnect port. there has/to be scope for sharing effort :) ive just been shiping the libs in openrepos with the apps

Aug 29 2018, 4:40 PM · Calligra: 3.0
piggz added a comment to D15102: Update deprecated QAbstractItemModel::reset() to use {begin,end}ResetModel() instead.

nice, btw, i have a kf5 repo on the mer obs where i build kf5 libs for sailfish...perhaps that is easier for you? i use them in a few sfos apps, even kdb! my version is 5.31 atm .... is 5.34 the last version to build with qt5.6? i could never find the archives as theyve disappeared from the kde servers, unless im misteken.

Aug 29 2018, 3:49 PM · Calligra: 3.0
piggz accepted D14402: Make certain views work in User mode.
Aug 29 2018, 6:55 AM · KEXI

Aug 26 2018

piggz committed R224:064b07c0ce8a: Fixup the sfos mpris control (authored by piggz).
Fixup the sfos mpris control
Aug 26 2018, 8:38 PM
piggz closed D14568: Fixup the sfos mpris control.
Aug 26 2018, 8:38 PM · KDE Connect

Aug 3 2018

piggz added a reviewer for D14568: Fixup the sfos mpris control: kossebau.
Aug 3 2018, 9:49 PM · KDE Connect
piggz updated the diff for D14568: Fixup the sfos mpris control.
  • Enable mpriscontrol also on sailfish
  • Add features from kde app mpris control and use QtQuick Layouts
  • Add layouts to .spec
Aug 3 2018, 9:48 PM · KDE Connect
piggz added inline comments to D14568: Fixup the sfos mpris control.
Aug 3 2018, 11:26 AM · KDE Connect
piggz added inline comments to D14568: Fixup the sfos mpris control.
Aug 3 2018, 6:15 AM · KDE Connect

Aug 2 2018

piggz added reviewers for D14568: Fixup the sfos mpris control: KDE Connect, nicolasfella.
Aug 2 2018, 10:03 PM · KDE Connect
piggz requested review of D14568: Fixup the sfos mpris control.
Aug 2 2018, 10:02 PM · KDE Connect
piggz accepted D14567: Move declarativeplugin to top-level dir.

built and tested ok on sfos

Aug 2 2018, 9:33 PM · KDE Connect
piggz accepted D3983: Make Calligra unstable (master) depend on stable kreport and kproperty components.

lgtm

Aug 2 2018, 9:05 PM · Calligra: 3.0
piggz committed R224:8b93395128a5: Fix building tests (authored by piggz).
Fix building tests
Aug 2 2018, 8:06 PM
piggz committed R224:9a8f1b48a0c8: Build kdeconnect on sailfish and port some simple plugins (authored by piggz).
Build kdeconnect on sailfish and port some simple plugins
Aug 2 2018, 7:11 PM
piggz closed D10703: Build kdeconnect on sailfish and port some simple plugins.
Aug 2 2018, 7:11 PM · KDE Connect

Aug 1 2018

piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Reverted the unnecessary change to daemon/CMakeLists.txt which came about as part of the merge. Hope all ok now.

Aug 1 2018, 9:17 PM · KDE Connect
piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Remove unnescessary change
Aug 1 2018, 9:15 PM · KDE Connect

Jul 31 2018

piggz added a comment to D14486: Update to current mdbtools.

A few questions, in the interest of keeping our downastream happy, and potentially reducing our burden

  1. do we carry patches ontop of mdb?
  2. how much work would be neded in adding a switch to use the system lib? --I know this would initially be a little work, but could allow a phased approach to using the system supplied lib over time, as packagers choose. If after 1-2 years, all packagers are onboard, we could then make it the default and remove our version of mdb, and the need to maintain it.

Thanks for stepping up Adam. I am not sure if:

  1. mdbtools carries version information .
  2. It even does not maintain cmake module.

    This work is needed in mdbtools itself. And we have no evidence there's any other consumer apart of KEXI that uses mdbtools via cmake.

    If above bits are supplied and maintained, we could allow exact version of "system" mdbtools. Exact because it's the only one I test.

    IMHO it's more effort and risk than benefit, from history I remember that distros can:
  3. skip mdbtools if we set it optional -> KEXI lacks major feature
  4. skip KEXI if we set mdbtools required -> KEXI disappears from the distro at least for some time, for packagers it's "just" one release less

    Because I am all for seeing any contributions please go ahead to discuss[*] and contribute 1. and 2., then we can have opt-in "system" mdbtools support. We would keep mdbtools mandatory (as long as glib and iconv is present).

    Discuss[*]: your challenge would be that mdbtools is consisted of things orthogonal to MDB support KEXI needs: importer tool, exporter tool, SQL support. Whether that project will let you contribute just cmake files for the MDB C API for the read support is not clear. So there may be more work than KEXI needs.
Jul 31 2018, 12:08 PM · KEXI
piggz added a comment to D14486: Update to current mdbtools.
In D14486#300962, @pino wrote:
In D14486#300951, @pino wrote:

so your is proposal correct but of a very low priority for me.

Considering somebody else other than you invested their time in updating the embedded copy [...]

Sorry, I have to stand corrected by myself: you were the one doing this update. OTOH, the rest of my message still stands.

Of course this shall be a member of KEXI project because mdbtools is not a general purpose solution designed to plug to other GUI apps so easily. It's consisted of set of command line tools (they are always hard to integrate with a front end in other than naive way) or has some hard coded GUI, plus C APIs for all these needs exposed in one relevant header file. API stability through the fact that the header rarely changes is accidental.

Disclaimer: mdbtools is one of best reverse engineering projects I know and one of most important to me. Reverse engineering is the core of it, the rest is "just" necessary thing IMHO.

I can assure you that updating mdbtools, unlike sqlite (which is just big enough that it is fine grained and more general purpose), needs to be performed patch-by-patch. Long ago it was the same story with SQLite (version 2 vs 3, breaking compatibility after 3.0, and so on). Since then sqlite is used on every mobile phone and mdbtools is used, you know how frequently.

It's not just a separate situation. I can recall the story of issues that Okular had with (IIRC?) PDF backends. Or Krita with touch input device support in Qt. These projects were not even able to fork the dependencies, I guess mainly because of the size but number of workarounds added was noticeable. Of course we do not argue that forking or embedding is not a really unclean solution, but it's not true that it's not happening, just like it's not true that there are thousands of projects that use years old compilers.

Here in keximdb nothing changes for you as package author, right? When this patch gets integrated into KEXI there is the same situation from the packages' POV as you it was years ago.

If otherwise I just delegated the risk and testing to users (not packagers, since as we know they do not have just one project to support and are rather project-agnostic) it isn't impossible that packagers would have to know that we request version 0.7.1 supported and not >=0.7.2 for some compatibility or "exceptional" reason. I can't imagine how this contract can be assured distro-independently with tool we have not which is just a plain README file and so limited developer workforce. It's possible that users will have KEXI 3.1 running on their desktop 4 years later and mdbtools package completely unknown to us. Part of the issue come from the fact that we reserve right to use mdbtools not the way it was designed, to get all kind of instrumentation we need.

Jokes: I do not know how it is possible that chromium or Libreoffice or Firefox is packaged as larger monolytic packages (they both contain lots of unrelated tech compiled together). Or MySQL. Why the MySQL parser is not separate package so I can use it...

Jul 31 2018, 11:06 AM · KEXI

Jul 23 2018

piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

The diff contains a few unrelated changes, please remove them and do them in another commit if it seems necessary to you.
Looks quite good to me, but I can't test anything in regard to sailfish.
We already have a QML/Kirigami app in the app/ folder for e.g. Plasma Mobile. Can we use that one instead of creating a new one for SFOS?

Jul 23 2018, 8:13 PM · KDE Connect
piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Fix removed plugin
Jul 23 2018, 8:12 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Please note, the main change here is renaming the .json file, for the sendnotification plugin to .json.in, and using cmake to process the file

Jul 23 2018, 7:19 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Addressed remaining comments

Jul 23 2018, 7:17 PM · KDE Connect
piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Address review comments
  • Move rpm folder
  • Remove test code
  • Fix icon
  • Improve cover item
  • Move sailfishdaemon to seperate file
  • Port battery plugin to sailfish
  • Copy qascont from qt 5.7
  • Properly build the declarative plugin
  • Address review comments
  • Remove unnescessary changes
  • Add features to app
  • Tidy up plugin items
  • Add rpm files for sailfish
  • Merge branch 'pgz-sfos-initial' of https://github.com/piggz/kdeconnect-kde into pgz-sfos-initial
  • Cleanups
  • Build fixes
  • Dont use a seperate json file for sailfish
  • no need to check version as it is done in the header
  • Merge branch 'master' into pgz-sfos-initial
  • Merge remote-tracking branch 'origin/master' into pgz-sfos-initial
Jul 23 2018, 7:14 PM · KDE Connect

Jun 14 2018

piggz accepted D13472: Fix input of large unsigned int values (>0x7FFFFFFF).
Jun 14 2018, 9:06 PM · KDb
piggz accepted D13451: Zero values are not displayed in integer columns.
Jun 14 2018, 9:05 PM · KEXI
piggz accepted D13473: Fix validation of values in default input box of table view.
Jun 14 2018, 9:04 PM · KEXI

Jun 9 2018

piggz accepted D13448: SQLite Fix loading value Incorrect display of large unsigned int (>0x7FFFFFFF).
Jun 9 2018, 9:41 PM · KDb
piggz added a comment to D13448: SQLite Fix loading value Incorrect display of large unsigned int (>0x7FFFFFFF).

Other drivers affected?

Jun 9 2018, 9:38 PM · KDb

May 16 2018

piggz accepted D11549: Skip table name if physical table is non-existing, use the new tableNames API in migration.
May 16 2018, 6:20 AM · KEXI
piggz accepted D11778: Cool main window for KEXI 3.2.

Should get into master for stability testing before 3.2

May 16 2018, 6:18 AM · KEXI
piggz accepted D12873: Fix handling ORDER BY part of queries.

Surprising how many changes for one crash!

May 16 2018, 6:16 AM · KDb
piggz accepted D12868: Fix crash in data fetching and aggregation scripts in reports.
May 16 2018, 6:10 AM · KEXI

May 14 2018

piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Ping? It needs to be rebased to current master and then I think it can go in

May 14 2018, 6:08 AM · KDE Connect

Apr 3 2018

piggz added a comment to D11549: Skip table name if physical table is non-existing, use the new tableNames API in migration.

Should we clean up the internal schema of non existing tables? Options would be automatic or prompt to user. Other consideration is other objects referring to non-existing tables like reports and queries.

Apr 3 2018, 6:22 AM · KEXI
piggz accepted D11547: Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables.
Apr 3 2018, 6:18 AM · KDb
piggz accepted D10996: Make KEXI compile for MOBILE productset.
Apr 3 2018, 6:11 AM · KEXI

Mar 27 2018

piggz added inline comments to D10703: Build kdeconnect on sailfish and port some simple plugins.
Mar 27 2018, 5:41 PM · KDE Connect

Mar 23 2018

piggz added inline comments to D11547: Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables.
Mar 23 2018, 10:01 PM · KDb
piggz added inline comments to D11547: Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables.
Mar 23 2018, 8:00 PM · KDb

Mar 21 2018

piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Feel free, you'll have to implement the simple notification method in the Damon.

Mar 21 2018, 4:06 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

its not on obs yet. there is a spec in an earlier version of the diff, also take a look on my github maybe

Mar 21 2018, 2:06 PM · KDE Connect

Mar 17 2018

piggz added a comment to D11104: Add a method for creating simple notifications.

I dont have permission to land this (unless ive got something misconfigured locally) could someone else, or check if I do have access?

Mar 17 2018, 8:23 PM

Mar 8 2018

piggz updated the diff for D11104: Add a method for creating simple notifications.
  • Address comments.
Mar 8 2018, 6:02 PM

Mar 6 2018

piggz requested review of D11104: Add a method for creating simple notifications.
Mar 6 2018, 10:06 PM

Mar 5 2018

piggz accepted D11000: Add MainWindow/GlobalSearchBoxEnabled (bool) option that controls display of the global search box.
Mar 5 2018, 6:08 PM · KEXI

Mar 4 2018

piggz added inline comments to D10703: Build kdeconnect on sailfish and port some simple plugins.
Mar 4 2018, 9:33 AM · KDE Connect
piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Address review comments
  • Remove unnescessary changes
Mar 4 2018, 9:30 AM · KDE Connect

Mar 3 2018

piggz added inline comments to D10703: Build kdeconnect on sailfish and port some simple plugins.
Mar 3 2018, 10:14 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

I got some build errors, which I've added a comment for.

Nice to see KDE Connect spreading to a different platform. Do you have some screenshots?

Mar 3 2018, 7:43 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

@nicolasfella Thanks for pointing me to this. Happyness++

@piggz Hi :) By pure chance some hours before I came across https://github.com/R1tschY/harbour-sailfishconnect, is this some duplicated effort possibly or how does this relate? (no clue yet about KDE Connect details)

Can you give some build instructions? Seeing set(KF5_REQUIRED_COMPONENTS I18n DBusAddons CoreAddons), so not just using plain Qt, my old MarbleMaps@SailfishOS knowledge might not be sufficient :)

Happy to help out soon at least when it comes to MPRIS stuff (given master plan hinted to in D10972)

Mar 3 2018, 7:41 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Guys, whats your thoughts about this?

Mar 3 2018, 9:16 AM · KDE Connect
piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Use qasconst.h in notification listener
Mar 3 2018, 9:10 AM · KDE Connect
piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Properly build the declarative plugin
Mar 3 2018, 9:05 AM · KDE Connect
piggz accepted D10963: Fix crash when global search box is used after re-opening another project.
Mar 3 2018, 8:13 AM · KEXI

Mar 1 2018

piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Copy qasconst from qt 5.7
Mar 1 2018, 10:12 PM · KDE Connect
piggz accepted D10780: Kexi -> KEXI globally, KEXI_APP_NAME -> QApplication::applicationDisplayName().

One thing, in the home/start page, it says 'You in Kexi Project'

Mar 1 2018, 9:44 PM · KEXI

Feb 27 2018

piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Port battery plugin to sailfish
  • Port the sendnotifications plugin
  • Add all the experimatal app plugins
Feb 27 2018, 9:08 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Do you guys know why the sendnotifications plugin wouldn't get loaded at runtime? I'll do some debugging in the plugin loader, but my phone advertises kdeconnect.notification and my computer has the receivenotification plugin loaded, but something in the loader is causing it to be missed I think.

I don't know, unfortunately. Setting a breakpoint in PluginFactory.java:208 should help with debugging, though.

Are you on irc at all?

I didn't even know we had irc 😋

Its not in the android app, its the C++/KDE project compiled for Sailfish, so im looking in pluginloader::pluginsForCapabilities

Feb 27 2018, 7:24 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Do you guys know why the sendnotifications plugin wouldn't get loaded at runtime? I'll do some debugging in the plugin loader, but my phone advertises kdeconnect.notification and my computer has the receivenotification plugin loaded, but something in the loader is causing it to be missed I think.

I don't know, unfortunately. Setting a breakpoint in PluginFactory.java:208 should help with debugging, though.

Are you on irc at all?

I didn't even know we had irc 😋

Feb 27 2018, 6:18 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Do you guys know why the sendnotifications plugin wouldn't get loaded at runtime? I'll do some debugging in the plugin loader, but my phone advertises kdeconnect.notification and my computer has the receivenotification plugin loaded, but something in the loader is causing it to be missed I think.

Feb 27 2018, 4:12 PM · KDE Connect

Feb 24 2018

piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Improve cover item
  • Move sailfishdaemon to seperate file
Feb 24 2018, 10:07 PM · KDE Connect
piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Address review comments
  • Move rpm folder
  • Add ping notification
  • Remove test code
  • Fix icon
Feb 24 2018, 8:44 PM · KDE Connect
piggz added a comment to D10780: Kexi -> KEXI globally, KEXI_APP_NAME -> QApplication::applicationDisplayName().

Why?

Feb 24 2018, 4:59 PM · KEXI

Feb 21 2018

piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Ive got a bit to do, be prepared for a rev 2.

Feb 21 2018, 4:55 PM · KDE Connect
piggz added a reviewer for D10703: Build kdeconnect on sailfish and port some simple plugins: KDE Connect.
Feb 21 2018, 12:00 AM · KDE Connect

Feb 20 2018

piggz requested review of D10703: Build kdeconnect on sailfish and port some simple plugins.
Feb 20 2018, 11:59 PM · KDE Connect

Feb 17 2018

piggz accepted D10565: Make KEXI examples be built and installed by default as it's likely expected by users.
Feb 17 2018, 8:58 PM · KEXI

Feb 5 2018

piggz accepted D10254: Prepare KDb for release wrt versioning, dependencies and docs.
Feb 5 2018, 10:15 PM · KDb

Jan 30 2018

piggz committed R71:a31f87c72a74: Add social buttons to Kexi menu (authored by piggz).
Add social buttons to Kexi menu
Jan 30 2018, 9:10 PM
piggz closed D10194: Add social buttons to Kexi menu.
Jan 30 2018, 9:10 PM · KEXI
piggz added a revision to T7833: Add twitter and facebook icons to the KEXI menu: D10194: Add social buttons to Kexi menu.
Jan 30 2018, 7:57 PM · KEXI
piggz added a comment to T7833: Add twitter and facebook icons to the KEXI menu.

Can we use CC or PD logos?
https://commons.wikimedia.org/wiki/File:Twitter_icon.png
Public domain https://commons.wikimedia.org/wiki/Category:Facebook#/media/File:F_icon.svg

Jan 30 2018, 6:40 PM · KEXI
piggz added a comment to T7833: Add twitter and facebook icons to the KEXI menu.

What are the kde/debian rules for such things?

Jan 30 2018, 6:32 PM · KEXI

Jan 19 2018

piggz committed R14:34b46e7f7358: Remove unnescessary member (authored by piggz).
Remove unnescessary member
Jan 19 2018, 10:19 PM
piggz committed R14:df4177c0accf: Notify document when async item is rendered (authored by piggz).
Notify document when async item is rendered
Jan 19 2018, 10:19 PM
piggz closed D9933: Notify document when async item is rendered.
Jan 19 2018, 10:19 PM · KReport
piggz accepted D9940: Fix memory management for internal Completer of the combo box editor (when extraValueAllowed=true).
Jan 19 2018, 7:48 PM · KProperty
piggz added a comment to D9940: Fix memory management for internal Completer of the combo box editor (when extraValueAllowed=true).

Just to confirm the existence of the completer doesnt prevent manual entry?

Jan 19 2018, 5:46 PM · KProperty
piggz accepted D9941: Simplify handling item-data-source property in elements.
Jan 19 2018, 5:38 PM · KReport