piggz (Adam Pigg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
May 28 2015, 6:39 PM (160 w, 2 d)
Availability
Available

Recent Activity

Thu, Jun 14

piggz accepted D13472: Fix input of large unsigned int values (>0x7FFFFFFF).
Thu, Jun 14, 9:06 PM · KDb
piggz accepted D13451: Zero values are not displayed in integer columns.
Thu, Jun 14, 9:05 PM · KEXI
piggz accepted D13473: Fix validation of values in default input box of table view.
Thu, Jun 14, 9:04 PM · KEXI

Sat, Jun 9

piggz accepted D13448: SQLite Fix loading value Incorrect display of large unsigned int (>0x7FFFFFFF).
Sat, Jun 9, 9:41 PM · KDb
piggz added a comment to D13448: SQLite Fix loading value Incorrect display of large unsigned int (>0x7FFFFFFF).

Other drivers affected?

Sat, Jun 9, 9:38 PM · KDb

May 16 2018

piggz accepted D11549: Skip table name if physical table is non-existing, use the new tableNames API in migration.
May 16 2018, 6:20 AM · KEXI
piggz accepted D11778: Cool main window for KEXI 3.2.

Should get into master for stability testing before 3.2

May 16 2018, 6:18 AM · KEXI
piggz accepted D12873: Fix handling ORDER BY part of queries.

Surprising how many changes for one crash!

May 16 2018, 6:16 AM · KDb
piggz accepted D12868: Fix crash in data fetching and aggregation scripts in reports.
May 16 2018, 6:10 AM · KEXI

May 14 2018

piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Ping? It needs to be rebased to current master and then I think it can go in

May 14 2018, 6:08 AM · KDE Connect

Apr 3 2018

piggz added a comment to D11549: Skip table name if physical table is non-existing, use the new tableNames API in migration.

Should we clean up the internal schema of non existing tables? Options would be automatic or prompt to user. Other consideration is other objects referring to non-existing tables like reports and queries.

Apr 3 2018, 6:22 AM · KEXI
piggz accepted D11547: Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables.
Apr 3 2018, 6:18 AM · KDb
piggz accepted D10996: Make KEXI compile for MOBILE productset.
Apr 3 2018, 6:11 AM · KEXI

Mar 27 2018

piggz added inline comments to D10703: Build kdeconnect on sailfish and port some simple plugins.
Mar 27 2018, 5:41 PM · KDE Connect

Mar 23 2018

piggz added inline comments to D11547: Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables.
Mar 23 2018, 10:01 PM · KDb
piggz added inline comments to D11547: Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables.
Mar 23 2018, 8:00 PM · KDb

Mar 21 2018

piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Feel free, you'll have to implement the simple notification method in the Damon.

Mar 21 2018, 4:06 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

its not on obs yet. there is a spec in an earlier version of the diff, also take a look on my github maybe

Mar 21 2018, 2:06 PM · KDE Connect

Mar 17 2018

piggz added a comment to D11104: Add a method for creating simple notifications.

I dont have permission to land this (unless ive got something misconfigured locally) could someone else, or check if I do have access?

Mar 17 2018, 8:23 PM

Mar 8 2018

piggz updated the diff for D11104: Add a method for creating simple notifications.
  • Address comments.
Mar 8 2018, 6:02 PM

Mar 6 2018

piggz requested review of D11104: Add a method for creating simple notifications.
Mar 6 2018, 10:06 PM

Mar 5 2018

piggz accepted D11000: Add MainWindow/GlobalSearchBoxEnabled (bool) option that controls display of the global search box.
Mar 5 2018, 6:08 PM · KEXI

Mar 4 2018

piggz added inline comments to D10703: Build kdeconnect on sailfish and port some simple plugins.
Mar 4 2018, 9:33 AM · KDE Connect
piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Address review comments
  • Remove unnescessary changes
Mar 4 2018, 9:30 AM · KDE Connect

Mar 3 2018

piggz added inline comments to D10703: Build kdeconnect on sailfish and port some simple plugins.
Mar 3 2018, 10:14 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

I got some build errors, which I've added a comment for.

Nice to see KDE Connect spreading to a different platform. Do you have some screenshots?

Mar 3 2018, 7:43 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

@nicolasfella Thanks for pointing me to this. Happyness++

@piggz Hi :) By pure chance some hours before I came across https://github.com/R1tschY/harbour-sailfishconnect, is this some duplicated effort possibly or how does this relate? (no clue yet about KDE Connect details)

Can you give some build instructions? Seeing set(KF5_REQUIRED_COMPONENTS I18n DBusAddons CoreAddons), so not just using plain Qt, my old MarbleMaps@SailfishOS knowledge might not be sufficient :)

Happy to help out soon at least when it comes to MPRIS stuff (given master plan hinted to in D10972)

Mar 3 2018, 7:41 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Guys, whats your thoughts about this?

Mar 3 2018, 9:16 AM · KDE Connect
piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Use qasconst.h in notification listener
Mar 3 2018, 9:10 AM · KDE Connect
piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Properly build the declarative plugin
Mar 3 2018, 9:05 AM · KDE Connect
piggz accepted D10963: Fix crash when global search box is used after re-opening another project.
Mar 3 2018, 8:13 AM · KEXI

Mar 1 2018

piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Copy qasconst from qt 5.7
Mar 1 2018, 10:12 PM · KDE Connect
piggz accepted D10780: Kexi -> KEXI globally, KEXI_APP_NAME -> QApplication::applicationDisplayName().

One thing, in the home/start page, it says 'You in Kexi Project'

Mar 1 2018, 9:44 PM · KEXI

Feb 27 2018

piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Port battery plugin to sailfish
  • Port the sendnotifications plugin
  • Add all the experimatal app plugins
Feb 27 2018, 9:08 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Do you guys know why the sendnotifications plugin wouldn't get loaded at runtime? I'll do some debugging in the plugin loader, but my phone advertises kdeconnect.notification and my computer has the receivenotification plugin loaded, but something in the loader is causing it to be missed I think.

I don't know, unfortunately. Setting a breakpoint in PluginFactory.java:208 should help with debugging, though.

Are you on irc at all?

I didn't even know we had irc 😋

Its not in the android app, its the C++/KDE project compiled for Sailfish, so im looking in pluginloader::pluginsForCapabilities

Feb 27 2018, 7:24 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Do you guys know why the sendnotifications plugin wouldn't get loaded at runtime? I'll do some debugging in the plugin loader, but my phone advertises kdeconnect.notification and my computer has the receivenotification plugin loaded, but something in the loader is causing it to be missed I think.

I don't know, unfortunately. Setting a breakpoint in PluginFactory.java:208 should help with debugging, though.

Are you on irc at all?

I didn't even know we had irc 😋

Feb 27 2018, 6:18 PM · KDE Connect
piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Do you guys know why the sendnotifications plugin wouldn't get loaded at runtime? I'll do some debugging in the plugin loader, but my phone advertises kdeconnect.notification and my computer has the receivenotification plugin loaded, but something in the loader is causing it to be missed I think.

Feb 27 2018, 4:12 PM · KDE Connect

Feb 24 2018

piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Improve cover item
  • Move sailfishdaemon to seperate file
Feb 24 2018, 10:07 PM · KDE Connect
piggz updated the diff for D10703: Build kdeconnect on sailfish and port some simple plugins.
  • Address review comments
  • Move rpm folder
  • Add ping notification
  • Remove test code
  • Fix icon
Feb 24 2018, 8:44 PM · KDE Connect
piggz added a comment to D10780: Kexi -> KEXI globally, KEXI_APP_NAME -> QApplication::applicationDisplayName().

Why?

Feb 24 2018, 4:59 PM · KEXI

Feb 21 2018

piggz added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Ive got a bit to do, be prepared for a rev 2.

Feb 21 2018, 4:55 PM · KDE Connect
piggz added a reviewer for D10703: Build kdeconnect on sailfish and port some simple plugins: KDE Connect.
Feb 21 2018, 12:00 AM · KDE Connect

Feb 20 2018

piggz requested review of D10703: Build kdeconnect on sailfish and port some simple plugins.
Feb 20 2018, 11:59 PM · KDE Connect

Feb 17 2018

piggz accepted D10565: Make KEXI examples be built and installed by default as it's likely expected by users.
Feb 17 2018, 8:58 PM · KEXI

Feb 5 2018

piggz accepted D10254: Prepare KDb for release wrt versioning, dependencies and docs.
Feb 5 2018, 10:15 PM · KDb

Jan 30 2018

piggz committed R71:a31f87c72a74: Add social buttons to Kexi menu (authored by piggz).
Add social buttons to Kexi menu
Jan 30 2018, 9:10 PM
piggz closed D10194: Add social buttons to Kexi menu.
Jan 30 2018, 9:10 PM · KEXI
piggz added a revision to T7833: Add twitter and facebook icons to the KEXI menu: D10194: Add social buttons to Kexi menu.
Jan 30 2018, 7:57 PM · KEXI
piggz added a comment to T7833: Add twitter and facebook icons to the KEXI menu.

Can we use CC or PD logos?
https://commons.wikimedia.org/wiki/File:Twitter_icon.png
Public domain https://commons.wikimedia.org/wiki/Category:Facebook#/media/File:F_icon.svg

Jan 30 2018, 6:40 PM · KEXI
piggz added a comment to T7833: Add twitter and facebook icons to the KEXI menu.

What are the kde/debian rules for such things?

Jan 30 2018, 6:32 PM · KEXI

Jan 19 2018

piggz committed R14:34b46e7f7358: Remove unnescessary member (authored by piggz).
Remove unnescessary member
Jan 19 2018, 10:19 PM
piggz committed R14:df4177c0accf: Notify document when async item is rendered (authored by piggz).
Notify document when async item is rendered
Jan 19 2018, 10:19 PM
piggz closed D9933: Notify document when async item is rendered.
Jan 19 2018, 10:19 PM · KReport
piggz accepted D9940: Fix memory management for internal Completer of the combo box editor (when extraValueAllowed=true).
Jan 19 2018, 7:48 PM · KProperty
piggz added a comment to D9940: Fix memory management for internal Completer of the combo box editor (when extraValueAllowed=true).

Just to confirm the existence of the completer doesnt prevent manual entry?

Jan 19 2018, 5:46 PM · KProperty
piggz accepted D9941: Simplify handling item-data-source property in elements.
Jan 19 2018, 5:38 PM · KReport
piggz accepted D1092: Switch to Qt Resource-based icon theme for Kexi with breeze as cross-platform default.
Jan 19 2018, 5:36 PM · KEXI

Jan 18 2018

piggz added a comment to D9941: Simplify handling item-data-source property in elements.

eg, field datasource can contain =<Complex js > or $<literal string>

Jan 18 2018, 8:01 AM · KReport

Jan 17 2018

piggz added a comment to D9941: Simplify handling item-data-source property in elements.

Not all item types allow 'extra value' to be specified for the data source. Are you happy allowing the property for all item types?

Jan 17 2018, 9:18 PM · KReport

Jan 15 2018

piggz accepted D9893: Add d-pointer to KReportSectionData and clean up the API and export it.
Jan 15 2018, 8:20 PM · KReport
piggz added inline comments to D6758: API: Add more enum classes.
Jan 15 2018, 6:01 PM · KReport

Jan 11 2018

piggz created T7739: Brainstorm ideas for making Kexi Quick friendly.
Jan 11 2018, 5:03 PM · KEXI
piggz accepted D9409: Fixes for query designers and query data view(logic, memory and stability fixes).
Jan 11 2018, 8:00 AM · KEXI
piggz accepted D9410: Fixes related to constructing and handling queries.
Jan 11 2018, 7:50 AM · KDb
piggz accepted D9771: Properly unregister table from listeners before dropping.
Jan 11 2018, 7:43 AM · KDb

Jan 3 2018

piggz added a comment to D9410: Fixes related to constructing and handling queries.

Is it possible to add some tests for the query strings that would be impacted by this?

Jan 3 2018, 10:10 PM · KDb

Jan 2 2018

piggz accepted D8117: Expand scope of KDbTableSchemaChangeListener to allow registering queries for changes in table schema.
Jan 2 2018, 8:33 PM · KDb
piggz accepted D8118: Before physical altering or deleting table ask the user to close depending table/query/report/form.
Jan 2 2018, 8:31 PM · KEXI

Dec 19 2017

piggz committed R14:152e9e3113e0: Add brief docs for exported classes (authored by piggz).
Add brief docs for exported classes
Dec 19 2017, 6:45 AM
piggz closed D9401: Add brief docs for exported classes.
Dec 19 2017, 6:45 AM · KReport

Dec 18 2017

piggz moved T6897: Add at least brief docs to public classes from TODO 3.1 to In Progress on the KReport board.
Dec 18 2017, 9:51 PM · KReport
piggz updated the diff for D9401: Add brief docs for exported classes.
  • addres comments
Dec 18 2017, 9:48 PM · KReport
piggz created D9401: Add brief docs for exported classes.
Dec 18 2017, 8:54 PM · KReport

Nov 1 2017

piggz added a comment to D8118: Before physical altering or deleting table ask the user to close depending table/query/report/form.

Got following crash, when renaming the same field twice

Nov 1 2017, 11:32 PM · KEXI

Oct 30 2017

piggz closed T6855: Add more page sizes as Resolved.
Oct 30 2017, 11:28 PM · KReport
piggz committed R14:3eb3ec6ff7b4: Add additional page sizes (authored by piggz).
Add additional page sizes
Oct 30 2017, 11:28 PM
piggz closed D8559: Add additional page sizes.
Oct 30 2017, 11:28 PM · KReport
piggz updated the diff for D8559: Add additional page sizes.
  • Re-order and andd envelope sizes
Oct 30 2017, 10:24 PM · KReport
piggz added a revision to T6855: Add more page sizes: D8559: Add additional page sizes.
Oct 30 2017, 6:54 PM · KReport
piggz created D8559: Add additional page sizes.
Oct 30 2017, 6:54 PM · KReport
piggz added a comment to T7088: Crash when moving splitter of report's property editor.

I cant reproduce this, is it fixed for you?

Oct 30 2017, 6:19 PM · KEXI, KReport
piggz closed T6559: 3.1: Use suffix option from the new KProperty instead of units; implement units locally in KReport as Resolved.
Oct 30 2017, 6:16 PM · KReport
piggz committed R14:9bd89ac9750b: Use suffix option from the new KProperty instead of units; implement units… (authored by piggz).
Use suffix option from the new KProperty instead of units; implement units…
Oct 30 2017, 6:15 PM
piggz closed D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.
Oct 30 2017, 6:15 PM · KReport
piggz added a comment to D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.

You are happy with 5.x?

Oct 30 2017, 5:23 PM · KReport

Oct 29 2017

piggz accepted D8518: Improve initialization of properties in Report Designer.
Oct 29 2017, 11:31 PM · KReport
piggz added a comment to D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.

could you confirm if 5.3.1 -> 5.3.4 are possible?

Oct 29 2017, 8:14 PM · KReport
piggz updated the diff for D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.
  • Calculate sensible maximums for margin sizes
Oct 29 2017, 7:03 PM · KReport

Oct 25 2017

piggz added a comment to D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.

What do you think is a sensible max for margins? a % of the width/height? or some complex calculation involving calculating the size of the page and opposite margin?

Oct 25 2017, 8:58 PM · KReport
piggz added a comment to D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.
  1. If 0.00 value is entered it disappears in the prop. editor when moving focus to another editor. Data is saved though. Expected: 0.00 is visible. Example for margins:



    This may or not be related to the KProperty libs and as such can belong to me :)
Oct 25 2017, 8:52 PM · KReport

Oct 22 2017

piggz added a comment to D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.
  1. If 0.00 value is entered it disappears in the prop. editor when moving focus to another editor. Data is saved though. Expected: 0.00 is visible. Example for margins:



    This may or not be related to the KProperty libs and as such can belong to me :)
Oct 22 2017, 8:53 AM · KReport
piggz added a comment to D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.

Note, I cannot reproduce 7.3. Scrolling mouse over grididivsions works as expected.

Oct 22 2017, 8:45 AM · KReport
piggz updated the diff for D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.
  • Set min/max values for grid divisions
Oct 22 2017, 8:44 AM · KReport

Oct 20 2017

piggz updated the diff for D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.
  • Fix dynamic redraw of background. Resolved issue 4.1 and 5.1
Oct 20 2017, 9:58 PM · KReport

Oct 14 2017

piggz added a comment to D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.

these issues explain the call to slotResizeBarDragged(0) ... need to find a fix wthout introducing it ... calling update() doesnt cause a resize to happen

Oct 14 2017, 6:34 PM · KReport

Sep 26 2017

piggz updated the diff for D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.
  • Fix section changing height when untis changed
Sep 26 2017, 7:48 PM · KReport
piggz updated the diff for D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.
  • Fix custom page size handling when changing units

Fixes 2.2

Sep 26 2017, 7:19 PM · KReport

Sep 24 2017

piggz added a comment to D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.

fixed 2.1 and 2.3

Sep 24 2017, 8:44 PM · KReport
piggz updated the diff for D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.
  • Fix items dissapearing
Sep 24 2017, 8:38 AM · KReport

Sep 6 2017

piggz updated the diff for D5441: Use suffix option from the new KProperty instead of units; implement units locally in KReport.
  • Convert margins correctly when calculating page width
Sep 6 2017, 4:02 PM · KReport