Add a method for creating simple notifications

Authored by piggz on Mar 6 2018, 10:06 PM.



Add a helper function to the daemon interface, which must be subclassed
by the implementations, which creates a simple notification.

For more complex needs, involving interacting with the notification, it
will still be nescessary to use KNotification directly, but this allows
for other future implementations to create a simple notification without
ifdef'ing the code.

Diff Detail

R224 KDE Connect
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
piggz requested review of this revision.Mar 6 2018, 10:06 PM
piggz created this revision.
apol added a comment.Mar 7 2018, 1:02 AM

Makes a lot of sense to me.

Seems you can remove the CMake parts of these? i.e. not linking to KF5::Notifications and not find_package(KF5Notifications)


use qCDebug.

apol requested changes to this revision.Mar 7 2018, 1:02 AM
This revision now requires changes to proceed.Mar 7 2018, 1:02 AM
piggz updated this revision to Diff 29028.Mar 8 2018, 6:02 PM
piggz marked an inline comment as done.
  • Address comments.
apol accepted this revision.Mar 15 2018, 7:01 PM
This revision is now accepted and ready to land.Mar 15 2018, 7:01 PM
piggz added a comment.Mar 17 2018, 8:23 PM

I dont have permission to land this (unless ive got something misconfigured locally) could someone else, or check if I do have access?

This revision was automatically updated to reflect the committed changes.