staniek (Jarosław Staniek)
Kexi Haxor

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 1:59 PM (267 w, 5 d)
Availability
Available

KEXI KDb KProperty maintainer, founder of the KDE for Windows and Qt for Tizen projects. KReport and #Calligra developer. Qt engineer since 1998. Certified Qt pro.

Recent Activity

Sat, May 30

staniek committed R14:1786fb12c3c0: Support API documentation generation with kapidox (authored by kossebau).
Support API documentation generation with kapidox
Sat, May 30, 5:43 PM
staniek committed R13:9ce78833d607: Support API documentation generation with kapidox (authored by kossebau).
Support API documentation generation with kapidox
Sat, May 30, 5:42 PM

Fri, May 29

staniek added a comment to T3749: Refresh and correct API docs using kapidox.

Great, thanks Friedrich.

Fri, May 29, 3:15 PM · KEXI, KProperty, KReport, KDb

Wed, May 27

staniek added a comment to T3749: Refresh and correct API docs using kapidox.

Hi Freidrich. That's a good news to me!

Wed, May 27, 2:28 PM · KEXI, KProperty, KReport, KDb

Sun, May 17

staniek committed R14:06e0adf9b9db: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Sun, May 17, 10:53 PM
staniek committed R14:08f50ca497c0: Update README.md (add github note and donation) (authored by staniek).
Update README.md (add github note and donation)
Sun, May 17, 10:53 PM
staniek committed R13:ddf92b1ead83: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Sun, May 17, 10:48 PM
staniek committed R13:b2fd144c2d84: Update README.md (add github note and donation) (authored by staniek).
Update README.md (add github note and donation)
Sun, May 17, 10:47 PM
staniek committed R15:52412b0593fe: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Sun, May 17, 10:45 PM
staniek committed R15:3b121c11dd15: Update README.md (add github note and donation) (authored by staniek).
Update README.md (add github note and donation)
Sun, May 17, 10:44 PM
staniek committed R71:2edb69f51897: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Sun, May 17, 10:25 PM
staniek committed R71:9841c022e60b: Update GitHub note in README.md: simpler contact links, add donations (authored by staniek).
Update GitHub note in README.md: simpler contact links, add donations
Sun, May 17, 10:23 PM
staniek closed D28828: Remove automoc warnings when building plugins.
Sun, May 17, 9:19 PM · KReport
staniek committed R14:6ef298ef1320: Remove automoc warnings when building plugins (authored by jfita).
Remove automoc warnings when building plugins
Sun, May 17, 9:19 PM
staniek committed R71:26ebd66e2c0a: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Sun, May 17, 9:12 PM
staniek closed D29804: Fix KI18n’s (I18N_ARGUMENT_MISSING) warnings in migration.
Sun, May 17, 9:12 PM · KEXI
staniek committed R71:ecb7c8fa6c98: Fix KI18n’s (I18N_ARGUMENT_MISSING) warnings in migration (authored by jfita).
Fix KI18n’s (I18N_ARGUMENT_MISSING) warnings in migration
Sun, May 17, 9:08 PM
staniek accepted D29804: Fix KI18n’s (I18N_ARGUMENT_MISSING) warnings in migration.

Good job!

Sun, May 17, 7:59 AM · KEXI

Tue, May 12

staniek requested changes to D29230: Improve KexiRecordNavigator’s scroll wheel sensitivity.
Tue, May 12, 8:15 PM · KEXI

Sun, May 10

staniek committed R15:b64a6248090f: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Sun, May 10, 9:58 PM
staniek closed D29327: Improve a bit parse error diagnosis.
Sun, May 10, 9:57 PM · KDb
staniek committed R15:aa5f06481871: Improve a bit parse error diagnosis (authored by jfita).
Improve a bit parse error diagnosis
Sun, May 10, 9:57 PM
staniek accepted D29327: Improve a bit parse error diagnosis.
Sun, May 10, 9:51 PM · KDb

Sat, May 9

staniek requested changes to D28828: Remove automoc warnings when building plugins.
Sat, May 9, 9:11 PM · KReport
staniek added a comment to D28828: Remove automoc warnings when building plugins.

Nice, but question, would it be possible to use ecm_setup_qtplugin_macro_names() ? https://api.kde.org/ecm/module/ECMSetupQtPluginMacroNames.html

Sat, May 9, 9:10 PM · KReport
staniek requested changes to D29327: Improve a bit parse error diagnosis.
Sat, May 9, 8:54 PM · KDb
staniek added inline comments to D29327: Improve a bit parse error diagnosis.
Sat, May 9, 8:54 PM · KDb

May 3 2020

staniek added a comment to D29244: Show property editor in text view mode too.

Good find!

May 3 2020, 8:47 PM · KEXI
staniek committed R15:098b196f7e7d: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
May 3 2020, 8:30 PM
staniek committed R15:14280f03d408: Escape table name in when building a select statement with row id (authored by jfita).
Escape table name in when building a select statement with row id
May 3 2020, 8:30 PM
staniek closed D29277: Escape table name in when building a select statement with row id.
May 3 2020, 8:25 PM · KDb
staniek accepted D29277: Escape table name in when building a select statement with row id.
May 3 2020, 8:18 PM · KDb
staniek committed R71:a78a953dfd3d: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
May 3 2020, 6:28 PM
staniek closed D29243: Select design or text view mode for new items.
May 3 2020, 6:28 PM · KEXI
staniek committed R71:869b20b73da8: Select design or text view mode for new items (authored by jfita).
Select design or text view mode for new items
May 3 2020, 6:25 PM
staniek accepted D29243: Select design or text view mode for new items.
May 3 2020, 6:25 PM · KEXI
staniek added a comment to D29243: Select design or text view mode for new items.

The fall back to text mode is correct and can help to manage consistency. kexi_scriptplugin.desktop vs kexi_tableplugin.desktop has only X-KDE-ServiceTypes=Kexi/Editor defined.

May 3 2020, 6:23 PM · KEXI
staniek added inline comments to D29327: Improve a bit parse error diagnosis.
May 3 2020, 12:20 PM · KDb

May 2 2020

staniek committed R71:76008d33452c: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
May 2 2020, 11:44 AM
staniek closed D29286: Show error when can not switch to data view for tables.
May 2 2020, 11:44 AM · KEXI
staniek committed R71:3ea593cf0397: Show error when can not switch to data view for tables (authored by jfita).
Show error when can not switch to data view for tables
May 2 2020, 11:43 AM
staniek accepted D29286: Show error when can not switch to data view for tables.

Good job!

May 2 2020, 11:42 AM · KEXI
staniek requested changes to D29327: Improve a bit parse error diagnosis.
May 2 2020, 11:28 AM · KDb

May 1 2020

staniek added inline comments to D29327: Improve a bit parse error diagnosis.
May 1 2020, 10:15 PM · KDb

Apr 29 2020

staniek committed R15:c5d308ef42f5: Merge branch 'master' into 332161-autotests (authored by staniek).
Merge branch 'master' into 332161-autotests
Apr 29 2020, 9:17 PM
staniek added a comment to D29277: Escape table name in when building a select statement with row id.

Entering "select id from [table]" in KEXI SQL editor or passing it to a parser in C++ raises the same parser's error.
In order to reproduce bug you're fixing above one needs to create a queryfully using the C++ API since the parser won't let the to go reserved identifiers through.
(until the #332161 is solved)

Apr 29 2020, 5:46 PM · KDb
staniek added a comment to D29277: Escape table name in when building a select statement with row id.

Another note so we won't forget. Update for autotests (both positive and negative). Here's the branch https://bugs.kde.org/show_bug.cgi?id=332161#c8

Apr 29 2020, 3:26 PM · KDb
staniek committed R15:a85f2c20c8af: Initial change for autotests supporting #332161 (support for id escaping) (authored by staniek).
Initial change for autotests supporting #332161 (support for id escaping)
Apr 29 2020, 3:24 PM
staniek added a comment to D29277: Escape table name in when building a select statement with row id.

To be sure, you're constructing a query using C++ classes and not using the parser?
I am asking because to me "select id from [table]" does not work since we do not (yet) support identifier escaping with [].

Apr 29 2020, 3:14 PM · KDb
staniek added a comment to D29277: Escape table name in when building a select statement with row id.

Related fix in KEXI 3.2 would be welcome.

Apr 29 2020, 2:54 PM · KDb
staniek added a comment to D29277: Escape table name in when building a select statement with row id.

Thanks. Is there any relation to https://bugs.kde.org/show_bug.cgi?id=420599?

Apr 29 2020, 2:50 PM · KDb

Apr 28 2020

staniek committed R71:197cdacd1a94: Display extra note when misconfiguration of QT_PLUGIN_PATH was detected (authored by staniek).
Display extra note when misconfiguration of QT_PLUGIN_PATH was detected
Apr 28 2020, 9:47 PM
staniek committed R71:977d62e2e574: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Apr 28 2020, 9:47 PM
staniek committed R71:ae0e7f9e1f36: TRIVIAL No need to warn in KexiDataAwareObjectInterface::hasData() (authored by staniek).
TRIVIAL No need to warn in KexiDataAwareObjectInterface::hasData()
Apr 28 2020, 9:14 PM
staniek committed R71:91b54beb53b4: TRIVIAL Turn http URLs into https (authored by staniek).
TRIVIAL Turn http URLs into https
Apr 28 2020, 9:14 PM

Apr 25 2020

staniek committed R15:33a978feffd4: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Apr 25 2020, 9:03 PM
staniek closed D29185: Expand feature test for buffered cursors.
Apr 25 2020, 9:03 PM · KDb
staniek committed R15:3e7b595ee908: Expand feature test for buffered cursors (authored by jfita).
Expand feature test for buffered cursors
Apr 25 2020, 9:03 PM
staniek accepted D29185: Expand feature test for buffered cursors.

Good job!

Apr 25 2020, 9:03 PM · KDb
staniek closed D29184: Take all args to kdbfeaturestest before the driver.
Apr 25 2020, 8:59 PM · KDb
staniek accepted D29184: Take all args to kdbfeaturestest before the driver.
Apr 25 2020, 8:58 PM · KDb
staniek reopened D29184: Take all args to kdbfeaturestest before the driver.
Apr 25 2020, 8:58 PM · KDb
staniek committed R15:1632bda31ba3: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Apr 25 2020, 8:56 PM
staniek closed D29184: Take all args to kdbfeaturestest before the driver.
Apr 25 2020, 8:56 PM · KDb
staniek committed R15:20fb7f0d2631: Take all args to kdbfeaturestest before the driver (authored by jfita).
Take all args to kdbfeaturestest before the driver
Apr 25 2020, 8:55 PM
staniek added a comment to D29184: Take all args to kdbfeaturestest before the driver.

Thanks. Looks good. For the future, bugfixes can go to the 3.2 branch - it will be easier to apply. Otherwise I need to cherry-pick a commit.

Apr 25 2020, 8:52 PM · KDb
staniek added a comment to D29166: Add cached table example.

Thank you Jordi, I will review it. This looks like a wonderful example app!

Apr 25 2020, 3:20 PM · KDb

Apr 22 2020

staniek committed R14:db1b11af51a2: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Apr 22 2020, 7:50 PM
staniek closed D28809: Expand the documentation’s main page with an overview and example.
Apr 22 2020, 7:50 PM · KReport
staniek committed R14:4fde96f6d0ea: Expand the documentation’s main page with an overview and example (authored by jfita).
Expand the documentation’s main page with an overview and example
Apr 22 2020, 7:50 PM
staniek accepted D28809: Expand the documentation’s main page with an overview and example.
Apr 22 2020, 7:46 PM · KReport
staniek added a comment to D28809: Expand the documentation’s main page with an overview and example.

BTW, while creating reviews please add at least me and KReport maintainer Adam as reviewers. Thanks!

Sorry about that. I misunderstood the instructions at the community wiki to mean that it would be done automatically.

I will keep it in mind next time.

Apr 22 2020, 7:44 PM · KReport

Apr 20 2020

staniek added a comment to D28809: Expand the documentation’s main page with an overview and example.

BTW, while creating reviews please add at least me and KReport maintainer Adam as reviewers. Thanks!

Apr 20 2020, 9:39 AM · KReport
staniek added a comment to D28809: Expand the documentation’s main page with an overview and example.

Good job, some notes added.

Apr 20 2020, 9:37 AM · KReport
staniek added a reviewer for D28809: Expand the documentation’s main page with an overview and example: piggz.
Apr 20 2020, 9:02 AM · KReport
staniek added a reviewer for D28809: Expand the documentation’s main page with an overview and example: staniek.
Apr 20 2020, 9:02 AM · KReport

Apr 18 2020

staniek added a comment to D28809: Expand the documentation’s main page with an overview and example.

Reviewed until line 475.

Apr 18 2020, 8:08 PM · KReport

Apr 17 2020

staniek added a comment to D28809: Expand the documentation’s main page with an overview and example.
Apr 17 2020, 10:03 PM · KReport

Apr 16 2020

staniek added a comment to D28809: Expand the documentation’s main page with an overview and example.

Thanks, reviewed first 200 lines. Good job!

Apr 16 2020, 7:35 PM · KReport

Apr 14 2020

staniek added a comment to D28809: Expand the documentation’s main page with an overview and example.

Very nice, I will review this.

Apr 14 2020, 9:20 AM · KReport

Apr 11 2020

staniek closed D28694: Fix warning message for missing report:connection.
Apr 11 2020, 9:15 PM · KEXI
staniek committed R71:c356652fcd82: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Apr 11 2020, 9:15 PM
staniek committed R71:b6a59fd61f39: TRIVIAL Fix warning message for missing report:connection (authored by staniek).
TRIVIAL Fix warning message for missing report:connection
Apr 11 2020, 9:15 PM
staniek committed R14:a57ffce20bf6: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Apr 11 2020, 9:02 PM
staniek closed D28762: Call updateScripts in KReportDesigner::setScriptSource.
Apr 11 2020, 8:52 PM · KReport
staniek added a comment to D28762: Call updateScripts in KReportDesigner::setScriptSource.

BTW @jfita, I propose adding the following line to the description, to help us creating change logs:

Apr 11 2020, 8:51 PM · KReport
staniek committed R14:93487ea4bc6b: Call updateScripts in KReportDesigner::setScriptSource (authored by jfita).
Call updateScripts in KReportDesigner::setScriptSource
Apr 11 2020, 8:50 PM
staniek accepted D28762: Call updateScripts in KReportDesigner::setScriptSource.

Good job!

Apr 11 2020, 8:48 PM · KReport
staniek closed D28763: Set the script source for KReportDesigner and KReportPreRenderer in the example.
Apr 11 2020, 8:44 PM · KReport
staniek committed R14:84ee523b90d9: Set the script source for KReportDesigner and KReportPreRenderer in the example (authored by jfita).
Set the script source for KReportDesigner and KReportPreRenderer in the example
Apr 11 2020, 8:44 PM
staniek accepted D28763: Set the script source for KReportDesigner and KReportPreRenderer in the example.

Good job, thanks!

Apr 11 2020, 8:44 PM · KReport
staniek added a comment to D28736: Add Qt5PrintSupport and KF5CoreAddons dependencies to CMake config.

Landed in 3.2.

Apr 11 2020, 8:40 PM · KReport
staniek closed D28736: Add Qt5PrintSupport and KF5CoreAddons dependencies to CMake config.
Apr 11 2020, 8:40 PM · KReport
staniek committed R14:4ce3e8a857f2: Add Qt5PrintSupport and KF5CoreAddons dependencies to CMake config (authored by jfita).
Add Qt5PrintSupport and KF5CoreAddons dependencies to CMake config
Apr 11 2020, 8:38 PM

Apr 10 2020

staniek added a comment to D28736: Add Qt5PrintSupport and KF5CoreAddons dependencies to CMake config.

If we want it in the stable 3.2 release, it needs to land in the 3.2 branch.

Apr 10 2020, 10:57 PM · KReport
staniek accepted D28736: Add Qt5PrintSupport and KF5CoreAddons dependencies to CMake config.

Thanks!

Apr 10 2020, 10:56 PM · KReport

Apr 8 2020

staniek accepted D28694: Fix warning message for missing report:connection.

Good job, thanks!

Apr 8 2020, 11:25 PM · KEXI

Apr 5 2020

staniek committed R71:d4e206d9aeef: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Apr 5 2020, 2:06 PM
staniek committed R15:2e31324ff45c: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Apr 5 2020, 2:05 PM

Mar 28 2020

staniek committed R14:93155a7756c6: Merge remote-tracking branch 'origin/3.2' (authored by staniek).
Merge remote-tracking branch 'origin/3.2'
Mar 28 2020, 5:41 PM