- User Since
- Apr 18 2015, 1:59 PM (267 w, 5 d)
Sat, May 30
Fri, May 29
Great, thanks Friedrich.
Wed, May 27
Hi Freidrich. That's a good news to me!
Sun, May 17
Tue, May 12
Sun, May 10
Sat, May 9
Nice, but question, would it be possible to use ecm_setup_qtplugin_macro_names() ? https://api.kde.org/ecm/module/ECMSetupQtPluginMacroNames.html
May 3 2020
The fall back to text mode is correct and can help to manage consistency. kexi_scriptplugin.desktop vs kexi_tableplugin.desktop has only X-KDE-ServiceTypes=Kexi/Editor defined.
May 2 2020
May 1 2020
Apr 29 2020
Entering "select id from [table]" in KEXI SQL editor or passing it to a parser in C++ raises the same parser's error.
In order to reproduce bug you're fixing above one needs to create a queryfully using the C++ API since the parser won't let the to go reserved identifiers through.
(until the #332161 is solved)
Another note so we won't forget. Update for autotests (both positive and negative). Here's the branch https://bugs.kde.org/show_bug.cgi?id=332161#c8
To be sure, you're constructing a query using C++ classes and not using the parser?
I am asking because to me "select id from [table]" does not work since we do not (yet) support identifier escaping with .
Related fix in KEXI 3.2 would be welcome.
Thanks. Is there any relation to https://bugs.kde.org/show_bug.cgi?id=420599?
Apr 28 2020
Apr 25 2020
Thanks. Looks good. For the future, bugfixes can go to the 3.2 branch - it will be easier to apply. Otherwise I need to cherry-pick a commit.
Thank you Jordi, I will review it. This looks like a wonderful example app!
Apr 22 2020
Apr 20 2020
BTW, while creating reviews please add at least me and KReport maintainer Adam as reviewers. Thanks!
Good job, some notes added.
Apr 18 2020
Reviewed until line 475.
Apr 17 2020
Apr 16 2020
Thanks, reviewed first 200 lines. Good job!
Apr 14 2020
Very nice, I will review this.
Apr 11 2020
BTW @jfita, I propose adding the following line to the description, to help us creating change logs:
Good job, thanks!
Landed in 3.2.
Apr 10 2020
If we want it in the stable 3.2 release, it needs to land in the 3.2 branch.
Apr 8 2020
Good job, thanks!