dcaliste (Damien Caliste)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 21 2018, 8:46 AM (109 w, 15 h)
Availability
Available

Recent Activity

May 9 2020

dcaliste removed a watcher for KDE PIM: dcaliste.
May 9 2020, 2:17 PM

Mar 14 2020

dcaliste added a comment to T12815: Create Calligra Framework by separating out applications and libraries.

As a nobody, my opinion on the rightfullness to split or not the repository is of no interest. But what I like in the proposition of @leinir is the target to separate the "engine" from the UI (_i.e._ the widgetery). As an example (hopefully not outdated), the "find" classes, the one to search and replace, are deeply liked to the widgets that control them. It makes it impossible to reuse these class in a UI different from the original one.

Mar 14 2020, 9:31 AM · Calligra: 3.0

Mar 5 2020

dcaliste added a comment to D27826: Update visibility cache when notebook visibility is changed.

Thanks @winterz for review.

Mar 5 2020, 4:50 PM · KDE PIM
dcaliste closed D27826: Update visibility cache when notebook visibility is changed.
Mar 5 2020, 4:49 PM · KDE PIM
dcaliste committed R172:a8c4a61c2246: Update visibility cache when notebook visibility is changed (authored by dcaliste).
Update visibility cache when notebook visibility is changed
Mar 5 2020, 4:49 PM

Mar 4 2020

dcaliste updated the diff for D27826: Update visibility cache when notebook visibility is changed.

Rename mistake in header declaration (incidence -> notebook).

Mar 4 2020, 10:58 AM · KDE PIM
dcaliste updated the test plan for D27826: Update visibility cache when notebook visibility is changed.
Mar 4 2020, 10:53 AM · KDE PIM
dcaliste requested review of D27826: Update visibility cache when notebook visibility is changed.
Mar 4 2020, 10:51 AM · KDE PIM

Jan 28 2020

dcaliste added a comment to D26662: Don't set created and last modified fields when not present in ICS data..

Ping ! Do you have any remarks on this matter of created date set ?

Jan 28 2020, 3:24 PM · KDE PIM

Jan 14 2020

dcaliste updated the diff for D26662: Don't set created and last modified fields when not present in ICS data..

Add in the test another ICS data to ensure that existing CREATED and LAST-MODIFIED flags are kept.

Jan 14 2020, 1:20 PM · KDE PIM
dcaliste added a comment to D26662: Don't set created and last modified fields when not present in ICS data..

The patch is not necessary the ideal one, but I would like to start a discussion on this matter. Currently, when calling ICalFormat::fromString(), all created incidences feature a created() and a lastModified() properties. They either come from the values read from the ICS data string, or they are set to the current date time by Incidence::recreate() from Incidence constructor.

Jan 14 2020, 1:12 PM · KDE PIM
dcaliste added a reviewer for D26662: Don't set created and last modified fields when not present in ICS data.: KDE PIM.
Jan 14 2020, 1:03 PM · KDE PIM
dcaliste requested review of D26662: Don't set created and last modified fields when not present in ICS data..
Jan 14 2020, 1:02 PM · KDE PIM

Dec 28 2019

dcaliste added a comment to D26050: Fix build with poppler 82.

I like the idea of trying to move away from the monolythic release. Not that my opinion matters much, but I'm willing to help in the endeavor. I'll try to participate in tasks in that direction as much as my free time will allow it.

Dec 28 2019, 8:25 PM · Calligra: 3.0

Dec 8 2019

dcaliste added a comment to R172:fdc194f4a8b0: Add some test to ensure local time handling in recurrences..

Is there something wrong with these tests ? The assumptions tested are not correct ? Is this a coding standard issue ?

Dec 8 2019, 8:35 AM

Dec 3 2019

dcaliste added a comment to D25715: Use RTF default color as default Qt format.

@pvuorela as you prefer, anyway, it's a question of taste, I find it myself easier to follow if the information is on one variable only. But your solution is good also, the file is small and is kept small so easy to follow.

Dec 3 2019, 7:06 PM · Calligra: 3.0
dcaliste added a comment to D25715: Use RTF default color as default Qt format.

Just a suggestion to avoid adding a variable which meaning may be redundant with the state of an already existing one. Otherwise LGTM.

Dec 3 2019, 4:00 PM · Calligra: 3.0

Nov 20 2019

dcaliste committed R172:fdc194f4a8b0: Add some test to ensure local time handling in recurrences. (authored by dcaliste).
Add some test to ensure local time handling in recurrences.
Nov 20 2019, 5:11 PM
dcaliste closed D25419: Add some test to ensure local time handling in recurrences..
Nov 20 2019, 5:11 PM · KDE PIM
dcaliste added reviewers for D25419: Add some test to ensure local time handling in recurrences.: vkrause, KDE PIM.

There actually is no bug in KCalendarCore regarding this topic of exceptions for a local time event. We had to fix various ones in SailfishOS ancient version of KCalCore and we have added tests for this. I'm happy to see that the tests are passing in KCalendarCore out of the box, and since we crafted these tests, I'm proposing to add them here.

Nov 20 2019, 11:54 AM · KDE PIM
dcaliste requested review of D25419: Add some test to ensure local time handling in recurrences..
Nov 20 2019, 11:51 AM · KDE PIM

Nov 18 2019

dcaliste added a comment to D25367: Fallback to system time zone on calendar creation with an invalid one..

Thanks for the review and having found the issue. Commited.

Nov 18 2019, 1:28 PM · KDE PIM
dcaliste committed R172:cf68c74439d7: Fallback to system time zone on calendar creation with an invalid one. (authored by dcaliste).
Fallback to system time zone on calendar creation with an invalid one.
Nov 18 2019, 1:28 PM
dcaliste closed D25367: Fallback to system time zone on calendar creation with an invalid one..
Nov 18 2019, 1:28 PM · KDE PIM
dcaliste added a comment to D25066: Handle incidences in different time zones in MemoryCalendar..

@vkrause see https://phabricator.kde.org/D25367 for a patch ensuring a fallback to the system time zone if invalid.

Nov 18 2019, 12:44 PM · KDE PIM
dcaliste added reviewers for D25367: Fallback to system time zone on calendar creation with an invalid one.: KDE PIM, vkrause.

Here is the patch to ensure that a calendar cannot be created with an invalid time zone.

Nov 18 2019, 12:43 PM · KDE PIM
dcaliste requested review of D25367: Fallback to system time zone on calendar creation with an invalid one..
Nov 18 2019, 12:42 PM · KDE PIM
dcaliste added a comment to D25066: Handle incidences in different time zones in MemoryCalendar..

@vkrause sorry, I misunderstand by looking at the current code of kitinerary… Before it was with a QTimeZone(), but systemTimeZone() is actually working. Patch is coming to ensure that systemTimeZone is used when creating a MemoryCalendar from an invalid time zone argument.

Nov 18 2019, 12:26 PM · KDE PIM
dcaliste added a comment to D25066: Handle incidences in different time zones in MemoryCalendar..

I added systemTimeZone() there to work around this issue.

Nov 18 2019, 10:28 AM · KDE PIM
dcaliste added a comment to D25066: Handle incidences in different time zones in MemoryCalendar..

I've open this Qt bug : https://bugreports.qt.io/browse/QTBUG-80146

Nov 18 2019, 9:21 AM · KDE PIM
dcaliste added a comment to D25066: Handle incidences in different time zones in MemoryCalendar..

Indeed, such snippet is segfaulting on the second toTimeZone() call:

Nov 18 2019, 8:59 AM · KDE PIM
dcaliste added a comment to D25066: Handle incidences in different time zones in MemoryCalendar..

@vkrause Oups, that's bad. I'm giving a look. Sorry for the introduced issue but thanks for reporting :/

Nov 18 2019, 8:09 AM · KDE PIM

Nov 16 2019

dcaliste added a comment to D25289: Read floating date time as LocalTime..

@winterz thanks for the tests, it's greatly appreciated. I'll give a look to the bugs you mentioned to see if there is some report already about floating time issues with timezone.

Nov 16 2019, 8:00 AM · KDE PIM

Nov 14 2019

dcaliste added a comment to D25289: Read floating date time as LocalTime..

@mlaurent I agree. That is the point of my opening sentence "take the opportunity of this patch to discuss the consequences here". I'm wondering how codes using KCalendarCore are currently handling floating time events incoming from iCal data during a sync operation for instance. Looking at the code, I guess that they are ignoring the floating property and display the event in the current time zone. What happens when they are travelling to another time zone ? What happen when they upsync again this event to a remote server ? Didn't any users already notice that floating time events are not kept floating after up sync ? Am I completely wrong and I'm missing something here that make possible to handle floating time events with the current code ?

Nov 14 2019, 8:58 AM · KDE PIM
dcaliste added a comment to D25289: Read floating date time as LocalTime..

@winterz thanks for looking at this. I'm sorry, I forgot to talk about the context. Indeed, I've no bug related to this. This is coming for the work I'm doing to port from the ancient Meego-era KCalCore code in SailfishOS to the latest upstream. One of the work in the transition in SailfishOS is to replace KDateTime by QDateTime. Doing this, I notice that the ClockTime spec of KDateTime does not exist anymore. This spec is currently used to store floating time events. So I wonder, how are they doing upstream ? And the best way to look at this, in my opinion, was to look at the reading of iCal floating time in icalformat_p.cpp. That's how I notice that floating times were converted into current system time zone, which is fine at the moment of reading the iCal data, but leave no way to store the event as a floating date (so viewing this event after a time zone change like travelling, will actually display the event at the wrong time) and worst, sending back this event to a server in a sync process will loose the floating date information and will attach this event to a specific time zone. Thus the patch.

Nov 14 2019, 8:21 AM · KDE PIM

Nov 13 2019

dcaliste updated the diff for D25289: Read floating date time as LocalTime..

Correct wrong indentation.

Nov 13 2019, 5:05 PM · KDE PIM
dcaliste added inline comments to D25289: Read floating date time as LocalTime..
Nov 13 2019, 5:03 PM · KDE PIM
dcaliste added reviewers for D25289: Read floating date time as LocalTime.: vkrause, pvuorela, KDE PIM, dvratil.

I think that tests are still passing properly, but this change may have unexpected consequences. I would like to tqke the opportunity of this pqtch to discuss if it's a valid approach for floating date time input. Thank you.

Nov 13 2019, 3:15 PM · KDE PIM
dcaliste requested review of D25289: Read floating date time as LocalTime..
Nov 13 2019, 3:12 PM · KDE PIM

Nov 12 2019

dcaliste committed R172:c5b6098b4c7d: Handle incidences in different time zones in MemoryCalendar. (authored by dcaliste).
Handle incidences in different time zones in MemoryCalendar.
Nov 12 2019, 5:12 PM

Nov 8 2019

dcaliste added a watcher for KDE PIM: dcaliste.
Nov 8 2019, 2:57 PM
dcaliste removed a watcher for KDE PIM: dcaliste.
Nov 8 2019, 2:54 PM
dcaliste added a watcher for KDE PIM: dcaliste.
Nov 8 2019, 2:51 PM

Nov 7 2019

dcaliste closed D25066: Handle incidences in different time zones in MemoryCalendar..
Nov 7 2019, 3:12 PM · KDE PIM

Nov 6 2019

dcaliste added a comment to D25066: Handle incidences in different time zones in MemoryCalendar..

Great, thanks for the review, I'll push it later today or tomorrow.

Nov 6 2019, 11:54 AM · KDE PIM

Nov 5 2019

dcaliste added a reviewer for D25066: Handle incidences in different time zones in MemoryCalendar.: vkrause.
Nov 5 2019, 9:45 AM · KDE PIM
dcaliste updated subscribers of D25066: Handle incidences in different time zones in MemoryCalendar..
Nov 5 2019, 9:44 AM · KDE PIM
dcaliste added a project to D25066: Handle incidences in different time zones in MemoryCalendar.: KDE PIM.
Nov 5 2019, 9:44 AM · KDE PIM

Oct 30 2019

dcaliste added reviewers for D25066: Handle incidences in different time zones in MemoryCalendar.: KDE PIM, winterz.

Would you please review this patch for time zone proper handling in MemoryCalendar ? The block deletion in rawEventsForDate() is in my opinion justified by the fact that when looking in the cache, we're looking for events that are neither multidays nor recurrent. So testing the end date for such one day only events has no point. What do you think ?

Oct 30 2019, 9:30 AM · KDE PIM
dcaliste requested review of D25066: Handle incidences in different time zones in MemoryCalendar..
Oct 30 2019, 9:25 AM · KDE PIM

Oct 28 2019

dcaliste added a comment to D25008: Add XLSX spreadsheets import optimisations for small/readonly devices.

@davidllewellynjones, I hadn't time yet to test the patch, but the idea and implementation is already looking great in my opinion. Maybe, just one remark after looking at the proposed additions: not saving the formale, but the values should not be named read-only. Indeed, maybe in the future, we would like to be able to "inspect" the content of a cell, even on portable devices. Being able to read the formulae should then be possible, even if not for modification. I may suggest the following naming changes (functionality to load by values to help loading time is great) :

  • MSOOXML_IMPORT_READ_ONLY -> MSOOXML_IMPORT_BY_VALUES or MSOOXML_IMPORT_VALUES_ONLY
  • MSOOXML::readonlySpreadsheet() -> MSOOXML::byValuesSpreadsheet() or MSOOXML::valuesOnlySpreadsheet()
Oct 28 2019, 3:35 PM · Calligra: 3.0
dcaliste accepted D24831: Migrate csv plugins from kdebug to qdebug.

The patch looks fine, thank you.

Oct 28 2019, 1:54 PM · Calligra: 3.0
dcaliste added a comment to D24761: Asign correct column width when importing XLS file.

Well, after reading the difference between the logical and physical DPI values: https://stackoverflow.com/questions/16561879/what-is-the-difference-between-logicaldpix-and-physicaldpix-in-qt (see the first answer), using the logical value is consistent with the hard coded "arial 10" font metric some line above.

Oct 28 2019, 1:36 PM · Calligra: 3.0

Sep 2 2019

dcaliste committed R8:f0f0eedf1e74: Correct anchor detection in QML components. (authored by dcaliste).
Correct anchor detection in QML components.
Sep 2 2019, 1:57 PM
dcaliste closed D23492: Correct anchor detection in QML components..
Sep 2 2019, 1:57 PM · Calligra: 3.0
dcaliste abandoned D23679: Correct anchor detection in QML components..

Sorry, made a mistake with arc… This differential revision is already D23492.

Sep 2 2019, 1:36 PM · Calligra: 3.0
dcaliste requested review of D23679: Correct anchor detection in QML components..
Sep 2 2019, 1:34 PM · Calligra: 3.0
dcaliste updated the diff for D23492: Correct anchor detection in QML components..

Thank you pvuorela pointing out other places for this construct. I've updated the patch with a fix for the faulty loops for spreadsheets and presentations also.

Sep 2 2019, 7:00 AM · Calligra: 3.0

Aug 27 2019

dcaliste requested review of D23492: Correct anchor detection in QML components..
Aug 27 2019, 1:32 PM · Calligra: 3.0

Jun 4 2019

dcaliste committed R172:4cc238c78324: Create second-type duration for 0 delay durations in ical format. (authored by dcaliste).
Create second-type duration for 0 delay durations in ical format.
Jun 4 2019, 7:58 AM
dcaliste closed D21215: Create second-type duration for 0 delay durations in ical format..
Jun 4 2019, 7:58 AM · KDE PIM

May 14 2019

dcaliste requested review of D21215: Create second-type duration for 0 delay durations in ical format..
May 14 2019, 1:57 PM · KDE PIM

Mar 26 2019

dcaliste committed R8:c06c5e01455f: MsooXmlCommonRead: protect member for double free (authored by pvuorela).
MsooXmlCommonRead: protect member for double free
Mar 26 2019, 9:48 AM
dcaliste committed R8:4f304e579fce: Avoid deprecated setSupportedDragActions (authored by pvuorela).
Avoid deprecated setSupportedDragActions
Mar 26 2019, 9:47 AM
dcaliste closed D19973: MsooXmlCommonRead: protect member for double free.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste committed R8:b0e185c8a3a6: Remove obsolete syncX() workaround (authored by pvuorela).
Remove obsolete syncX() workaround
Mar 26 2019, 9:47 AM
dcaliste committed R8:149cd73c722b: Avoid deprecated QRegion::subtract() (authored by pvuorela).
Avoid deprecated QRegion::subtract()
Mar 26 2019, 9:47 AM
dcaliste committed R8:b08a4bac940d: Support Qt <5.7 on KoShape flag usage (authored by pvuorela).
Support Qt <5.7 on KoShape flag usage
Mar 26 2019, 9:47 AM
dcaliste closed D19941: Avoid deprecated setSupportedDragActions.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19938: Avoid deprecated QRegion::subtract().
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19761: Remove obsolete syncX() workaround.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste committed R8:b29f7aa31c5e: Avoid deprecated QAbstractItemModel::reset() (authored by pvuorela).
Avoid deprecated QAbstractItemModel::reset()
Mar 26 2019, 9:47 AM
dcaliste closed D19760: Support Qt <5.7 on KoShape flag usage.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste committed R8:5e9da957f156: Implement logging category for excel plugins (authored by pvuorela).
Implement logging category for excel plugins
Mar 26 2019, 9:47 AM
dcaliste committed R8:85b57f2e64bb: Implement logging category for rtf-qt (authored by pvuorela).
Implement logging category for rtf-qt
Mar 26 2019, 9:47 AM
dcaliste closed D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19885: Implement logging category for excel plugins.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19912: Implement logging category for rtf-qt.
Mar 26 2019, 9:47 AM · Calligra: 3.0

Mar 19 2019

dcaliste added inline comments to D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 19 2019, 7:15 PM · Calligra: 3.0

Oct 10 2018

dcaliste added a comment to D15053: Consistently use qreal in libs/pigment.

Thank you all for the review.

Oct 10 2018, 2:35 PM · Calligra: 3.0
dcaliste committed R8:560701ff2443: Consistently use qreal in libs/pigment (authored by dcaliste).
Consistently use qreal in libs/pigment
Oct 10 2018, 2:35 PM
dcaliste closed D15053: Consistently use qreal in libs/pigment.
Oct 10 2018, 2:35 PM · Calligra: 3.0

Oct 4 2018

dcaliste added a comment to D15775: Make the item background color and page cache properties available from View component.

Thank you @leinir for your review. I've not disappeared, but I'm still thinking about a way not to expose the impl object from Document class, while not cluttering the Document API with methods like setBackgroundColor(), setPageCache() or any other future canvas methods that I may think about.

Oct 4 2018, 9:35 AM · Calligra: 3.0

Sep 26 2018

dcaliste added a comment to D15775: Make the item background color and page cache properties available from View component.

Sorry, I was not clear in my description, I'm not setting the paper background color, but the item background color, i.e. the small area around and between the pages. In most desktop application it is light grey. But when using the KWCanvasItem in another context, it would be nice to be able to set this color. It's kind of desktop color if you prefer.

Sep 26 2018, 7:44 PM · Calligra: 3.0
dcaliste requested review of D15775: Make the item background color and page cache properties available from View component.
Sep 26 2018, 3:00 PM · Calligra: 3.0

Sep 24 2018

dcaliste committed R8:ccb647780104: Try to avoid segfaults on shape factory not found (authored by dcaliste).
Try to avoid segfaults on shape factory not found
Sep 24 2018, 2:30 PM
dcaliste closed D15728: Try to avoid segfaults on shape factory not found.
Sep 24 2018, 2:30 PM · Calligra: 3.0
dcaliste requested review of D15728: Try to avoid segfaults on shape factory not found.
Sep 24 2018, 1:08 PM · Calligra: 3.0
dcaliste committed R8:5149f3864f5e: Add missing dependencies for PART_STAGE (authored by dcaliste).
Add missing dependencies for PART_STAGE
Sep 24 2018, 12:36 PM
dcaliste closed D15679: Add missing dependencies for PART_STAGE.
Sep 24 2018, 12:36 PM · Calligra: 3.0
dcaliste committed R8:a06f24de8708: Move away from kdebug and kdelibs4 in filter/sheets (authored by dcaliste).
Move away from kdebug and kdelibs4 in filter/sheets
Sep 24 2018, 12:21 PM
dcaliste closed D15617: Move away from kdebug and kdelibs4 in filter/sheets.
Sep 24 2018, 12:21 PM · Calligra: 3.0

Sep 21 2018

dcaliste requested review of D15679: Add missing dependencies for PART_STAGE.
Sep 21 2018, 1:52 PM · Calligra: 3.0
dcaliste committed R8:427b182ebea1: Upgrade intersect() to intersected() calls (authored by dcaliste).
Upgrade intersect() to intersected() calls
Sep 21 2018, 12:30 PM
dcaliste closed D15622: Upgrade intersect() to intersected() calls.
Sep 21 2018, 12:30 PM · Calligra: 3.0
dcaliste committed R8:919c672526ef: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag (authored by dcaliste).
Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag
Sep 21 2018, 12:29 PM
dcaliste closed D15620: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag.
Sep 21 2018, 12:29 PM · Calligra: 3.0
dcaliste committed R8:71363fdfd076: Remove use of kglobal.h in sheets (authored by dcaliste).
Remove use of kglobal.h in sheets
Sep 21 2018, 8:06 AM
dcaliste closed D15619: Remove use of kglobal.h in sheets.
Sep 21 2018, 8:06 AM · Calligra: 3.0

Sep 20 2018

dcaliste requested review of D15622: Upgrade intersect() to intersected() calls.
Sep 20 2018, 2:41 PM · Calligra: 3.0