- User Since
- Aug 21 2018, 8:46 AM (60 w, 1 d)
Sep 2 2019
Sorry, made a mistake with arc… This differential revision is already D23492.
Thank you pvuorela pointing out other places for this construct. I've updated the patch with a fix for the faulty loops for spreadsheets and presentations also.
Aug 27 2019
Jun 4 2019
May 14 2019
Mar 26 2019
Mar 19 2019
Oct 10 2018
Thank you all for the review.
Oct 4 2018
Thank you @leinir for your review. I've not disappeared, but I'm still thinking about a way not to expose the impl object from Document class, while not cluttering the Document API with methods like setBackgroundColor(), setPageCache() or any other future canvas methods that I may think about.
Sep 26 2018
Sorry, I was not clear in my description, I'm not setting the paper background color, but the item background color, i.e. the small area around and between the pages. In most desktop application it is light grey. But when using the KWCanvasItem in another context, it would be nice to be able to set this color. It's kind of desktop color if you prefer.
Sep 24 2018
Sep 21 2018
Sep 20 2018
Update the patch, using categories for logging.
@anthonyfieroni I see, like in filters/sheets/html for instance. I'm going to update the diff as soon as ready. Thanks for the comment.
Sep 6 2018
Sep 3 2018
Update the patch not to use the form `qBound(qreal(0.0), a, qreal(1.0))` but `qBound<qreal>(0.0, a, 1.0)` instead. For reference, original form was `qBound(0.0, a, 1.0)` which was causing issues when qreal <-> float, because of mixed doubles and floats.
Aug 29 2018
@piggz thank you for the proposition. I've discussed with jpetrell, pvuorela and lbt on #sailfishos (see Tuesday 21th discussion, or the Tuesday before) and currently they prefer to have KF5 dependency packages within Calligra, not as standalone libraries in mer-core. Depending later on additional packages creating new demand on KF5, some packages may be migrated to mer-core. So far so good for me. I think 5.34 is the latest version to compile with 5.6 (at least, that's the case for KI18n, so I'm using consistently this version for the other packages). I'm using git repos, so there is no problem to get any version I want. It's a matter of git checkout v5.xx.0.
@leinir, thank you. Instead of compiling with deprecation off, it's better to correct them ;)
Aug 27 2018
Propagate changes into filters: missing conversion from QSharedPointer into QPointer.
Aug 24 2018
After test (PRODUCTSET="KARBON"), it's not breaking karbon build on amd64.
Ok, I'll try in the afternoon or during the week-end and comment here.
I'm crosscompiling in SailfishOS SDK. I'm in the process of upgrading Calligra there to latest version. @leinir have done it earlier with version 2.9.x. At that moment, pigment was not containing that kind of function to change luminosity... where the conversions are used. I don't know if it's the best way to handle the issue. Don't hesitate to comment !
Aug 22 2018
Update the patch in stackChanged() call to have the exact behaviour than before in this method.
@danders I agree with your remark, I was wondering exactly the same. It's safer to put the begin / end together. I'll update the diff and add a comment to suggest to move the end after the setCurrentIndex() after extensive testing.
Aug 21 2018
I've added replacements for QAbstractItemModel::reset(). This allow to "lock" the model during the reset. So I've tried to put the beginResetModel() before the change of the private members, and the endResetModel() after.
@anthonyfieroni Ok, will update the diff with other replacements of obsolete functions.