dcaliste (Damien Caliste)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 21 2018, 8:46 AM (52 w, 2 d)
Availability
Available

Recent Activity

Jun 4 2019

dcaliste committed R172:4cc238c78324: Create second-type duration for 0 delay durations in ical format. (authored by dcaliste).
Create second-type duration for 0 delay durations in ical format.
Jun 4 2019, 7:58 AM
dcaliste closed D21215: Create second-type duration for 0 delay durations in ical format..
Jun 4 2019, 7:58 AM · KDE PIM

May 14 2019

dcaliste requested review of D21215: Create second-type duration for 0 delay durations in ical format..
May 14 2019, 1:57 PM · KDE PIM

Mar 26 2019

dcaliste committed R8:c06c5e01455f: MsooXmlCommonRead: protect member for double free (authored by pvuorela).
MsooXmlCommonRead: protect member for double free
Mar 26 2019, 9:48 AM
dcaliste committed R8:4f304e579fce: Avoid deprecated setSupportedDragActions (authored by pvuorela).
Avoid deprecated setSupportedDragActions
Mar 26 2019, 9:47 AM
dcaliste closed D19973: MsooXmlCommonRead: protect member for double free.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste committed R8:b0e185c8a3a6: Remove obsolete syncX() workaround (authored by pvuorela).
Remove obsolete syncX() workaround
Mar 26 2019, 9:47 AM
dcaliste committed R8:149cd73c722b: Avoid deprecated QRegion::subtract() (authored by pvuorela).
Avoid deprecated QRegion::subtract()
Mar 26 2019, 9:47 AM
dcaliste committed R8:b08a4bac940d: Support Qt <5.7 on KoShape flag usage (authored by pvuorela).
Support Qt <5.7 on KoShape flag usage
Mar 26 2019, 9:47 AM
dcaliste closed D19941: Avoid deprecated setSupportedDragActions.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19938: Avoid deprecated QRegion::subtract().
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19761: Remove obsolete syncX() workaround.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste committed R8:b29f7aa31c5e: Avoid deprecated QAbstractItemModel::reset() (authored by pvuorela).
Avoid deprecated QAbstractItemModel::reset()
Mar 26 2019, 9:47 AM
dcaliste closed D19760: Support Qt <5.7 on KoShape flag usage.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste committed R8:5e9da957f156: Implement logging category for excel plugins (authored by pvuorela).
Implement logging category for excel plugins
Mar 26 2019, 9:47 AM
dcaliste committed R8:85b57f2e64bb: Implement logging category for rtf-qt (authored by pvuorela).
Implement logging category for rtf-qt
Mar 26 2019, 9:47 AM
dcaliste closed D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19885: Implement logging category for excel plugins.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19912: Implement logging category for rtf-qt.
Mar 26 2019, 9:47 AM · Calligra: 3.0

Mar 19 2019

dcaliste added inline comments to D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 19 2019, 7:15 PM · Calligra: 3.0

Oct 10 2018

dcaliste added a comment to D15053: Consistently use qreal in libs/pigment.

Thank you all for the review.

Oct 10 2018, 2:35 PM · Calligra: 3.0
dcaliste committed R8:560701ff2443: Consistently use qreal in libs/pigment (authored by dcaliste).
Consistently use qreal in libs/pigment
Oct 10 2018, 2:35 PM
dcaliste closed D15053: Consistently use qreal in libs/pigment.
Oct 10 2018, 2:35 PM · Calligra: 3.0

Oct 4 2018

dcaliste added a comment to D15775: Make the item background color and page cache properties available from View component.

Thank you @leinir for your review. I've not disappeared, but I'm still thinking about a way not to expose the impl object from Document class, while not cluttering the Document API with methods like setBackgroundColor(), setPageCache() or any other future canvas methods that I may think about.

Oct 4 2018, 9:35 AM · Calligra: 3.0

Sep 26 2018

dcaliste added a comment to D15775: Make the item background color and page cache properties available from View component.

Sorry, I was not clear in my description, I'm not setting the paper background color, but the item background color, i.e. the small area around and between the pages. In most desktop application it is light grey. But when using the KWCanvasItem in another context, it would be nice to be able to set this color. It's kind of desktop color if you prefer.

Sep 26 2018, 7:44 PM · Calligra: 3.0
dcaliste requested review of D15775: Make the item background color and page cache properties available from View component.
Sep 26 2018, 3:00 PM · Calligra: 3.0

Sep 24 2018

dcaliste committed R8:ccb647780104: Try to avoid segfaults on shape factory not found (authored by dcaliste).
Try to avoid segfaults on shape factory not found
Sep 24 2018, 2:30 PM
dcaliste closed D15728: Try to avoid segfaults on shape factory not found.
Sep 24 2018, 2:30 PM · Calligra: 3.0
dcaliste requested review of D15728: Try to avoid segfaults on shape factory not found.
Sep 24 2018, 1:08 PM · Calligra: 3.0
dcaliste committed R8:5149f3864f5e: Add missing dependencies for PART_STAGE (authored by dcaliste).
Add missing dependencies for PART_STAGE
Sep 24 2018, 12:36 PM
dcaliste closed D15679: Add missing dependencies for PART_STAGE.
Sep 24 2018, 12:36 PM · Calligra: 3.0
dcaliste committed R8:a06f24de8708: Move away from kdebug and kdelibs4 in filter/sheets (authored by dcaliste).
Move away from kdebug and kdelibs4 in filter/sheets
Sep 24 2018, 12:21 PM
dcaliste closed D15617: Move away from kdebug and kdelibs4 in filter/sheets.
Sep 24 2018, 12:21 PM · Calligra: 3.0

Sep 21 2018

dcaliste requested review of D15679: Add missing dependencies for PART_STAGE.
Sep 21 2018, 1:52 PM · Calligra: 3.0
dcaliste committed R8:427b182ebea1: Upgrade intersect() to intersected() calls (authored by dcaliste).
Upgrade intersect() to intersected() calls
Sep 21 2018, 12:30 PM
dcaliste closed D15622: Upgrade intersect() to intersected() calls.
Sep 21 2018, 12:30 PM · Calligra: 3.0
dcaliste committed R8:919c672526ef: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag (authored by dcaliste).
Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag
Sep 21 2018, 12:29 PM
dcaliste closed D15620: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag.
Sep 21 2018, 12:29 PM · Calligra: 3.0
dcaliste committed R8:71363fdfd076: Remove use of kglobal.h in sheets (authored by dcaliste).
Remove use of kglobal.h in sheets
Sep 21 2018, 8:06 AM
dcaliste closed D15619: Remove use of kglobal.h in sheets.
Sep 21 2018, 8:06 AM · Calligra: 3.0

Sep 20 2018

dcaliste requested review of D15622: Upgrade intersect() to intersected() calls.
Sep 20 2018, 2:41 PM · Calligra: 3.0
dcaliste updated the diff for D15617: Move away from kdebug and kdelibs4 in filter/sheets.

Update the patch, using categories for logging.

Sep 20 2018, 2:13 PM · Calligra: 3.0
dcaliste added a comment to D15617: Move away from kdebug and kdelibs4 in filter/sheets.

@anthonyfieroni I see, like in filters/sheets/html for instance. I'm going to update the diff as soon as ready. Thanks for the comment.

Sep 20 2018, 1:28 PM · Calligra: 3.0
dcaliste requested review of D15620: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag.
Sep 20 2018, 1:19 PM · Calligra: 3.0
dcaliste requested review of D15619: Remove use of kglobal.h in sheets.
Sep 20 2018, 1:17 PM · Calligra: 3.0
dcaliste requested review of D15617: Move away from kdebug and kdelibs4 in filter/sheets.
Sep 20 2018, 12:54 PM · Calligra: 3.0
dcaliste committed R8:6b52b86ae29c: Add missing dependencies in CMakeLists.txt (authored by dcaliste).
Add missing dependencies in CMakeLists.txt
Sep 20 2018, 8:44 AM
dcaliste closed D15236: Add missing dependencies in CMakeLists.txt.
Sep 20 2018, 8:44 AM · Calligra: 3.0
dcaliste committed R8:bc9397bc9959: Update deprecated use of setResizeMode() (authored by dcaliste).
Update deprecated use of setResizeMode()
Sep 20 2018, 8:38 AM
dcaliste closed D15232: Update deprecated use of setResizeMode().
Sep 20 2018, 8:38 AM · Calligra: 3.0
dcaliste committed R8:5873bc9d963c: Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl (authored by dcaliste).
Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl
Sep 20 2018, 8:36 AM
dcaliste closed D15231: Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl.
Sep 20 2018, 8:36 AM · Calligra: 3.0
dcaliste committed R8:4ebf41d68d71: Replace deprecated use of QWeakPointer<QObject*> in favor of QPointer<QObject*> (authored by dcaliste).
Replace deprecated use of QWeakPointer<QObject*> in favor of QPointer<QObject*>
Sep 20 2018, 8:33 AM
dcaliste closed D15103: Replace deprecated use of QWeakPointer<QObject*> in favor of QPointer<QObject*>.
Sep 20 2018, 8:33 AM · Calligra: 3.0
dcaliste committed R8:e4a5dc4f46f2: Update deprecated QAbstractItemModel::reset() to use {begin,end}ResetModel()… (authored by dcaliste).
Update deprecated QAbstractItemModel::reset() to use {begin,end}ResetModel()…
Sep 20 2018, 8:27 AM
dcaliste closed D15102: Update deprecated QAbstractItemModel::reset() to use {begin,end}ResetModel() instead.
Sep 20 2018, 8:27 AM · Calligra: 3.0
dcaliste committed R8:fe471acca71b: Don't use obsolete QRectF and QAbstractItemModel functions (authored by dcaliste).
Don't use obsolete QRectF and QAbstractItemModel functions
Sep 20 2018, 7:23 AM
dcaliste closed D14975: Don't use obsolete QRectF and QAbstractItemModel functions.
Sep 20 2018, 7:23 AM · Calligra: 3.0

Sep 6 2018

dcaliste added a watcher for Calligra: 3.0: dcaliste.
Sep 6 2018, 9:13 AM

Sep 3 2018

dcaliste updated the summary of D15236: Add missing dependencies in CMakeLists.txt.
Sep 3 2018, 10:11 AM · Calligra: 3.0
dcaliste requested review of D15236: Add missing dependencies in CMakeLists.txt.
Sep 3 2018, 10:10 AM · Calligra: 3.0
dcaliste requested review of D15232: Update deprecated use of setResizeMode().
Sep 3 2018, 8:43 AM · Calligra: 3.0
dcaliste added a reviewer for D15231: Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl: Calligra: 3.0.
Sep 3 2018, 8:22 AM · Calligra: 3.0
dcaliste requested review of D15231: Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl.
Sep 3 2018, 8:22 AM · Calligra: 3.0
dcaliste updated the diff for D15053: Consistently use qreal in libs/pigment.

Update the patch not to use the form `qBound(qreal(0.0), a, qreal(1.0))` but `qBound<qreal>(0.0, a, 1.0)` instead. For reference, original form was `qBound(0.0, a, 1.0)` which was causing issues when qreal <-> float, because of mixed doubles and floats.

Sep 3 2018, 8:14 AM · Calligra: 3.0

Aug 29 2018

dcaliste added a comment to D15102: Update deprecated QAbstractItemModel::reset() to use {begin,end}ResetModel() instead.

@piggz thank you for the proposition. I've discussed with jpetrell, pvuorela and lbt on #sailfishos (see Tuesday 21th discussion, or the Tuesday before) and currently they prefer to have KF5 dependency packages within Calligra, not as standalone libraries in mer-core. Depending later on additional packages creating new demand on KF5, some packages may be migrated to mer-core. So far so good for me. I think 5.34 is the latest version to compile with 5.6 (at least, that's the case for KI18n, so I'm using consistently this version for the other packages). I'm using git repos, so there is no problem to get any version I want. It's a matter of git checkout v5.xx.0.

Aug 29 2018, 4:17 PM · Calligra: 3.0
dcaliste added reviewers for D15103: Replace deprecated use of QWeakPointer<QObject*> in favor of QPointer<QObject*>: leinir, danders.
Aug 29 2018, 12:34 PM · Calligra: 3.0
dcaliste added a comment to D15102: Update deprecated QAbstractItemModel::reset() to use {begin,end}ResetModel() instead.

@leinir, thank you. Instead of compiling with deprecation off, it's better to correct them ;)

Aug 29 2018, 12:33 PM · Calligra: 3.0

Aug 27 2018

dcaliste updated the diff for D15103: Replace deprecated use of QWeakPointer<QObject*> in favor of QPointer<QObject*>.

Propagate changes into filters: missing conversion from QSharedPointer into QPointer.

Aug 27 2018, 3:13 PM · Calligra: 3.0
dcaliste requested review of D15103: Replace deprecated use of QWeakPointer<QObject*> in favor of QPointer<QObject*>.
Aug 27 2018, 2:59 PM · Calligra: 3.0
dcaliste requested review of D15102: Update deprecated QAbstractItemModel::reset() to use {begin,end}ResetModel() instead.
Aug 27 2018, 2:47 PM · Calligra: 3.0

Aug 24 2018

dcaliste added a comment to D15053: Consistently use qreal in libs/pigment.

After test (PRODUCTSET="KARBON"), it's not breaking karbon build on amd64.

Aug 24 2018, 1:01 PM · Calligra: 3.0
dcaliste added a comment to D15053: Consistently use qreal in libs/pigment.

Ok, I'll try in the afternoon or during the week-end and comment here.

Aug 24 2018, 11:47 AM · Calligra: 3.0
dcaliste added a comment to D15053: Consistently use qreal in libs/pigment.

I'm crosscompiling in SailfishOS SDK. I'm in the process of upgrading Calligra there to latest version. @leinir have done it earlier with version 2.9.x. At that moment, pigment was not containing that kind of function to change luminosity... where the conversions are used. I don't know if it's the best way to handle the issue. Don't hesitate to comment !

Aug 24 2018, 10:49 AM · Calligra: 3.0
dcaliste requested review of D15053: Consistently use qreal in libs/pigment.
Aug 24 2018, 9:51 AM · Calligra: 3.0

Aug 22 2018

dcaliste updated the diff for D14975: Don't use obsolete QRectF and QAbstractItemModel functions.

Update the patch in stackChanged() call to have the exact behaviour than before in this method.

Aug 22 2018, 8:24 AM · Calligra: 3.0
dcaliste added a comment to D14975: Don't use obsolete QRectF and QAbstractItemModel functions.

@danders I agree with your remark, I was wondering exactly the same. It's safer to put the begin / end together. I'll update the diff and add a comment to suggest to move the end after the setCurrentIndex() after extensive testing.

Aug 22 2018, 8:22 AM · Calligra: 3.0
dcaliste retitled D14975: Don't use obsolete QRectF and QAbstractItemModel functions from Don't use obsolete QRectF functions to Don't use obsolete QRectF and QAbstractItemModel functions.
Aug 22 2018, 7:17 AM · Calligra: 3.0

Aug 21 2018

dcaliste updated the diff for D14975: Don't use obsolete QRectF and QAbstractItemModel functions.

I've added replacements for QAbstractItemModel::reset(). This allow to "lock" the model during the reset. So I've tried to put the beginResetModel() before the change of the private members, and the endResetModel() after.

Aug 21 2018, 1:35 PM · Calligra: 3.0
dcaliste added a comment to D14975: Don't use obsolete QRectF and QAbstractItemModel functions.

@anthonyfieroni Ok, will update the diff with other replacements of obsolete functions.

Aug 21 2018, 1:24 PM · Calligra: 3.0
dcaliste requested review of D14975: Don't use obsolete QRectF and QAbstractItemModel functions.
Aug 21 2018, 1:12 PM · Calligra: 3.0