Differential D14567

Move declarativeplugin to top-level dir
ClosedPublic
Actions

Authored by nicolasfella on Aug 2 2018, 9:14 PM.

Tags

Subscribers

piggz, kdeconnect

Details

Reviewers

piggz
apol

Group Reviewers

Commits

R224:d9f427aaeb64: Move declarativeplugin to top-level dir

Summary

It's not only used by the plasmoid any more but also SFOS and the app use it.

Test Plan

Builds, App runs fine

Diff Detail

Repository

R224 KDE Connect

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Aug 2 2018, 9:14 PM

Restricted Application added a project: KDE Connect. · View Herald TranscriptAug 2 2018, 9:14 PM

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

nicolasfella requested review of this revision.Aug 2 2018, 9:14 PM

Harbormaster completed remote builds in B1469: Diff 38981.Aug 2 2018, 9:14 PM

built and tested ok on sfos

This revision is now accepted and ready to land.Aug 2 2018, 9:33 PM

nicolasfella added a dependent revision: D14571: Show icons in plugin list.Aug 2 2018, 11:55 PM

apol accepted this revision.Aug 3 2018, 12:19 AM

Closed by commit R224:d9f427aaeb64: Move declarativeplugin to top-level dir (authored by nicolasfella). · Explain WhyAug 3 2018, 12:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (9 lines)
V			{ ← plasmoid}/declarativeplugin/CMakeLists.txt
V			{ ← plasmoid}/declarativeplugin/kdeconnectdeclarativeplugin.h
V			{ ← plasmoid}/declarativeplugin/kdeconnectdeclarativeplugin.cpp
V			{ ← plasmoid}/declarativeplugin/objectfactory.h
V			{ ← plasmoid}/declarativeplugin/qml/DBusProperty.qml
V			{ ← plasmoid}/declarativeplugin/qml/PluginChecker.qml
V			{ ← plasmoid}/declarativeplugin/qmldir
V			{ ← plasmoid}/declarativeplugin/responsewaiter.h
V			{ ← plasmoid}/declarativeplugin/responsewaiter.cpp
M			plasmoid/CMakeLists.txt (5 lines)
V			{plasmoid → }/declarativeplugin/CMakeLists.txt
V			{plasmoid → }/declarativeplugin/kdeconnectdeclarativeplugin.h
V			{plasmoid → }/declarativeplugin/kdeconnectdeclarativeplugin.cpp
V			{plasmoid → }/declarativeplugin/objectfactory.h
V			{plasmoid → }/declarativeplugin/qml/DBusProperty.qml
V			{plasmoid → }/declarativeplugin/qml/PluginChecker.qml
V			{plasmoid → }/declarativeplugin/qmldir
V			{plasmoid → }/declarativeplugin/responsewaiter.h
V			{plasmoid → }/declarativeplugin/responsewaiter.cpp

Diff 38989

CMakeLists.txt

Loading...

declarativeplugin/CMakeLists.txt

Loading...

declarativeplugin/kdeconnectdeclarativeplugin.h

Loading...

declarativeplugin/kdeconnectdeclarativeplugin.cpp

Loading...

declarativeplugin/objectfactory.h

Loading...

declarativeplugin/qml/DBusProperty.qml

Loading...

declarativeplugin/qml/PluginChecker.qml

Loading...

declarativeplugin/qmldir

Loading...

declarativeplugin/responsewaiter.h

Loading...

declarativeplugin/responsewaiter.cpp

Loading...

plasmoid/CMakeLists.txt

Loading...

plasmoid/declarativeplugin/CMakeLists.txt

Loading...

plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.h

Loading...

plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp

Loading...

plasmoid/declarativeplugin/objectfactory.h

Loading...

plasmoid/declarativeplugin/qml/DBusProperty.qml

Loading...

plasmoid/declarativeplugin/qml/PluginChecker.qml

Loading...

plasmoid/declarativeplugin/qmldir

Loading...

plasmoid/declarativeplugin/responsewaiter.h

Loading...

plasmoid/declarativeplugin/responsewaiter.cpp

Loading...