Support params in report queries
ClosedPublic

Authored by piggz on Sep 11 2018, 9:22 PM.

Details

Summary

Prompt for parameters in queries that use them

Quite a small change. Minor issues exist:

  1. When opening in design view, the data source is opened and therefore the parameters are prompted for (twice)

Bug: https://bugs.kde.org/show_bug.cgi?id=379694

BUG: 379694

Test Plan

Open a report using paramters, ensure they are prompted for, and ensure they are used correctly

Diff Detail

Repository
R71 Kexi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
piggz created this revision.Sep 11 2018, 9:22 PM
Restricted Application added a project: KEXI. · View Herald TranscriptSep 11 2018, 9:22 PM
Restricted Application added a subscriber: Kexi-Devel-list. · View Herald Transcript
piggz requested review of this revision.Sep 11 2018, 9:22 PM
piggz edited the summary of this revision. (Show Details)Sep 11 2018, 9:23 PM
piggz edited the summary of this revision. (Show Details)Sep 11 2018, 9:27 PM
staniek updated this revision to Diff 41439.Sep 11 2018, 10:09 PM

Moving to 3.1

Good job. We want to develop it for 3.1 not master so I updated the patch for you.

staniek accepted this revision.EditedSep 11 2018, 10:11 PM

I can experiment a bit to see how to remove the double parameter dialog. But does it not work for me in data view...

This revision is now accepted and ready to land.Sep 11 2018, 10:11 PM
staniek requested changes to this revision.Sep 11 2018, 10:26 PM
This revision now requires changes to proceed.Sep 11 2018, 10:26 PM
staniek updated this revision to Diff 41440.Sep 11 2018, 10:33 PM
  • Add missing params for generateSelectStatement
staniek accepted this revision.Sep 11 2018, 10:36 PM
This revision is now accepted and ready to land.Sep 11 2018, 10:36 PM
piggz added a comment.Sep 12 2018, 6:19 AM

Out of interest, how can I use arc to update my local branch with your changes?

Out of interest, how can I use arc to update my local branch with your changes?

I would try this: arc patch D15438 but this will give you a single commit.

There are problems:

  • I wanted to work in 3.1 so I started fresh in 3.1 and cherry-picked your original commit
  • I added my 2 commits so arc squishes the 3 into one 'my' commit. I would prefer to see git merge

So I pushed D15438 branch to origin. Please switch there, add your new commits if there are any and use 'arc diff' to upload them.

When we're done I propose to use this on D15438:

arc land --merge --onto 3.1 --hold

(use --hold first to see if everthing is allright, if so you can git push origin/3.1)

piggz updated this revision to Diff 41502.Sep 12 2018, 8:14 PM

Move paramter fetching to open() from getSchema()

This fixes asking for parameters in design view

staniek accepted this revision.Sep 12 2018, 9:34 PM

Brilliant!

This revision was automatically updated to reflect the committed changes.
piggz edited the summary of this revision. (Show Details)Sep 13 2018, 4:50 PM