Fix handling ORDER BY part of queries
ClosedPublic

Authored by staniek on May 14 2018, 12:16 PM.

Details

Summary
  • maintain relations between connections, queries and column infos
  • fix cloning queries with ORDER BY
  • update and add autotests

FIXED-IN:3.2
BUG:392753
CCBUG:393705

Test Plan

Required: KEXI & KDb 3.2 (current master)

Test 1: Open report and query from https://bugs.kde.org/show_bug.cgi?id=392753#c0 in design and data views.
Expected: works, no crashes

Test 2: Try these on a standard Persons and Cars test:
select id from cars order by owner;
select id from cars order by owner, model, id;
select id, model from cars order by 2, 1;

Expected: works, no crash

Diff Detail

Repository
R15 KDb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
staniek created this revision.May 14 2018, 12:16 PM
Restricted Application added a project: KDb. · View Herald TranscriptMay 14 2018, 12:16 PM
staniek requested review of this revision.May 14 2018, 12:16 PM
staniek edited the test plan for this revision. (Show Details)May 14 2018, 12:17 PM
piggz accepted this revision.May 16 2018, 6:16 AM

Surprising how many changes for one crash!

This revision is now accepted and ready to land.May 16 2018, 6:16 AM
This revision was automatically updated to reflect the committed changes.