-Fix type in pause icon
-Remove unnescessary label
-Size volumne slider correctly
-Centre buttons
-Make volume control work
Details
Details
- Reviewers
nicolasfella kossebau albertvaka - Group Reviewers
KDE Connect - Commits
- R224:064b07c0ce8a: Fixup the sfos mpris control
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
In any case, feel free to push directly to the sfos parts of kdeconnect, I don't think we have the know-how in the team to review properly.
Also feel free to find someone who knows sailfish to review, that would work as well.
| sfos/qml/pages/mpris.qml | ||
|---|---|---|
| 44 | Usually using the declarative API is better. | |
| 81–82 | Maybe use RowLayout? | |
| sfos/qml/pages/mpris.qml | ||
|---|---|---|
| 81–82 | yeah, it's what you had before, so I guess it's not working well? | |
| sfos/qml/pages/mpris.qml | ||
|---|---|---|
| 81–82 | no, i was using Row before, not RowLayout .... i will try RowLayout later. When i bound the slider.value to the pluginInterface.volume, i found that the slider jumped around for a few seconds after opening the page, ill have a play around and see what works best | |
Comment Actions
- Enable mpriscontrol also on sailfish
- Add features from kde app mpris control and use QtQuick Layouts
- Add layouts to .spec
Comment Actions
As Aleix mentioned, feel free to push changes to the sfos/ directory without review if you want.
It's really good to have the sfos port in the same repository and to share code, but most of the time we can't really help you with the sfos-specific parts and it will just make your development slower.
| sfos/qml/pages/mpris.qml | ||
|---|---|---|
| 44 | I mean it's usually better to do: Not that you need to use a different library or something. | |