Make Calligra unstable (master) depend on stable kreport and kproperty components
AbandonedPublic

Authored by staniek on Jan 5 2017, 4:58 PM.

Details

Reviewers
bcooksley
piggz
Summary

Make Calligra unstable (master) depend on stable kreport and kproperty components as these are external ones.
Stable and development APIs differ for these deps.

Test Plan

build.kde.org for calligra unstable should work again.

Diff Detail

Repository
R499 Metadata for build scripts
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
staniek updated this revision to Diff 9773.Jan 5 2017, 4:58 PM
staniek retitled this revision from to Make Calligra unsable (master) depend on stable kreport and kproperty components.
staniek updated this object.
staniek edited the test plan for this revision. (Show Details)
staniek added a reviewer: bcooksley.
staniek added a subscriber: danders.
staniek added a subscriber: kossebau.
bcooksley edited edge metadata.Jan 5 2017, 7:06 PM

That syntax has no effect - branch specifiers are not supported on the RHS of the equation (and don't have much of an impact on the LHS either).
With the current CI architecture your requirements here aren't supported.

The upcoming move to tracks should allow this.

staniek added a subscriber: rempt.EditedJan 6 2017, 3:47 PM

Thanks @bcooksley.

@danders @rempt, so my conclusion is to set kreport/kproperty 3.1 alpha as a minimum for calligra 3.1. But I see calligra master is 3.0.1. So I am not sure how it all fits together -- don't we need a place for unstable development of calligra?

For the record: KReport/KProperty 3.0 is not API-stable, it was not is KDEreview and such, 3.1 will be, I hope.

rempt removed a subscriber: rempt.Jan 8 2017, 11:50 AM
staniek retitled this revision from Make Calligra unsable (master) depend on stable kreport and kproperty components to Make Calligra unstable (master) depend on stable kreport and kproperty components.Nov 1 2017, 7:28 PM
staniek edited the summary of this revision. (Show Details)

I have deactivated reports atm. I will wait for kreport/kproperty to be stable so no need to make any special adjustments.

Thanks for the info @danders. If you have time you can try to reactivate for the current master, or you can wait - we're close to ship Beta 3.1.

staniek added a comment.EditedMar 23 2018, 10:05 AM

I have deactivated reports atm. I will wait for kreport/kproperty to be stable so no need to make any special adjustments.

3.1.0 has been released and has guaranteed API stability. I see plan/CMakeLists.txt depends on it so I would drop this patch.

piggz accepted this revision.Aug 2 2018, 9:05 PM
piggz added a subscriber: piggz.

lgtm

This revision is now accepted and ready to land.Aug 2 2018, 9:05 PM
staniek abandoned this revision.Aug 23 2018, 8:42 PM

@bcooksley I'll be back to the topic when it's possible