Differential D27286

Improve markdownToRichText
ClosedPublic
Actions

Authored by kfunk on Feb 10 2020, 2:26 PM.

Details

Reviewers
mlaurent
dfaure
Commits
R865:ccde003a3e83: Improve markdownToRichText
Summary

Let it replace []() style Markdown URLs as well.

Fixes generated HTML for []() style URLs.

Diff Detail

Repository
R865 Ruqola
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk requested review of this revision.Feb 10 2020, 2:26 PM
kfunk created this revision.
kfunk added a reviewer: mlaurent.Feb 10 2020, 2:27 PM

Not sure I like this change myself but it fixes support for [](). Other ideas welcome.

kfunk updated this revision to Diff 75366.Feb 10 2020, 2:32 PM

Typo fix

kfunk updated this revision to Diff 75368.Feb 10 2020, 2:34 PM

Improve naming in test

kfunk updated this revision to Diff 75370.Feb 10 2020, 2:44 PM

Fix another typo...

mlaurent accepted this revision.Feb 10 2020, 2:49 PM

Seems correct for me :)

This revision is now accepted and ready to land.Feb 10 2020, 2:49 PM
Closed by commit R865:ccde003a3e83: Improve markdownToRichText (authored by kfunk). · Explain WhyFeb 10 2020, 3:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/autotests/utilstest.cpp (2 lines)
Msrc/core/room.cpp (4 lines)
Msrc/core/utils.h (10 lines)
Msrc/core/utils.cpp (15 lines)

Diff 75377

View Options

src/core/autotests/utilstest.cpp

Loading...
View Options

src/core/room.cpp

Loading...
View Options

src/core/utils.h

Loading...
View Options

src/core/utils.cpp

Loading...