Do not create User class on heap
7929384beb80
Actions

Authored by kfunk on Feb 12 2020, 9:53 AM.

Description

Do not create User class on heap

Summary:
Simplifies memory management when using this type. The app is taking
care of e.g. updating the user status of a user in all models already.
(cf. follow userStatusChanged signal uses)

Reviewers: mlaurent, dfaure

Reviewed By: mlaurent

Differential Revision: https://phabricator.kde.org/D27349

Details

Committed

kfunk

Feb 12 2020, 9:14 PM

Reviewer

mlaurent

Differential Revision

D27349: Do not create User class on heap

Parents

R865:115fb196b790: Use directly ChannelBaseJob::ChannelInfo so we can use roomName or

Branches

Unknown

Tags

Unknown

kfunk committed R865:7929384beb80: Do not create User class on heap (authored by kfunk).Feb 12 2020, 9:14 PM

Changes (13)

				Path	Packages
	M			src/core/autotests/usersforroomfilterproxymodeltest.cpp
	M			src/core/autotests/usersforroommodeltest.cpp
	M			src/core/autotests/usertest.cpp
	M			src/core/model/roommodel.cpp
	M			src/core/model/roommodel.h
	M			src/core/model/usersforroommodel.cpp
	M			src/core/model/usersforroommodel.h
	M			src/core/model/usersmodel.cpp
	M			src/core/model/usersmodel.h
	M			src/core/rocketchataccount.cpp
	M			src/core/rocketchataccount.h
	M			src/core/rocketchatbackend.cpp
	M			src/core/user.h