Differential D27341

message: Never turn an Image into NormalText
ClosedPublic
Actions

Authored by kfunk on Feb 12 2020, 8:43 AM.

Details

Reviewers
mlaurent
dfaure
Commits
R865:5032df9a6c81: message: Never turn an Image into NormalText
Summary

This fixes the Gify posts from our channel bot

Diff Detail

Repository
R865 Ruqola
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk requested review of this revision.Feb 12 2020, 8:43 AM
kfunk created this revision.
kfunk updated this revision to Diff 75518.Feb 12 2020, 8:50 AM

Fix tests

kfunk added a reviewer: dfaure.Feb 12 2020, 9:29 AM

Note: This seems to fix the Gify previews in both ruqola + ruqolaqml.

Not sure the check was there before?

mlaurent requested changes to this revision.Feb 12 2020, 10:07 AM

I added this check when I found a bug about no image preview in message.
Too bad I didn't add testcase for it...

Better to comment line that removing them so we can revert it/improve patch when we will have the bug again.

This revision now requires changes to proceed.Feb 12 2020, 10:07 AM
mlaurent added a comment.Feb 12 2020, 10:09 AM

you can add autotest about it in
"ruqola/src/core/autotests/data/messages"

> create a json file + ref

add it in "void MessageTest::shouldParseJsonMessage_data()"

So we will be sure that we will not break it in the future.

This revision was not accepted when it landed; it landed in state Needs Revision.Feb 12 2020, 11:43 AM
Closed by commit R865:5032df9a6c81: message: Never turn an Image into NormalText (authored by kfunk). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75546

View Options

src/core/autotests/messagetest.cpp

Loading...
View Options

src/core/messages/message.cpp

Loading...