An attempt to fix linking on Windows.
you'll notice that src/contact-editor/contacteditor_private_export.h does not properly define CONTACTEDITOR_TESTS_EXPORT unless BUILD_TESTING is defined
@vonreth if this works, would you be able to update craft to use it? perhaps with a patch?
seems to link ok on Windows now
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/contact-editor/CMakeLists.txt | ||
|---|---|---|
| 228 | add_definitions(-DBUILD_TESTING) only | |
Arg without arc it's not easy to see all code.
Add
if (BUILD_TESTING)
add_definitions(-DBUILD_TESTING) #properly define CONTACTEDITOR_TESTS_EXPORT
endif()
before to generate lib.
if you add before autotests lib will not compiled with correct flags.
see "2f552ac573770ce22ec5489b22c6269280aa4e36"
@kfunk ^
it seems that it changed it.
We need to know why.
ping. we need to get this sorted. the CI is complaining daily about the broken build on Windows
Update.
Commit message:
Revert "Fix windows build" That patch was wrong. BUILD_TESTING needs to always be defined when testing is enabled so the *_TESTS_EXPORT macros are filled out properly. I think this patch initially just worked around an issue which was fixed by https://phabricator.kde.org/D20091. Phabricator Revisino: https://phabricator.kde.org/D28759 This reverts commit 2f552ac573770ce22ec5489b22c6269280aa4e36.