Do not create User class on heap
ClosedPublic
Actions

Authored by kfunk on Feb 12 2020, 3:28 PM.

Details

Reviewers

mlaurent
dfaure

Commits

R865:7929384beb80: Do not create User class on heap

Summary

Simplifies memory management when using this type. The app is taking
care of e.g. updating the user status of a user in all models already.
(cf. follow userStatusChanged signal uses)

Diff Detail

Repository

R865 Ruqola

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kfunk requested review of this revision.Feb 12 2020, 3:28 PM

kfunk created this revision.

Harbormaster completed remote builds in B22404: Diff 75555.Feb 12 2020, 3:28 PM

mlaurent accepted this revision.Feb 12 2020, 8:44 PM

This revision is now accepted and ready to land.Feb 12 2020, 8:44 PM

Closed by commit R865:7929384beb80: Do not create User class on heap (authored by kfunk). · Explain WhyFeb 12 2020, 9:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/core/autotests/usersforroomfilterproxymodeltest.cpp (12 lines)
M			src/core/autotests/usersforroommodeltest.cpp (34 lines)
M			src/core/autotests/usertest.cpp (4 lines)
M			src/core/model/roommodel.h (2 lines)
M			src/core/model/roommodel.cpp (4 lines)
M			src/core/model/usersforroommodel.h (6 lines)
M			src/core/model/usersforroommodel.cpp (61 lines)
M			src/core/model/usersmodel.h (12 lines)
M			src/core/model/usersmodel.cpp (50 lines)
M			src/core/rocketchataccount.h (2 lines)
M			src/core/rocketchataccount.cpp (6 lines)
M			src/core/rocketchatbackend.cpp (14 lines)
M			src/core/user.h (2 lines)