RocketChatAccount: Try to reduce delegating funcs
ClosedPublic
Actions

Authored by kfunk on Feb 11 2020, 11:44 AM.

Details

Reviewers

dfaure
mlaurent

Commits

R865:500c8e32892e: RocketChatAccount: Try to reduce delegating funcs

Summary

Removes the burden of writing wrapper functions delegating to other
QObject instances. Instead just give the other QObject classes more
responsibility and make them accessible from QML.

Start with InputTextManager class.

Diff Detail

Repository

R865 Ruqola

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kfunk requested review of this revision.Feb 11 2020, 11:44 AM

kfunk created this revision.

Harbormaster completed remote builds in B22355: Diff 75455.Feb 11 2020, 11:44 AM

dfaure accepted this revision.Feb 11 2020, 10:22 PM

This revision is now accepted and ready to land.Feb 11 2020, 10:22 PM

Closed by commit R865:500c8e32892e: RocketChatAccount: Try to reduce delegating funcs (authored by kfunk). · Explain WhyFeb 12 2020, 7:26 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/apps/qml/qml/MainComponent.qml (2 lines)
M			src/apps/qml/qml/MessageLine.qml (8 lines)
M			src/apps/qml/qml/ShowThreadMessagesDialog.qml (2 lines)
M			src/apps/qml/qml/UserInput.qml (4 lines)
M			src/core/autotests/rocketchataccounttest.cpp (4 lines)
M			src/core/ddpapi/ddpclient.cpp (2 lines)
M			src/core/inputtextmanager.h (5 lines)
M			src/core/rocketchataccount.h (14 lines)
M			src/core/rocketchataccount.cpp (25 lines)
M			src/widgets/room/messagetextedit.cpp (4 lines)