Re-enable auto-reconnect, after fixing logout.
ClosedPublic

Authored by dfaure on Thu, Feb 13, 11:00 PM.

Details

Summary
  • Disconnect websocket in ~DDPClient to avoid auto-reconnect
  • Make logout actually work by returning true in canStart() (obvious typo)

Also, don't clear the password on logout. I want to be able to log in again
without having to type the password again. No idea why this clear() was
there.

Cleanups: remove unused signal logoutDone() and unimplemented method DDPClient::logOut

Test Plan

Logout stays on login page, with password filled in.
Disconnecting from WIFI for a few minutes and then connecting again leads to the server
throwing us out, and ruqola reconnects.

Diff Detail

Repository
R865 Ruqola
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure requested review of this revision.Thu, Feb 13, 11:00 PM
dfaure created this revision.
kfunk accepted this revision.Fri, Feb 14, 7:45 AM

Looks good to me, but didn't test.

This revision is now accepted and ready to land.Fri, Feb 14, 7:45 AM
mlaurent accepted this revision.Fri, Feb 14, 8:13 AM
This revision was automatically updated to reflect the committed changes.