As I have some free time due to the virus and I'm trying to get up to date.

Sorry, bad Copy/Paste. In the same article:

I'm not totally sure this theme is legal in Spain:
https://www.boe.es/buscar/act.php?id=BOE-A-2005-21261

In D10742#499346, @aacid wrote:

@jtamate Does that "let's continue in that other review" mean we should cancel this one? Still shows on the list of reviews to consider

In T10812#182201, @ngraham wrote:

In T10812#182195, @aacid wrote:

Apps that are in the bundle have inconsistent versioning; most use the bundle's own versioning scheme, but others use their own

I personally disagree this is a problem. It let's applications hop on and off the release and keep their versioning number intact.

I'm using Dolphin 18.12.3, which comes from KDE Applications 18.12.3. But the bundle also comes with Okular. Am I using Okular 18.12.3? Or Okular 1.6.3? The promo material says 18.12.3. The version number in my distro's packaging says 18.12.3. Discover, which uses the distro packaging metadata, says 18.12.3. But the About Okular window says 1.6.3. This is confusing and problematic from a user, packager, and promo perspective because it's not clear which version number they should use.

As I don't have enough contiguous free time even to test it again, feel free to commit.
You can add a comment to remember that it doesn't fix all the cases but is an improvement over previous situation.

The more I try to understand my own explanations, the less I agree with my past me.

+1.
Just out of curiosity, Did you notice the problem because something was missing in execution? Unfortunately, neither the compiler nor I didn't noticed it. :-(

With this version, the test with the patch applied is everlasting in:

Changes requested done and reduced code duplication.

Added the unit test. It crashes for me every time without the patch and none with the patch.

I'll work on the unit test this weekend. I don't currently have enough free time on weekdays.

There is no need for a unit test, it is already in kdirmodeltest (but perhaps could be expanded in another patch).

I think this time I got the problem right.
One of the classics: I was modifying the list while it was being used.

Let's continue on D17619

I'm able to reproduce the bug with the following steps:

• Create a folder structure X/X1/X2/X3/X4 and add a new empty text file into each folder.
• Within Dolphin, open a tab for each folder.
• In the tab showing X contents, rename X1 to X1_ and the crash is there.

I've been able to reproduce the bug:

What protocol does KTcpSocket::SecureProtocols implement (I can't guess it)? If it is the same as QSsl:SecureProtocols
it does:
On the client side, this will send a TLS 1.0 Client Hello, enabling TLSv1_0 and SSLv3 connections. On the server side, this will enable both SSLv3 and TLSv1_0 connections.

Created https://bugreports.qt.io/browse/QTBUG-71137

Just in case, I'm subscribed now to the RSS https://build.kde.org/job/Frameworks/job/kio/rssFailed

QTest::qWaitForWindowActive fails because I use kwin Focus stealing prevention High, therefore the windows doesn't become active until I click on them in the task bar or switch to them.
And qWaitForWindowExposed doesn't help because the window/widget needs to have the focus.

Fix a crash ,caused by a still connected signal, after running again the unittests.
kfilewidgettest still doesn't pass because QTest::qWaitForWindowActive fails for me.

I am really, really sorry. I have no excuses to not have run the autotests (that I usually run after my first fiasco). Hopefully, after my second fiasco, I'll run them before creating any review request.

closed again by commits:
https://commits.kde.org/dolphin/5d180c5bb280f68cb98996044055e6891e29bab7
https://commits.kde.org/dolphin/b610ce5913ef3172f3cf15c0a1d93c255ea0da4f

Keep both key sequences in case someone used ctrl+shift+n.

As it turns out, QKeySequence::AddTab is Ctrl+Shift+N under plasma.
Filled Qt bug: https://bugreports.qt.io/browse/QTBUG-70963
Change to Qt::CTRL + Qt::Key_T.

A comment disappeared in the conversion.

Changed 2 more 5 by 4.

Changed comma style in initialization lists.
Using member initialization in the class declaration.
Added a constructor not detected before.

No email was sent with yesterday update (or I didn't receive any), this comment is just to notify yesterday change.

Removed the tooltip, I think it is counterproductive now.
Changed the button text into + icon.

I've tried to do an automatic benchmark of the rename case, without success.
Changed code as requested.

Copy the methods getUserName and getGroupName from kfile, those are cached, should be faster.
Keep the fastInsert for another revision.

Forget what I just wrote. I've seen that I was missing 15 lines in between then in the phabricator diff view. :-(
Looks good to me.

What would happen if finishNotification is called twice, In line 161 and then in line 192?
My guess is that finished signal will be called twice with the same notification, and therefore KNotificationManager::notifyPluginFinished will be called twice. I don't know what will happen the second time.
Perhaps a return after line 161 is needed?

White at it, use fastInsert.
And this also fixes the search in the home directory :-).
The title in English :-).

I didn't realize the notifications are not owned by m_notifications :-(.
Just looking at the backtrace of the crash, it was the only suspicious thing.

Ok by side. It installs now, and don't ask for passwords.

I'm trying to check if it works with password-protected files, but I can't install it.
The patch is missing opendocumentthumbnail.desktop.

I haven't tested it, therefore I ask: Does this thumbnailer ask for password for password protected files, like in https://bugs.kde.org/show_bug.cgi?id=394284 ?

Continue processing the XML with invalid urls.
And a trivial code deduplication, I couldn't resist.

Another solution (not tested here but used in other projects) could be to use
with open(source, "r", encoding="utf-8") as f:
(or if the file could contain the aberration BOM, you could use "utf-8-sig")

In D12016#323833, @volkov wrote:

I get the following warning from valgrind because of this change:

Fix in D15420

It works for me if I use ctest -j6 . but fails for me if I use ctest -j12 . or ctest -j4 .

Use nullptr instead of 0.
Remove the copied/pasted part of the cause of two dissconnects.

Changed to 'Anonymous' connects and disconnects.

Changed [&] by [this]in the lambdas.
Added a lambda for KActionCollection::addAction. I didn't knew it was already possible.