Differential D16072

Avoid waiting for user actions when kwin Focus stealing prevention is high or extreme
ClosedPublic
Actions

Authored by jtamate on Oct 9 2018, 1:21 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:63093179579c: Avoid waiting for user actions when kwin Focus stealing prevention is high or…
Summary

When kwin focus stealing prevention is high or extreme, I had to activate manually the tests windows for the test to continue.
Now it is activated without human intervention.

Test Plan

kfilewidgettest and kfileplaceswidgettest pass without human intervention.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jtamate created this revision.Oct 9 2018, 1:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 9 2018, 1:21 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
jtamate requested review of this revision.Oct 9 2018, 1:21 PM
dfaure accepted this revision.Oct 14 2018, 9:22 AM

Looks good, but this might be worth fixing in QTest::qWaitForWindowActive itself, for all other unittests using that (including Qt's own).

This revision is now accepted and ready to land.Oct 14 2018, 9:22 AM
Closed by commit R241:63093179579c: Avoid waiting for user actions when kwin Focus stealing prevention is high or… (authored by jtamate). · Explain WhyOct 14 2018, 9:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43579

View Options

autotests/kfileplacesviewtest.cpp

Loading...
View Options

autotests/kfilewidgettest.cpp

Loading...