Differential D19500

[KDirModel] Fix job urls change signal connection
AcceptedPublic
Actions

Authored by broulik on Mar 3 2019, 10:03 PM.

Details

Reviewers
dfaure
jtamate
Group Reviewers
Frameworks
Summary

The private slot declaration for _k_slotJobUrlsChanged got removed as part of D12095 but the slot never actually ported breaking the transfers visible feature.

Test Plan

Signal is emitted properly again when enabled

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 3 2019, 10:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 3 2019, 10:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 3 2019, 10:03 PM
jtamate added a comment.Mar 4 2019, 8:11 AM

+1.
Just out of curiosity, Did you notice the problem because something was missing in execution? Unfortunately, neither the compiler nor I didn't noticed it. :-(

broulik added a comment.Mar 4 2019, 8:15 AM

Just out of curiosity, Did you notice the problem because something was missing in execution?

I was toying around with the transfer jobs visible feature in KDirModel and got a warning when I enabled it. It isn't used by Dolphin anymore and not supported by Plasma, so I don't think it was that big of an issue.

dfaure accepted this revision.Mar 17 2019, 9:10 AM

If there was a unittest for this code, it wouldn't remain broken for so long... Feel free to add one :-)

This revision is now accepted and ready to land.Mar 17 2019, 9:10 AM

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kdirmodel.cpp (48 lines)

Diff 53086

View Options

src/widgets/kdirmodel.cpp

Loading...