Add a + button and the clear button to Add New Tag
ClosedPublic
Actions

Authored by jtamate on Sep 28 2018, 8:29 AM.

Details

Reviewers

rempt

Group Reviewers

Krita

Commits

Summary

Add an + button and the clear button to Add New Tag.
It should be easier to use.

BUG: 396392

Test Plan

The new aspect of the menu is:

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

jtamate requested review of this revision.Sep 28 2018, 8:29 AM

I like it, but the button should use an icon instead of a text label. list-add would be the right one to use.

This revision now requires changes to proceed.Sep 28 2018, 8:46 AM

Removed the tooltip, I think it is counterproductive now.
Changed the button text into + icon.

No email was sent with yesterday update (or I didn't receive any), this comment is just to notify yesterday change.

Weird, I'm pretty sure I accepted the revision yesterday...

This revision is now accepted and ready to land.Sep 29 2018, 3:50 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			libs/widgets/KoResourceItemChooserContextMenu.h (5 lines)
M			libs/widgets/KoResourceItemChooserContextMenu.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	42464			Sep 28 2018, 8:19 AM	★	★
Diff 2	42468			Sep 28 2018, 9:54 AM	★	★
Diff 3	42585	ea03f10	R37:1b50235ce3c2e375da37a905a64cd5864da64497	Sep 30 2018, 7:36 AM	★	★