Running anything else in parallel to this test would make it fail,
because windowAdded() would be emitted with an unrelated window.
If we couldn't find our dialog when the signal is emitted,
just keep waiting for the signal to be emitted again.
Details
Details
ctest -j 8 .
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1667 Build 1685: arc lint + arc unit
Comment Actions
It works for me if I use ctest -j6 . but fails for me if I use ctest -j12 . or ctest -j4 .
13/15 Test #3: plasma-dialogstatetest ...........***Failed 2.42 sec
3/15 Test #3: plasma-dialogstatetest ...........***Failed 1.71 sec
Comment Actions
That doesn't tell me much about the failure you mention -- what, how and why...
I still think the patch is an improvement and should be pushed -- but now I regret putting it up for review, I almost completely forgot about it....
Comment Actions
As I don't have enough contiguous free time even to test it again, feel free to commit.
You can add a comment to remember that it doesn't fix all the cases but is an improvement over previous situation.