Differential D16020

KFilePlacesModel: fix previous commit to avoid duplicating devices
ClosedPublic
Actions

Authored by dfaure on Oct 7 2018, 4:31 PM.

Details

Reviewers
jtamate
Commits
R241:45fb19db41ff: KFilePlacesModel: fix previous commit to avoid duplicating devices
Test Plan

kfileplacesmodeltest

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3595
Build 3613: arc lint + arc unit
dfaure created this revision.Oct 7 2018, 4:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 7 2018, 4:31 PM
Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. · View Herald Transcript
dfaure requested review of this revision.Oct 7 2018, 4:31 PM
jtamate accepted this revision.Oct 8 2018, 7:16 AM

I am really, really sorry. I have no excuses to not have run the autotests (that I usually run after my first fiasco). Hopefully, after my second fiasco, I'll run them before creating any review request.

With your patch, all the fails from this unit test are gone.

This revision is now accepted and ready to land.Oct 8 2018, 7:16 AM
dfaure closed this revision.Oct 8 2018, 7:43 AM

Revision Contents
Changeset List

Diff 43056

View Options

autotests/kfileplacesmodeltest.cpp

Loading...
View Options

src/filewidgets/kfileplacesmodel.cpp

Loading...