Batch of initialization lists, according to cppcheck it is faster to do it this way.
Details
Details
- Reviewers
rempt - Group Reviewers
Krita - Commits
- R37:97b9e0abfebc: Trivial micro optimizations (initialization lists)
make test zero fails.
Diff Detail
Diff Detail
- Repository
- R37 Krita
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This is good, but where the variable is initialized with a constant, I like it even better if the variables are initialzed where they are declared, with the {} syntax:
int bla {0}
| plugins/paintops/hatching/hatching_brush.cpp | ||
|---|---|---|
| 40 | I prefer to have the , underneath the : -- like: : m_settings(bla) | |
Comment Actions
Changed comma style in initialization lists.
Using member initialization in the class declaration.
Added a constructor not detected before.