Fix drop between shared views

Authored by hoffmannrobert on Jun 19 2018, 3:09 PM.



Remove trailing slash from folderUrl, too, when comparing to
the file's url (minus file name minus trailing slash). FolderUrls
like file:///home/user/Desktop/ may appear and fail comparing.

Fixes regression introduced in 07001277a8a0893aeb54240d7f5cdd9825fb57ed
(see which fixes urls like
file:///home/user/foo (if using a different folder than Desktop)
but breaks moving files from one screen to another using normal
Desktop folder.

Test Plan
  1. Use folder view, Desktop folder, more than one screen.

Create files and folders in Desktop folder and move them from one
screen to another. The Copy/Move/Link menu must not appear
and files/folders must be dropped onto the other screen.

  1. Use a different folder than Desktop (the same on both screens).

Moving files/folders to another screen must work like in 1.

Diff Detail

R119 Plasma Desktop
No Linters Available
No Unit Test Coverage
Build Status
Buildable 126
Build 126: arc lint + arc unit
hoffmannrobert created this revision.Jun 19 2018, 3:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 19 2018, 3:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hoffmannrobert requested review of this revision.Jun 19 2018, 3:09 PM
mart accepted this revision.Jun 20 2018, 8:35 AM
This revision is now accepted and ready to land.Jun 20 2018, 8:35 AM

I don't have commit access, can you please land it for me? Thanks.

Can somebody please land this patch for me? Thanks.

Sorry for the delay!

ngraham closed this revision.Jul 18 2018, 10:42 PM