Fix automatic bullets
ClosedPublic

Authored by hoffmannrobert on Mar 1 2019, 1:58 PM.

Details

Summary

Only create bullets automatically if 'Rich-Text' ist checked
(Settings / Editor). Non-Rich-Text notes loose their bullets
as soon as the note looses its focus or is saved.

Test Plan

Make sure in KNotes editor settings the 'Rich-Text' checkbox is
unchecked. Create a new note, type a '-' or a '*' and some
text behind. Without the fix, an indented bullet would be drawn
in front of the text, the return key would create new lines
starting with a bullet. When clicking any other window the
bullets would disappear.
With the fix applied, no bullets are created.

Switch on the 'Rich-Text' checkbox and create a new note. Bullets
are created automatically if typing '-' or a '*' and do not
disappear when the notes looses focus. Saved notes containing
bullets still show them after restarting knotes.

Diff Detail

Repository
R208 KNotes
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hoffmannrobert created this revision.Mar 1 2019, 1:58 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 1 2019, 1:58 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
hoffmannrobert requested review of this revision.Mar 1 2019, 1:58 PM
dvratil accepted this revision.Mar 11 2019, 6:02 PM
dvratil added a subscriber: dvratil.

Looks good, do you have commit access? If not I can push this for you, otherwise land it on Applications/18.12 branch, please.

This revision is now accepted and ready to land.Mar 11 2019, 6:02 PM

No, I don't have commit access. Please push it for me, thanks.

This revision was automatically updated to reflect the committed changes.